These commits are when the Protocol Buffers files have changed: (only the last 100 relevant commits are shown)
Commit: | 4b1e35f | |
---|---|---|
Author: | Ashoat Tevosyan |
[shared] Update NEXT_CODE_VERSION 483 for `native`, and 161 for `web`
The documentation is generated from this commit.
Commit: | 826d7be | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Update comment with NEXT_CODE_VERSION Summary: https://linear.app/comm/issue/ENG-10427/update-proto-comment-after-landing-client-changes Depends on D14508 Test Plan: None Reviewers: kamil, ashoat Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D14509
Commit: | 96f0146 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Update comment with NEXT_CODE_VERSION Summary: https://linear.app/comm/issue/ENG-10427/update-proto-comment-after-landing-client-changes Depends on D14508 Test Plan: None Reviewers: kamil, ashoat Subscribers:
Commit: | d62e2ca | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Remove primary device info from GetKeyserverKeys Summary: Address [[ https://linear.app/comm/issue/ENG-10247/handle-getkeyserverkeys-when-primary-is-logged-out | ENG-10247 ]]. We can remove this field. Although this is backwards compatible since this field wasn't used anywhere, I marked the field as 'reserved' to avoid reusing its number. Doing so would cause parsing errors on old clients Test Plan: flow, staging identity Reviewers: ashoat, kamil Reviewed By: ashoat, kamil Subscribers: tomek Differential Revision: https://phab.comm.dev/D14492
Commit: | a54b235 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Remove primary device info from GetKeyserverKeys Summary: Address [[ https://linear.app/comm/issue/ENG-10247/handle-getkeyserverkeys-when-primary-is-logged-out | ENG-10247 ]]. We can remove this field. Although this is backwards compatible since this field wasn't used anywhere, I marked the field as 'reserved' to avoid reusing its number. Doing so would cause parsing errors on old clients Test Plan: flow, staging identity Reviewers: ashoat!, kamil! Subscribers: tomek Differential Revision: https://phab.comm.dev/D14492
Commit: | 8dd61b8 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Remove primary device info from GetKeyserverKeys Summary: Address [[ https://linear.app/comm/issue/ENG-10247/handle-getkeyserverkeys-when-primary-is-logged-out | ENG-10247 ]]. We can remove this field. Although this is backwards compatible since this field wasn't used anywhere, I marked the field as 'reserved' to avoid reusing its number. Doing so would cause parsing errors on old clients Test Plan: flow, staging identity Reviewers: ashoat!, kamil! Subscribers: tomek Differential Revision: https://phab.comm.dev/D14492
Commit: | 6656a4c | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Remove primary device info from GetKeyserverKeys Summary: Address [[ https://linear.app/comm/issue/ENG-10247/handle-getkeyserverkeys-when-primary-is-logged-out | ENG-10247 ]]. We can remove this field. Although this is backwards compatible since this field wasn't used anywhere, I marked the field as 'reserved' to avoid reusing its number. Doing so would cause parsing errors on old clients Test Plan: flow, staging identity Reviewers: ashoat!, kamil! Subscribers:
Commit: | 1e9a700 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add comment about siwe fields being social proof Summary: Address [[ https://linear.app/comm/issue/ENG-10151/add-proto-comments-clarifying-siwe-messagessignatures | ENG-10151 ]]. Added comment that `siwe_message` and `siwe_signature` are social proof related fields. Related: D14255 Test Plan: None Reviewers: kamil Reviewed By: kamil Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D14419
Commit: | 067e692 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add comment about siwe fields being social proof Summary: Address [[ https://linear.app/comm/issue/ENG-10151/add-proto-comments-clarifying-siwe-messagessignatures | ENG-10151 ]]. Added comment that `siwe_message` and `siwe_signature` are social proof related fields. Related: D14255 Test Plan: None Reviewers: kamil Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D14419
Commit: | 38f9faf | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add comment about siwe fields being social proof Summary: Address [[ https://linear.app/comm/issue/ENG-10151/add-proto-comments-clarifying-siwe-messagessignatures | ENG-10151 ]]. Added comment that `siwe_message` and `siwe_signature` are social proof related fields. Related: D14255 Test Plan: None Reviewers: kamil Subscribers:
Commit: | 6977f5d | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | xsanm |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: [[ https://linear.app/comm/issue/ENG-10114/modify-the-proto-so-that-the-user-keys-backup-is-a-part-of-the | ENG-10114 ]], details in its parent task. Added fields related to UserKeys backup to RestoreUser RPC. Depends on D14279 Test Plan: flow, cargo build. Full test plan in D14273 which is closely related to this diff Reviewers: tomek, ashoat, bartek Reviewed By: ashoat Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14280
Commit: | b3c1b52 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: TBD Depends on D14279 Test Plan: TBD Reviewers: kamil, tomek Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14280
Commit: | 6dbb125 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: TBD Depends on D14279 Test Plan: TBD Reviewers: kamil, tomek Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14280
Commit: | 97439d4 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | xsanm |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: TBD Depends on D14279 Test Plan: TBD Reviewers: kamil, tomek Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14280
Commit: | 9a34c32 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: TBD Depends on D14279 Test Plan: TBD Reviewers: kamil, tomek Subscribers: ashoat Differential Revision: https://phab.comm.dev/D14280
Commit: | 161ad79 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[proto] Add UserKeys backup fields to RestoreUserRequest Summary: TBD Depends on D14279 Test Plan: TBD Reviewers: kamil, tomek Subscribers:
Commit: | bfa565f | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add skipPasswordReset field to PrivilegedResetUserPassword Summary: Part of [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login | ENG-9628 ]] As mentioned in [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login#comment-2ef488a6 | this discussion ]], we want a flag to skip password reset while reverting users to V1 flows. Test Plan: CI, flow Reviewers: ashoat, kamil, tomek Reviewed By: ashoat Differential Revision: https://phab.comm.dev/D14198
Commit: | 81a85cd | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add skipPasswordReset field to PrivilegedResetUserPassword Summary: Part of [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login | ENG-9628 ]] As mentioned in [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login#comment-2ef488a6 | this discussion ]], we want a flag to skip password reset while reverting users to V1 flows. Test Plan: CI, flow Reviewers: ashoat, kamil, tomek Differential Revision: https://phab.comm.dev/D14198
Commit: | f815fb5 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add skipPasswordReset field to PrivilegedResetUserPassword Summary: Part of [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login | ENG-9628 ]] As mentioned in [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login#comment-2ef488a6 | this discussion ]], we want a flag to skip password reset while reverting users to V1 flows. Test Plan: CI, flow Reviewers: ashoat, kamil, tomek Differential Revision: https://phab.comm.dev/D14198
Commit: | 0d8d943 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add skipPasswordReset field to PrivilegedResetUserPassword Summary: Part of [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login | ENG-9628 ]] As mentioned in [[ https://linear.app/comm/issue/ENG-9628/plan-for-reverting-individual-users-to-v1-login#comment-2ef488a6 | this discussion ]], we want a flag to skip password reset while reverting users to V1 flows. Test Plan: CI, flow Reviewers: ashoat, kamil, tomek Subscribers:
Commit: | d54f936 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] introduce new privileged rpcs for resetting user passwords Summary: we'll call these rpcs from a keyserver script when a user needs their password reset. will only allow-list ashoat's user ID for the time being, as we do with the privileged delete user rpc Test Plan: tested at end of stack by calling rpcs from keyserver script Reviewers: ashoat Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13759
Commit: | 49bc9ed | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] introduce new privileged rpcs for resetting user passwords Summary: we'll call these rpcs from a keyserver script when a user needs their password reset. will only allow-list ashoat's user ID for the time being, as we do with the privileged delete user rpc Test Plan: tested at end of stack by calling rpcs from keyserver script Reviewers: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13759
Commit: | c1f873f | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] introduce new privileged rpcs for resetting user passwords Summary: we'll call these rpcs from a keyserver script when a user needs their password reset. will only allow-list ashoat's user ID for the time being, as we do with the privileged delete user rpc Test Plan: tested at end of stack by calling rpcs from keyserver script Reviewers: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13759
Commit: | 9133612 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] introduce new privileged rpcs for resetting user passwords Summary: we'll call these rpcs from a keyserver script when a user needs their password reset. will only allow-list ashoat's user ID for the time being, as we do with the privileged delete user rpc Test Plan: tested at end of stack by calling rpcs from keyserver script Reviewers: ashoat Subscribers:
Commit: | acfd285 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] privileged delete users RPC Summary: we need this RPC to delete users who are sending spam on Comm Test Plan: tested at end of stack by calling the RPC Reviewers: ashoat, bartek, will Reviewed By: ashoat, bartek Subscribers: tomek Differential Revision: https://phab.comm.dev/D13629
Commit: | 9908309 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] privileged delete users RPC Summary: we need this RPC to delete users who are sending spam on Comm Test Plan: tested at end of stack by calling the RPC Reviewers: ashoat, bartek, will Subscribers: tomek Differential Revision: https://phab.comm.dev/D13629
Commit: | 58b7606 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[proto] privileged delete users RPC Summary: we need this RPC to delete users who are sending spam on Comm Test Plan: tested at end of stack by calling the RPC Reviewers: ashoat, bartek, will Subscribers:
Commit: | fbe4ab9 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat, varun Reviewed By: ashoat, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | 8ebdc6c | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | e564769 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | 1146dc9 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[tunnelbroker] Add RPC for closing WebSocket sessions Summary: Address [[ https://linear.app/comm/issue/ENG-8217/add-tunnelbroker-rpc-to-close-sessions | ENG-8217 ]]. Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present). The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time. Depends on D13227 Test Plan: Repeated test plan from D13227, now by calling the RPC Reviewers: kamil, ashoat Reviewed By: kamil, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13228
Commit: | db6b2f6 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[tunnelbroker] Add RPC for closing WebSocket sessions Summary: Address [[ https://linear.app/comm/issue/ENG-8217/add-tunnelbroker-rpc-to-close-sessions | ENG-8217 ]]. Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present). The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time. Depends on D13227 Test Plan: Repeated test plan from D13227, now by calling the RPC Reviewers: kamil!, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13228
Commit: | 5eed644 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | d2d2aa1 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | d32e078 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[tunnelbroker] Add RPC for closing WebSocket sessions Summary: Address [[ https://linear.app/comm/issue/ENG-8217/add-tunnelbroker-rpc-to-close-sessions | ENG-8217 ]]. Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present). The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time. Depends on D13227 Test Plan: Repeated test plan from D13227, now by calling the RPC Reviewers: kamil!, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13228
Commit: | 4f41174 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | 3442802 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[tunnelbroker] Add RPC for closing WebSocket sessions Summary: Address [[ https://linear.app/comm/issue/ENG-8217/add-tunnelbroker-rpc-to-close-sessions | ENG-8217 ]]. Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present). The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time. Depends on D13227 Test Plan: Repeated test plan from D13227, now by calling the RPC Reviewers: kamil!, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13228
Commit: | a3671ff | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[tunnelbroker] Add RPC for closing WebSocket sessions Summary: Address [[ https://linear.app/comm/issue/ENG-8217/add-tunnelbroker-rpc-to-close-sessions | ENG-8217 ]]. Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present). The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time. Depends on D13227 Test Plan: Repeated test plan from D13227, now by calling the RPC Reviewers: kamil!, ashoat Subscribers:
Commit: | c811064 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers: tomek Differential Revision: https://phab.comm.dev/D13221
Commit: | 781c6aa | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add RestoreUser RPCs Summary: Address [[ https://linear.app/comm/issue/ENG-8210/add-restore-rpcs-to-proto-and-grpc-web | ENG-8210 ]]. Added `RestorePasswordUser` and `RestoreWalletUser` RPCs. These are described as "a single RPC" in the Whitepaper 5.2. The API is very similiar to `LogInPasswordUser[Start]` / `LogInWalletUser`, with the additional device list payload. Also, we're not doing OPAQUE login here for password users. Test Plan: Flow, identity compiles. Reviewers: ashoat!, varun! Subscribers:
Commit: | ca98cfd | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add reserved usernames to UserIdentitiesResponse Summary: First part of [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities | ENG-8771 ]] - added a new response field as proposed in [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities#comment-f8a85c4a | this comment ]]. This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map. Test Plan: Flow, cargo build. Logic is added in the next diffs Reviewers: ashoat, varun Reviewed By: ashoat, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12922
Commit: | e656543 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add reserved usernames to UserIdentitiesResponse Summary: First part of [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities | ENG-8771 ]] - added a new response field as proposed in [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities#comment-f8a85c4a | this comment ]]. This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map. Test Plan: Flow, cargo build. Logic is added in the next diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12922
Commit: | 9aa8d79 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add reserved usernames to UserIdentitiesResponse Summary: First part of [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities | ENG-8771 ]] - added a new response field as proposed in [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities#comment-f8a85c4a | this comment ]]. This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map. Test Plan: Flow, cargo build. Logic is added in the next diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12922
Commit: | ca142f0 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add reserved usernames to UserIdentitiesResponse Summary: First part of [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities | ENG-8771 ]] - added a new response field as proposed in [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities#comment-f8a85c4a | this comment ]]. This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map. Test Plan: Flow, cargo build. Logic is added in the next diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12922
Commit: | 85ebd13 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add reserved usernames to UserIdentitiesResponse Summary: First part of [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities | ENG-8771 ]] - added a new response field as proposed in [[ https://linear.app/comm/issue/ENG-8771/search-identity-reserved-usernames-in-finduseridentities#comment-f8a85c4a | this comment ]]. This change is backwards compatible, regardless if we release identity first or clients first. The new field will simply default to an empty map. Test Plan: Flow, cargo build. Logic is added in the next diffs Reviewers: ashoat!, varun Subscribers:
Commit: | 7b7beb1 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity][proto] addWallet RPC Summary: https://linear.app/comm/issue/ENG-8306/addwalletstart-rpc do SIWE and add the wallet address to the user's item in the DDB users table if it's successful Test Plan: wallet login works. if nonce is expired, i get back the correct tonic status message Reviewers: bartek!, ashoat! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12575
Commit: | f209eef | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat, varun Reviewed By: ashoat, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12571
Commit: | f6253a5 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12571
Commit: | fb79c6b | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12571
Commit: | 0de42f6 | |
---|---|---|
Author: | xsanm | |
Committer: | xsanm |
[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker Summary: [ENG-8400](https://linear.app/comm/issue/ENG-8400/biggest-risk-tunnelbroker-inform-device-about-invalid-device-token) (see point 5. Logout). This RPC will be used by Identity to inform Tunnelbroker about device logout. Now remove the device token. Creating a follow-up task to delete persisted messages to device ([ENG-8495](https://linear.app/comm/issue/ENG-8495/implement-removing-data-from-tunnelbroker-undelivered-messages-on)). Test Plan: Tested in next diff Reviewers: bartek, marcin, ashoat Reviewed By: bartek, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D12525
Commit: | 4c5273d | |
---|---|---|
Author: | xsanm | |
Committer: | xsanm |
[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker Summary: [ENG-8400](https://linear.app/comm/issue/ENG-8400/biggest-risk-tunnelbroker-inform-device-about-invalid-device-token) (see point 5. Logout). This RPC will be used by Identity to inform Tunnelbroker about device logout. Test Plan: Tested in next diff Reviewers: bartek, marcin, ashoat! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12525
Commit: | ca982c9 | |
---|---|---|
Author: | xsanm | |
Committer: | xsanm |
[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker Summary: [ENG-8400](https://linear.app/comm/issue/ENG-8400/biggest-risk-tunnelbroker-inform-device-about-invalid-device-token) (see point 5. Logout). This RPC will be used by Identity to inform Tunnelbroker about device logout. Test Plan: Tested in next diff Reviewers: bartek, marcin, ashoat! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12525
Commit: | baceff2 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12571
Commit: | d95d74c | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat!, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12571
Commit: | aa26451 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity][proto] addWallet RPC Summary: https://linear.app/comm/issue/ENG-8306/addwalletstart-rpc do SIWE and add the wallet address to the user's item in the DDB users table if it's successful Test Plan: wallet login works. if nonce is expired, i get back the correct tonic status message Reviewers: bartek!, ashoat! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12575
Commit: | 725cc74 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity][proto] addWallet RPC Summary: https://linear.app/comm/issue/ENG-8306/addwalletstart-rpc do SIWE and add the wallet address to the user's item in the DDB users table if it's successful Test Plan: wallet login works. if nonce is expired, i get back the correct tonic status message Reviewers: bartek!, ashoat! Subscribers:
Commit: | 2e2a75f | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add LogOutPrimaryDevice RPC Summary: [[ https://linear.app/comm/issue/ENG-7876/add-logoutprimarydevice-rpc | ENG-7876 ]]. Adding RPC that is going to be called by primary device to log out the primary device and all other user's devices. It is going to invalidate CSAT for all of them. It requires signed device list as an input - primary device logout will result in device list being replaced by a singleton of the primary device being logged out. Test Plan: Identity and flow compiles. RPC implementation will be added in later diffs Reviewers: ashoat!, varun Subscribers:
Commit: | 54a1ca0 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
remove reserved wallet registration RPC Summary: we don't need this. SIWE is enough to prove that a user owns a particular wallet address Depends on D12546 Test Plan: everything builds, git grep'd for any remaining references to this RPC and message type Reviewers: bartek Reviewed By: bartek Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D12547
Commit: | 8ce5ef1 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
remove reserved wallet registration RPC Summary: we don't need this. SIWE is enough to prove that a user owns a particular wallet address Depends on D12546 Test Plan: everything builds, git grep'd for any remaining references to this RPC and message type Reviewers: bartek! Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D12547
Commit: | 1c64711 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
remove reserved wallet registration RPC Summary: we don't need this. SIWE is enough to prove that a user owns a particular wallet address Depends on D12546 Test Plan: everything builds, git grep'd for any remaining references to this RPC and message type Reviewers: bartek! Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D12547
Commit: | 7f4f161 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
remove reserved wallet registration RPC Summary: we don't need this. SIWE is enough to prove that a user owns a particular wallet address Depends on D12546 Test Plan: everything builds, git grep'd for any remaining references to this RPC and message type Reviewers: bartek! Subscribers:
Commit: | 22b8c83 | |
---|---|---|
Author: | xsanm | |
Committer: | xsanm |
[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker Summary: [ENG-8400](https://linear.app/comm/issue/ENG-8400/biggest-risk-tunnelbroker-inform-device-about-invalid-device-token) (see point 5. Logout). This RPC will be used by Identity to inform Tunnelbroker about device logout. Test Plan: Tested in next diff Reviewers: bartek, marcin, ashoat! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12525
Commit: | 80f63ae | |
---|---|---|
Author: | xsanm | |
Committer: | xsanm |
[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker Summary: [ENG-8400](https://linear.app/comm/issue/ENG-8400/biggest-risk-tunnelbroker-inform-device-about-invalid-device-token) (see point 5. Logout). This RPC will be used by Identity to inform Tunnelbroker about device logout. Test Plan: Tested in next diff Reviewers: bartek, marcin, ashoat!
Commit: | 785034f | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | marcinwasowicz |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat, bartek Reviewed By: ashoat, bartek Subscribers: tomek Differential Revision: https://phab.comm.dev/D12465
Commit: | a0954ee | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat, bartek Reviewed By: ashoat, bartek Subscribers: tomek Differential Revision: https://phab.comm.dev/D12465
Commit: | 2daa4a4 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat!, bartek! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12465
Commit: | 97a24a0 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat!, bartek! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12465
Commit: | 6da457b | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat!, bartek! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12465
Commit: | 63882be | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
[identity] update change password RPCs to match whitepaper Summary: per the whitepaper, we want clients to run Password-based Authentication before running Password-based Registration with the new password. Test Plan: tested later in stack by calling the new RPCs from web and native Reviewers: ashoat!, bartek! Subscribers:
Commit: | 2842940 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
Rename new_content_prekeys and new_notif_prekeys Summary: We only upload one of each type of prekey, so these fields should not be plural Depends on D12436 Test Plan: ran flow, checked all invocations of `RefreshUserPrekeys` to make sure client code reflected the field name changes Reviewers: bartek, ashoat Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D12441
Commit: | cdfd93f | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
Rename new_content_prekeys and new_notif_prekeys Summary: We only upload one of each type of prekey, so these fields should not be plural Depends on D12436 Test Plan: ran flow, checked all invocations of `RefreshUserPrekeys` to make sure client code reflected the field name changes Reviewers: bartek, ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D12441
Commit: | 6140f91 | |
---|---|---|
Author: | Varun Dhananjaya | |
Committer: | Varun Dhananjaya |
Rename new_content_prekeys and new_notif_prekeys Summary: We only upload one of each type of prekey, so these fields should not be plural Depends on D12436 Test Plan: ran flow, checked all invocations of `RefreshUserPrekeys` to make sure client code reflected the field name changes Reviewers: bartek, ashoat Subscribers:
Commit: | 42f7d62 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat, marcin, varun Reviewed By: marcin Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | c1a7a60 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat, marcin Reviewed By: marcin Subscribers: ashoat, varun, tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | b19de85 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | 59d3113 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | b9e9f35 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | c7a5ccc | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | 3df3f81 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | c393005 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | 029215d | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | e65d19f | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | marcinwasowicz |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | c015de2 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | 8413e0d | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | 6a9956a | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | 585b3dd | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | b847a62 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12274
Commit: | 20642f7 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[identity][protos] Add RPC to update PlatformDetails Summary: Addresses [[ https://linear.app/comm/issue/ENG-8280/implement-identity-service-endoint-to-update-platformdetails | ENG-8280 ]]. This RPC is going to be called when client has been updated. No inputs or outputs are needed - all required data is sent in gRPC metadata. Depends on D12273 Test Plan: Patched native_rust_library to pass custom code version value, instead of `CODE_VERSION` constant. After each of the following actions, verified DDB for code version changes: - Called other RPCs (important: for already existing devices)- no change - Called `SyncPlatformDetails` RPC - the value was updated Reviewers: ashoat!, marcin, varun Subscribers:
Commit: | 469c38e | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers: tomek Differential Revision: https://phab.comm.dev/D12272
Commit: | 58bb3d8 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add PlatformDetails to PeersDeviceListsResponse Summary: Extended response for device list multi-fetch RPC to include PlatformDetails for each device. Unfortunately, proto doesn't allow for `map<K_outer, map<K_inner, V>>` directly, so needed to introduce intermediate message type. This message could be nested, but grpc-web codegen generated Flow-unfriendly types. Depends on D12271 Test Plan: proto compiles, identity compiles, flow for web Reviewers: ashoat!, marcin! Subscribers:
Commit: | d97f0a2 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add RPC for secondary device logout Summary: Addresses [[ https://linear.app/comm/issue/ENG-7886/add-logoutseccondarydevice-rpc | ENG-7886 ]]. Introduced `LogOutSecondaryDevice` RPC which is going to be called by secondary device when user clicks the logout button. This is part of the "CSAT invalidation flow" described in [[ https://linear.app/comm/issue/ENG-5293/add-support-for-logging-out-of-a-secondary-device | ENG-5293 ]]. In contrast to the existing `LogOutUser` RPC, this one will only clear CSAT and device keys, but won't be modifying the device list. Depends on D12091 Test Plan: CI. Implementation later in the stack Reviewers: ashoat, varun, kamil, will Reviewed By: kamil Subscribers: tomek Differential Revision: https://phab.comm.dev/D12119
Commit: | 73354ae | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add RPC for secondary device logout Summary: Addresses [[ https://linear.app/comm/issue/ENG-7886/add-logoutseccondarydevice-rpc | ENG-7886 ]]. Introduced `LogOutSecondaryDevice` RPC which is going to be called by secondary device when user clicks the logout button. This is part of the "CSAT invalidation flow" described in [[ https://linear.app/comm/issue/ENG-5293/add-support-for-logging-out-of-a-secondary-device | ENG-5293 ]]. In contrast to the existing `LogOutUser` RPC, this one will only clear CSAT and device keys, but won't be modifying the device list. Depends on D12091 Test Plan: CI. Implementation later in the stack Reviewers: ashoat!, varun, kamil, will Subscribers: tomek Differential Revision: https://phab.comm.dev/D12119
Commit: | cdb9ee8 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add username to AuthResponse Summary: Address [[ https://linear.app/comm/issue/ENG-8137/extend-authresponse-to-include-useridentity | ENG-8137 ]]. It turns out to be simple to add username to the AuthResponse on Identity side. On proto/RPC side, this is also backwards compatible from both sides. If the response doesn't contain username field (client has newer version than deployed Identity Service), it will be defaulted to empty string. Test Plan: Tested together with D12134 - verified `AuthResponse` to contain a username in all registration and login RPCs Reviewers: ashoat, varun, will Reviewed By: varun Subscribers: tomek Differential Revision: https://phab.comm.dev/D12127
Commit: | 2067081 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add username to AuthResponse Summary: Address [[ https://linear.app/comm/issue/ENG-8137/extend-authresponse-to-include-useridentity | ENG-8137 ]]. It turns out to be simple to add username to the AuthResponse on Identity side. On proto/RPC side, this is also backwards compatible from both sides. If the response doesn't contain username field (client has newer version than deployed Identity Service), it will be defaulted to empty string. Test Plan: TBD. CI for now Reviewers: ashoat!, varun!, will Subscribers: tomek Differential Revision: https://phab.comm.dev/D12127
Commit: | eacfed1 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add username to AuthResponse Summary: Address [[ https://linear.app/comm/issue/ENG-8137/extend-authresponse-to-include-useridentity | ENG-8137 ]]. It turns out to be simple to add username to the AuthResponse on Identity side. On proto/RPC side, this is also backwards compatible from both sides. If the response doesn't contain username field (client has newer version than deployed Identity Service), it will be defaulted to empty string. Test Plan: TBD. CI for now Reviewers: ashoat!, varun!, will Subscribers: tomek Differential Revision: https://phab.comm.dev/D12127
Commit: | edb0bed | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos][identity] Add username to AuthResponse Summary: Address [[ https://linear.app/comm/issue/ENG-8137/extend-authresponse-to-include-useridentity | ENG-8137 ]]. It turns out to be simple to add username to the AuthResponse on Identity side. On proto/RPC side, this is also backwards compatible from both sides. If the response doesn't contain username field (client has newer version than deployed Identity Service), it will be defaulted to empty string. Test Plan: TBD. CI for now Reviewers: ashoat!, varun!, will Subscribers:
Commit: | 1636c75 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add RPC for secondary device logout Summary: Addresses [[ https://linear.app/comm/issue/ENG-7886/add-logoutseccondarydevice-rpc | ENG-7886 ]]. Introduced `LogOutSecondaryDevice` RPC which is going to be called by secondary device when user clicks the logout button. This is part of the "CSAT invalidation flow" described in [[ https://linear.app/comm/issue/ENG-5293/add-support-for-logging-out-of-a-secondary-device | ENG-5293 ]]. In contrast to the existing `LogOutUser` RPC, this one will only clear CSAT and device keys, but won't be modifying the device list. Depends on D12091 Test Plan: CI. Implementation later in the stack Reviewers: ashoat!, varun, kamil, will Subscribers: tomek Differential Revision: https://phab.comm.dev/D12119
Commit: | db6dbd9 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add RPC for secondary device logout Summary: Addresses [[ https://linear.app/comm/issue/ENG-7886/add-logoutseccondarydevice-rpc | ENG-7886 ]]. Introduced `LogOutSecondaryDevice` RPC which is going to be called by secondary device when user clicks the logout button. This is part of the "CSAT invalidation flow" described in [[ https://linear.app/comm/issue/ENG-5293/add-support-for-logging-out-of-a-secondary-device | ENG-5293 ]]. In contrast to the existing `LogOutUser` RPC, this one will only clear CSAT and device keys, but won't be modifying the device list. Depends on D12091 Test Plan: CI. Implementation later in the stack Reviewers: ashoat!, varun, kamil, will Subscribers:
Commit: | 9ad37a9 | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add initial_device_list field Summary: Addresses: - [[ https://linear.app/comm/issue/ENG-7533/add-initial-device-list-field-to-registeruser-rpcs-requests | ENG-7533 ]] - [[ https://linear.app/comm/issue/ENG-7868/set-the-initial-device-list-to-empty-string-on-clients | ENG-7868 ]] Added the `initial_device_list` to registration requests' proto messages. We need it in the following rpcs: - RegisterPasswordUserStart - RegisterReservedPasswordUser - RegisterWalletUser - RegisterReservedWalletUser The `WalletAuthRequest` is also used in LogInWalletUser so we always put empty string there Test Plan: Made sure the change is backwards compatible 1. Compiled native without this changes 2. Applied this change and compiled Identity Service. Added server-side log to print the `initial_device_list.is_empty()` value. 3. Without recompiling, ran the registration on native. 4. Made sure the value is an empty string 5. Compiled native with changes from this diff, ran registration again and verified it's empty string Reviewers: ashoat, will Reviewed By: ashoat, will Subscribers: tomek, varun Differential Revision: https://phab.comm.dev/D12017
Commit: | 395d3ea | |
---|---|---|
Author: | Bartłomiej Klocek | |
Committer: | Bartłomiej Klocek |
[protos] Add initial_device_list field Summary: Addresses: - [[ https://linear.app/comm/issue/ENG-7533/add-initial-device-list-field-to-registeruser-rpcs-requests | ENG-7533 ]] - [[ https://linear.app/comm/issue/ENG-7868/set-the-initial-device-list-to-empty-string-on-clients | ENG-7868 ]] Added the `initial_device_list` to registration requests' proto messages. We need it in the following rpcs: - RegisterPasswordUserStart - RegisterReservedPasswordUser - RegisterWalletUser - RegisterReservedWalletUser The `WalletAuthRequest` is also used in LogInWalletUser so we always put empty string there Test Plan: Made sure the change is backwards compatible 1. Compiled native without this changes 2. Applied this change and compiled Identity Service. Added server-side log to print the `initial_device_list.is_empty()` value. 3. Without recompiling, ran the registration on native. 4. Made sure the value is an empty string 5. Compiled native with changes from this diff, repeated steps 2 and 4 Reviewers: ashoat!, will Subscribers: tomek, varun Differential Revision: https://phab.comm.dev/D12017