These 8 commits are when the Protocol Buffers files have changed:
| Commit: | a52b1eb | |
|---|---|---|
| Author: | Burke Libbey | |
Deprecate AppBundleId and AndroidPackage
The documentation is generated from this commit.
| Commit: | cdbbb54 | |
|---|---|---|
| Author: | Burke Libbey | |
Update protocol docs for new clarification from Apple
| Commit: | ac51c57 | |
|---|---|---|
| Author: | Max Neuvians | |
Handles zero keys inside upload payload
| Commit: | de72104 | |
|---|---|---|
| Author: | Burke Libbey | |
use 1.2.840.10045.4.3.2
| Commit: | 19492d0 | |
|---|---|---|
| Author: | Burke Libbey | |
| Committer: | Burke Libbey | |
Temporarily ban repeated failed authorizations to /claim-key I had previously intended for this to be done externally with a WAF or something, but I'm now starting to think that this is such a critical protection - and AWS WAF is more limited than I realized - that we should do it internally to simplify deployment. I considered adding an extra proxy component to sit in front of this one, in order to keep IP addresses (PII) out of the same database as the diagnosis keys, but: * IP addresses are deleted before adding diagnosis keys to the database, so the database should never concurrently contain both PII and any keys relating to that I'd P. * IP addresses are only stored in the first place after failed key claim attempts, and even then, only for the ban duration (1 hour currently) if no successful authentication occurs (otherwise deleted sooner). This ultimately has to get stored somewhere in order to implement this protection and it doesn't appear to me that there's an additional risk in having it live here; quite the opposite, the simplicity of having only one component makes me more confident that we have implemented this correctly. This commit is currently in a "well it compiles; maybe it works" state. Comprehensive testing required before merge.
| Commit: | 46550ab | |
|---|---|---|
| Author: | Burke Libbey | |
Rename everything; unify around snake_case protobuf fields
| Commit: | 610a58a | |
|---|---|---|
| Author: | Burke Libbey | |
Import new protobuf definitions and rebuild
| Commit: | ca905da | |
|---|---|---|
| Author: | Burke Libbey | |
| Committer: | Burke Libbey | |
Initial open-source release Authors alphabetically: Co-authored-by: Aaron Olson <934893+honkfestival@users.noreply.github.com> Co-authored-by: Burke Libbey <burke@libbey.me> Co-authored-by: Cat Jones <31020910+catherinejones@users.noreply.github.com> Co-authored-by: Dominic McPhee <dominic.mcphee@shopify.com> Co-authored-by: Dylan Thacker-Smith <Dylan.Smith@shopify.com> Co-authored-by: Felix Glaser <leex@klautcomputing.de> Co-authored-by: Jack McCracken <jack.mccracken@shopify.com> Co-authored-by: Jonathan Pulsifer <jonathan.pulsifer@shopify.com> Co-authored-by: Nataly Sheinin <nataly.sheinin@shopify.com> Co-authored-by: Riley Shott <riley.shott@shopify.com> Co-authored-by: Shane Lawrence <shane@lawrence.dev> Co-authored-by: Tobias Lütke <tobi@shopify.com>