Proto commits in ampproject/amphtml

These commits are when the Protocol Buffers files have changed: (only the last 100 relevant commits are shown)

2023-11-09

Fix typos in validator/ (#39605) * Fix typos in validator/ * Revert typo fixes * Revert validator/testdata/

The documentation is generated from this commit.

2022-06-29

Sync from Google: Renames required field name as this may be reserved keyword in some languages (#38318) * cl/455631272 Renames requires field name as this may be reserved keyword in some languages. * Manually add two files that were not picked up by auto-sync tooling. * Update formatting. Co-authored-by: Amaltas Bohra <amaltas@google.com>

2021-08-24

cl/392528201 Internal cleanup. (#35791) Co-authored-by: Michael Rybak <michaelrybak@google.com>

2021-08-20

ExtensionSpec with bento_supported_version (#35757) * ExtensionSpec with bento_supported_version * update proto

Validator rollup 20210819 (#35748) * cl/391813546 Remove notice from extension validator test files * cl/391814624 Remove notice from validator feature tests * remove diff from README.md * empty commit * empty commit

2021-08-19

Sync for validator cpp engine and cpp htmlparser (#35737) * Remove usage of glog in favor of simpler logging mechanism. Also a few other minor refactoring cleanups. PiperOrigin-RevId: 387395387 * Remove usage of glog in favor of simpler logging mechanism. Also a few other minor refactoring cleanups. PiperOrigin-RevId: 387405195 * Remove notice from c++ validator PiperOrigin-RevId: 391628308 * Remove notice from htmlparser PiperOrigin-RevId: 391630746 Co-authored-by: Greg Grothaus <greggrothaus@google.com>

2021-07-21

Validator Rollup. (#35326) Co-authored-by: honeybadgerdontcare <sedano@google.com>

2021-06-18

Update outdated comments referencing moved file (#34929)

2021-06-15

Validator Rollup (#34769) * cl/377126790 Error message for invalid AMP domains. * cl/377164470 Replace goog.array API calls with native API equivalents. * cl/377366082 amp-cache-url does not require usage * cl/377966735 Two-way sync for PR #34698. No-op, or fixes merge conflicts, if any.

2021-05-18

cl/373617376 Make the process of auto-generating validator.pb.go compatible with protoc v3.16.0. (#34428) Co-authored-by: Michael Rybak <michaelrybak@google.com>

2021-05-17

📖 Move AMP documentation from `spec/` to `docs/spec/` (#34160)

2021-04-08

📖 Update links that were pointing to the `master` branch of `amphtml` and associated repos (#33570)

2021-04-06

Validator rollup (#33655) * cl/366092812 Revision bump for #33328 * cl/366102803 Revision bump for #33475 * cl/366894452 Implementation of multiple tagspecs for a single extension, each with a unique set of version identifiers. Co-authored-by: Greg Grothaus <greggrothaus@google.com>

2021-02-15

Validator rollup (#32662) * cl/357034944 Add warning message for AMP Email documents missing data-css-strict * cl/357287415 alaphbetize layouts * cl/357482508 Revision bump for #32646 Co-authored-by: honeybadgerdontcare <sedano@google.com>

2021-02-09

Validator rollup (#32548) * cl/355665213 Revision bump for #32371 * cl/355686523 Revision bump for #32315 * cl/355888443 Allow any declaration for inline style except in AMP4EMAIL with data-css-strict * cl/355944766 Allow module/nomodule in validator Co-authored-by: honeybadgerdontcare <sedano@google.com>

2020-12-13

use allowlist rather than white list (#31575) s/white(.?!list(ed)?)/allow\1/gi

2020-12-04

Validator rollup 523@1126 (#31400) * cl/343164010 Revision bump for #31241 * cl/343904483 Implements gated module/nomodule validation with test cases * cl/345313752 Revision bump for #31271 * Update validator-amp-accordion.protoascii * Add htmlparser-interface.js in allowlist * Fix invalid merge diff resolution Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>

2020-08-25

Validator rollup 514@1095 (#29960) * cl/327474500 Validator: Fix SSR'd amp-img as valid descendant of amp-story elements * cl/327740937 Add error message for inline scripts exceeding max_bytes * cl/328343829 Allow positive integers in amp-bodymovin-animation[loop] Co-authored-by: Justin Ridgewell <jridgewell@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>

2020-08-18

Validator rollup (#29877) * cl/326538700 Remove HtmlFormat::ACTIONS from validator.proto * cl/326560762 Revision bump for #29659 * cl/326568890 Revision bump for #29827 * cl/326574333 github commit msg missing or malformed * cl/327059591 Validator: Add SSR'd amp-img as valid descendant of amp-story elements * cl/327075248 Revert CSS declaration list change for non-strict email spec * cl/327119906 Revision bump for #29732 Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Justin Ridgewell <jridgewell@google.com>

2020-08-13

Validator rollup (#29830) * cl/324926702 Add value_regex support for css declarations. * cl/325128764 Fix css "bug" where declaration::FirstIdent doesn't return numerical identifiers. * cl/325141241 Fix AMP4Email CSS spec by ensuring only properties that should be allowed in emails are allowlisted. * cl/325253809 Improve `!important` CSS marker error message * cl/325256844 Revision bump for #29643 * cl/325359140 Validator: Add support for link imagesrcset and imagesizes * cl/325491434 Replace INVALID_DOCTYPE_HTML with a new message. * cl/325899515 Ban max-entries for AMP for Email * cl/326083373 Revert removal of requires_usage and deprecated_allow_duplicates for email * cl/326527018 Revision bump for #29766 * cl/326533269 Revision bump for #29748 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Justin Ridgewell <jridgewell@google.com>

2020-08-11

Move validator/htmlparser to validator/cpp/htmlparser (#29774)

2020-08-05

Validator rollup (#29698) * cl/323700659 Revision bump for #29329 * cl/323797874 Revision bump for #29542 * cl/323858009 Revision bump for #29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for #29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>

2020-06-23

Validator rollup (#29000) * cl/317352158 Add support for allowlists of pseudo-elements and pseudo-classes, for Amp email. * cl/317432087 n/a * cl/317442154 github commit msg missing or malformed * cl/317589483 github commit msg missing or malformed * cl/317708661 Create a new CssSpec for amp4email data-css-strict. * cl/317787729 Revision bump for #28944 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com>

2020-06-15

Validator rollup (#28875) * cl/316183673 Break spec_name into two purposes: a unique id (still named spec_name) and a descriptive error message string (now named descriptive_name). * cl/316158221 Fix amp.dev documentation URLs so as to avoid one redirect.

2020-06-12

🚮 Delete all Java validator code from `amphtml` (#28854)

2020-06-10

♻️ Conformance check allowlist (#28778) * Disallow older terms for allowlist

2020-06-09

Validator rollup (#28770)

2020-06-08

Validator rollup (#28749)

2020-06-04

Publish C++ CSS parser (#28687) * No description. PiperOrigin-RevId: 314552552 * Remove internal comments. Co-authored-by: Googler <noreply@google.com>

2020-05-19

🐛 Catch up java validator to Doc Css logic (#28313)

2020-04-22

🐛 Bug fix on java validator for failed test due to $DEFAULT a… (#27842) * remove at rule logic and associated test. Update tagchowder to newer version * puppycrawl update * update checkstyle version for puppycrawl * Update Canonicalizer.java * Update ampvalidator_checkstyle.xml * temporarily enable debug logging * Update validator.proto * remove block type references due to proto changes * some echos, change where ValidatorProtos is copied from * Update WORKSPACE change tagchowder * Update BUILD * Update build.sh * Update build.sh * Update CdataMatcherTest.java * Update CssParsingConfigTest.java

2020-04-21

Validator rollup (#27909) * cl/306910018 Revision bump for #27763 * cl/306937287 Revision bump for #27787 * cl/307315739 Implement a DocCssSpec rule. * cl/307411573 Add `clip-path` CSS property, in AMP only. * cl/307500906 Reformat Javascript Files. * cl/307637783 Support disabling CSS vendor prefixes in AMP Email. Co-authored-by: Greg Grothaus <greggrothaus@google.com>

2020-04-16

Validator rollup (#27784) * cl/305561778 Revision bump for #27624 * cl/305733898 CSS validation changes. * cl/306335254 Revision bump for #27709 * cl/306343181 Fix javascript validator symbol export. * cl/306685743 Revision bump for #27768 Co-authored-by: Greg Grothaus <greggrothaus@google.com>

2020-03-25

Validator Roll Up (#27412) * cl/302030563 Revision bump for #27280 * cl/302033641 Remove trailing whitespace from protoascii * cl/302035592 Revision bump for #27159 * cl/302061262 github commit msg missing or malformed * revert * revert * revert * revert * revert * trying to kickstart travis Co-authored-by: Greg Grothaus <greggrothaus@google.com>

2020-03-09

🐛 Bug fix (#27096) * align to validator js business logic in master * Executing 'mvn clean' should remove validator-all.protoascii and ValidatorProtos.java. Co-authored-by: nhant01 <nhan.thuan.nguyen@verizonmedia.com>

2020-02-08

🖍 Increase CSS byte limit from 50000 bytes to 75000 bytes (#26475) * Increase CSS byte limit from 50000 bytes to 75000 bytes * Remove 75k change for amp email, replace mentions of 50k limit for websites

2019-12-18

Validator 20191218 (#26084) * cl/286094937 Allow validator to support LTS release channel for runtime and extensions * cl/286215939 Revision bump for #24119 * exempt validator engine

2019-12-11

Validator rollup (#25973) * cl/283618549 Revision bump for #25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for #25197 * cl/284115876 Revision bump for #25870 * cl/284258503 Revision bump for #25889 * cl/284856390 Revision bump for #25946

2019-12-04

✨Java Validator for AMP. (#25579) * java validator init commit * Modify the script to read the proto and ascii files without pulling via git. * rename creds, copyright references * Update README.md * Unit tests * gitignore modified to account for bazel build file, per rsimha * Unit tests * css tests started * .md changes * Unit tests * fix docs with gulp this time * changelog fix * fix broken links, remove code of conduct * Unit tests * more unit tests * more test cases * more test code * rename some @ in javadocs * fix BUILD file for test dependencies * adding proto with java_package option * Fixing import to use dev.amp.validator.ValidatorProtos.

2019-11-21

Validator Rollup (s/GRANDFATHERED/EXEMPTED/) (#25704) * cl/279803659 s/GRANDFATHERED/EXEMPTED/ * Fix commit.

2019-10-23

Validator roll up (#25224) * cl/275942712 Fix validator issue with error'ing tags satisfying unique requirements. * cl/276319310 Restore a stub of amp.validator.categorizeError in javascript.

2019-10-18

Validator rollup (#25134) * cl/275100411 Revision bump for #24773 * cl/275345662 Revision bump for #24949 * cl/275491856 Remove ErrorCategories in the AMP Validator. * Small integration updates to files not tracked by validator rollups to match the changes in the ErrorCategories commit.

2019-09-30

amp-script: Make inline scripts valid, add max-age (#24572) * Make inline scripts valid, add max-age. * Add ValueSet.AMP_SCRIPT_IDS. * Remove 'script is invalid' warning. * Add language on choosing a value for max-age.

2019-08-28

Validator rollup 399@952 (#24267) * cl/264646527 Add support for requiring that values of one attr spec are references to values from another. * cl/265916422 Revision bump for #23851 * Add validator-amp-megaphone.protoascii which wrongly got deleted in previous commit. * Remove diff markers introduced in previous commit.

2019-08-21

Validator rollup (#24106) * cl/263666436 Introduce `<style amp-custom-length-check>` * cl/263843720 Mark `name` attribute of <a> deprecated for AMP for Email * cl/263909610 Revision bump for #23045 * cl/264265855 Revision bump for #24016 * cl/264409259 Revision bump for #21686

2019-08-08

Validator Rollup (#23802) * cl/261776511 Add ValidationError::DEV_MODE_ONLY error code. * cl/261804799 Improve amp-date-picker and amp-carousel validator errors. * cl/261931393 Revision bump for #23598 * cl/262032455 Allow additional CSS features. * cl/262149003 Allow double-spaces in <a rel> and <link rel>. * cl/262178521 Revision bump for #23691 * cl/262193876 Revision bump for #23658 * cl/262223028 Revision bump for #23752 * cl/262230380 Revision bump for #23727 * Fix merge duplication mistakes.

2019-06-26

Validator rollup (#23003) * cl/254131159 Add ValidationError::DOCUMENT_SIZE_LIMIT_EXCEEDED * cl/254201103 Revision bump for #22874 * cl/254247424 Revision bump for #22755 * cl/254267196 Revision bump for #21246 * cl/254407972 Revision bump for #22858

2019-06-10

amp-list-load-more validator rules change (#22702) * amp-list-load-more validator changes * fixes * add experimental format to button[load-more-clickable] rule to match that of amp-list-load-more rule * address comment

2019-05-07

Validator rollup (#22188) * cl/245514706 Revision bump for #22028 * cl/246597903 Link to amp.dev instead of ampproject.org for validation messages. * cl/246602177 More links to amp.dev instead of ampproject.org for validation messages. * cl/246875479 github commit msg missing or malformed * cl/247050210 Revision bump for #21905 * cl/247068714 Revision bump for #22094 * Fix .out file. * More merge fixes.

2019-04-30

✨Allow amp-mraid to pass validation in amp4ads. (#21628) * allow amp-mraid to pass validation in amp4ads We should allow amp-mraid in ads, and only in ads, so they can use the MRAID API to determine visiblity, open links, and expand/collapse. Because amp-mraid loads mraid.js from a relative URL, start injecting <base href="//invalid.invalid"> to make sure that in a web context we can't be tricked into executing arbitrary JS. Since only a the first <base href=...> has any effect, modify the spec to disallow <base href=...> in ads. The only allowable value was previously href="/" so this isn't losing much. We do still want to allow <base> in ads because <base target=...> makes sense here. Because amp-mraid is the first host script validation knows about, now in addition to custom-element=foo and custom-template=foo there's host-script=foo. Since there are now three values I replaced the boolean is_custom_template with a new extension_type enum. * host-script -> host-service * revert changes to handling of <base href=> * remove duplicate head extraction * generate validator.pb.go * responding to reviewer comments * remove dead link to docs. I do need to write docs though * use this.win.document * remove 'unsupported' as a fallback-on value, since this isn't actually used * mark amp-mraid as experimental * undo changes to amp-mraid.js that were superceded by other PRs * fallback-on was replaced by no-fallback * direct people to wg-ads * add copyright comments to tests * regold validator tests * comment mark amp-mraid as valid in tests

2019-03-07

Validator rollup (#21305) * cl/235984006 Revision bump for #21124 * cl/236141405 Validating ssr class values and attributes for transformed AMP * cl/236207670 Validating SSR layout should use the SSR CalculateLayout * cl/236240396 Revision bump for #20967 * cl/236242005 Revision bump for #20992 * cl/236357124 Allow `meta name=amp-recaptcha-input` * cl/236374806 Allow `meta name=amp-list-load-more` * cl/236486003 Limit depth of recursion in CSS parsing. * cl/236922121 n/a * cl/236944297 allow i-amphtml-sizer for transformed amp-story * eslint fixes

2019-02-12

Validator Roll-up (#20803) * cl/232942564 Move dispatch key generally disallowed tag out a level. * cl/232944663 Filter TagSpecDispatch.AllTagSpecs earlier to identify if a tag is disallowed. * cl/232948357 Validate some server side rendering transformations * cl/232978302 Add an AncestorMarker rule type which can be used for changing validation state in entire subtrees of a document. * cl/233080174 Revision bump for #20673 * cl/233478240 Transformed AMP does not allow `nonce` attributes. * cl/233536212 Revision bump for #20760 * cl/233615219 If an AttrSpec isn't used for an identifier, move to next AttrSpec * cl/233618641 Allow i-amphtml-layout on all elements for Transformed AMP * cl/233632873 Remove console.log debug statements * cl/233638860 Change indentation for eslint * cl/233648257 Address eslint feedback for validator.js * eslint

2019-02-05

Validator rollup (#20695) * cl/231693942 Revision bump for #20544 * cl/231839357 MatchingDispatchKey returns all TagSpecs that match. * cl/232015594 Revision bump for #20427 * cl/232308889 Validate transformed AMP via type identifier. * cl/232353446 Update tests to reflect ordering of reorder head transformer * cl/232354800 Revision bump for #20547 * cl/232395416 Do not count non-data URLs in style amp-custom for transformed AMP * Fix lint errors.

2019-01-30

Validator rollup (#20597) * cl/230559764 Small validator refactoring - move the amp-custom byte size adjustment down into the validator Match call. * cl/230603165 add amp-payment-google-inline-async rules and tests * cl/230963421 Provide a validator option to subtract the length of URLs from the CSS cdata strings, when counting against validation lengths. * cl/231000057 Make valid tests valid for amp-payment-google-inline-async * cl/231319523 github commit msg missing or malformed * cl/231332520 Revision bump for #20567 * cl/231332548 Revision bump for #20554 * cl/231613739 Fix lint issues for validator j/s files

2019-01-22

Validator Rollup (#20464) * cl/230354095 Introduce explicit_attrs_only on `<!doctype>` TagSpec. * cl/230388483 n/a

2019-01-16

Validator rollup (#20360) * cl/229240741 Allow target attribute on form[method=POST] for ACTIONS * cl/229285760 Revision bump for #20094 * cl/229285815 Revision bump for #20322 * cl/229408305 Validate "transformer" type identifier value. * cl/229425442 Revision bump for #20330 * cl/229435530 Include version of transformers used in ValidationResult

2019-01-11

Validator roll-up (#20274) - cl/228469373 Use reserved instead of extensions - cl/228597059 Revision bump for #20199 - cl/228775442 Revision bump for #19540 - cl/228789212 Add "actions" as a type identifier and related rules. - cl/228801852 boilerplate no longer has alternative and does not need …

2018-12-04

Validator rollup (#19608) * cl/222868481 Introduce a validator Tag.NamedId field which uniquely identifies a TagSpec without modifying the string used in error reporting for this Tag. * cl/222913664 Revision bump for #19461 * cl/223263100 Revision bump for #19437 * cl/223554996 Sort the list of mandatory attribute ids. * cl/223556066 Revision bump for #19504 * cl/223919116 Fix eslint errors caused by CL 223554996.

2018-10-17

Validator rollup (#18779) * cl/216403657 Add comment to validator.proto re: re * cl/216575865 Validate HTML tag in engine instead o * cl/216616005 Revision bump for #18633 * cl/216926472 Revision bump for #18703 * cl/217200459 Revision bump for #18707 * cl/217335145 Add new validator rules for validatin * Fix lint errors. * Fix bad merge.

2018-08-06

Validator Rollup (#17313) - Emits a warning if JSON cannot be parsed #15888 - Add `amp-pan-zoom` to experimental format #17150 - Clarify `INLINE_STYLE_TOO_LONG` error message. - Enable the `amp-date-picker` `minimum-nights` attribute #17201, #17220 - `amp-list`: Require `reset-on-refresh="always"` for local data #17221 - `amp-3d-glt`: add attribute `clearColor` #17085

2018-07-23

Validator rollup (#17032) * cl/205425252 Make validator aware of unprintable w * cl/205425598 Revision bump for #16954 * cl/205460553 Add 'mandatory_anyof' to AttrSpec * cl/205467005 Revision bump for #16957 * cl/205467260 Add validator test for amp-install-se * cl/205467299 Add validator test for amp-geo. * cl/205469572 Introduce a special case validator error for missing layout attributes on tags that support responsive attributes (ie: width/height). Also add wistia-player files that were missed in a previous sync * cl/205698237 Revision bump for PR #16972 and #1697 * cl/205710585 Revision bump for #16881 * cl/205738621 Revision bump for #17015 * lint fix

2018-07-20

Validator rollup (#16972) * cl/205296221 Add validator test for amp-anim. * cl/205299294 Minor cleanup to recent test addition * cl/205299388 Add validator test for amp-yotpo. * cl/205300941 Rename ExtensionSpec.allowed_versions * cl/205304241 Add validator test for amp-dynamic-cs * Fix lint errors. * More lint fix * Fix test after #16954

2018-07-19

Validator rollup (#16937) * cl/205110971 Convert value_regex/value_regex_casei * cl/205124475 Rename allowed_protocol to protocol. * cl/205178052 Rename DescendantTagList.allowed_tags * cl/205267495 Add test to prevent [style] attribute * cl/205269927 Rename CssSpec.allowed_declarations t * cl/205274609 Revision bump for #16624 * cl/205289326 Revision bump for #16899 * Remove duplicated merge and fix lint errors.

2018-07-18

Validator rollup (#16863)

2018-07-17

Validator rollup (#16817) * cl/204828263 Reword first-person error messages. * cl/204831300 Revision bump for #16771 * cl/204921777 RulesShouldMakeSense prevents user-au * cl/204928194 Add validator test for amp-lightbox. * cl/204931642 Add validator test for amp-image-ligh * cl/204941723 AttrSpec.value and value_casei suppor * Fix linter errors. * Fix more lint errors. * Fix more lint errors.

2018-07-10

Validator Rollup (#16636) * cl/203188698 Revision bump for #16164 * cl/203189899 Test file revision * cl/203560280 Remove deprecated error format CSS_SY * Invert the merge tool dupe. * Removing validator-amp-facebook.out changes.

2018-07-02

Validator rollup (#16514) * cl/202567664 Change CssDeclaration value_casei fro * cl/202660845 Allow style attribute on any tag with

2018-06-28

Validator rollup (#16443) * cl/202000027 Revision bump for #15924 * cl/202002642 Remove disallowed domain * cl/202035261 Revision bump for #16320 * cl/202161179 Adds parsing of inline style and abil * cl/202176825 Expand css declarations for SVG inlin * cl/202200289 Revision bump for #16371 * cl/202220677 Strip vendor prefix for inline style * cl/202221876 Add EXPERIMENTAL back for tag input * cl/202248785 TagSpecs must have at least one html_ * make linter happy * comment reserved in proto * linter spacing * foobar

2018-05-22

Validator rollup (#15470) - Revision bump for #14782 - Linter tweaks for #15444 - Test allowed_protocol:http and !allow_relative:false - Allow relative URLs for amp-story attributes - Restrict CSS to 1000 bytes per inline style

2018-05-16

Validator rollup (#15376) * Attributes must be alphabetical by name * Error message for inline style being too long. * Revision bump for #15322

Validator rollup (#15331) * Fix trailing newline. * Prevent templates in amp-list. * Add new error message for inline style. * Small fixes to error categorization. * Relax some CSS animation/transition constraints * Revision bump for #15288 * Implement CSS size limitation across style amp-custom and inline styles. * A few type cleanups.

2018-03-22

Validator Roll Up (#14202) * Allow meta http-equiv=x-dns-prefetch-control * Introduce excludes tagspec feature * Revision bump for #13782 * Revision bump for #14040 * Revision bump for #14157,#14127

2018-02-15

Validator Updates (#13475) * Revision bump for #13261 - Add support for `<amp-facebook-page>` * Add media query parsing class to CSS parser. This isn't wired up to the validator currently, but will be in a later CL. * Use the recommended closure dependency management for JavaScript libraries. * Add AMP4EMAIL rules. * Remove stray console.log statments. * Small tweaks to #13406 * Revision bump for #13381

2018-02-07

Validator Rollup (#13338) * Revision bump for #13036 * Revision bump for #13073 * Add DEDUPE_ON_MINIFY flags to license tags so that release process can reduce the number of identical duplicate licenses in the minified validator. * Add requires_extension to AttrSpec. * JSDoc updates. * Generated validator javascript improvements. * Add comment to ValidationError hinting at how to render. * Revision bump for #12955 * Add new error types for future CSS validation. * Revision bump for #12798 * Fix a typo. * Allow animation-timing-function for keyframes * Fix typo

2018-01-22

Sync GitHub 20180122 (#12956) * Refactor. Stop tracking the number of child tags a tag has in 2 places. * Revision bump for #12758 * Move the html format enum into its own message for less awkward reuse * Add new layout INTRINSIC. * Add an error code for invalid UTF8; typically UTF8 would get coerced prior to validation, but this code is useful for internal purposes, e.g. a check within a larger system that has an internal API boundary. Users should not see this error code. * Disallow template on children of submit-error. * Revision bump for #12600 * Prefer sets of errors based on specificity over volume. * It's now HtmlFormat.Code, updated from TagSpec.HtmlFormat. * Revision bump for #12832 * Revision bump for #12904

2018-01-08

Validator rollup (#12704) * Validator Refactor: Add the best matching ParsedTagSpecs to the tag stack. This paves the way for us the ParsedTagSpec data for matching children. * Revision bump for #12664 * Disallow template tags on children of `<div submit-success template=...>` tags. * Revision bump for #12617

2017-12-20

Validator Rollup (#12544) * Revision bump for #11953 * Refactor validateTagAgainstSpec * Further refactor validateTagAgainstSpec by extracting methods for additional validation steps which can add errors. * Refactor. Extract a function from validateTagAgainstSpec named updateStateFromTagSpec. * Refactor, merge UpdateStateFromTagSpec and UpdateGlobalSpecs. * Revision bump for #12095 * Refactor. Move updateContextFromTagSpec into Context class. * Refactor. Move code from Context::UpdateFromMatchingTagSpec into smaller methods and in some cases even closer to the relevant context objects (ExtensionsContext and TagStack) * Revision bump for #12285 * Revision bump for #12452 * Refactor. Pull the 'update' part of validate-then-update further up the call stack. * Revision bump for #12457 * Revision bump for #12462 * Refactor. Clean up recording of matching reference points. Push the logic for it into the tagspec methods. * Revision bump for #12461 * Refactor. Use ValidationResult::PASS to indicate a tagspec is passing, rather than unknown, which is harder to reason about. * Revision bump for #12196 * Make amp4ads boilerplate mandatory. * Refactor. Split up the MatchChildTag method into a const validation method and a state mutation method. Push those into the relevant parts of the code. * Revision bump for #12471 * Fix comments. * Build in native support for vendor-prefixes in CSS rules. * Revision bump for #12515 * Add new layout FLUID to validator. * Refactor. Check for reference point collisions without involving the tag stack. * Add missing test file.

2017-12-05

Validator Rollup (#12310) * The presence of `<amp-story standalone>` will now add a requirement for the presence of an `<amp-story-page>`. * Create an allowed declarations error message for longer lists of allowed elements, which does not include the entire list. * Refactor some of the validator Context method calls to remove a level of indirection. * Minor refactor. * Minor refactor. * Very simple refactor, move ExitTag right below to EnterTag calls. * Refactoring. Add a '$ROOT' node to the validator tag stack. This removes a lot of boilerplate code for looking at parent nodes and checking to see if the current node has a parent or not. Now the default values are all built into the '$ROOT' node, and we only pop off of '$ROOT' at the end of the document. * Move reference point matcher end-tag logic into the TagStack's PopFromStack() function. * Move cdatamatcher onto the tag stack. * Use addError/addWarning instead of littering code with severity enums. * Split a method off that chooses between different ValidationResults for the same TagSpec, move it to the ParsedRules class, which has the relevant data. * Refactor. Stop passing around rules to methods that already have a context and can access rules that way.

2017-11-14

Validator Rollup (#12055) * Remove warnings for non-usage of grandfathered extensions. Retain errors for new extensions. * Revision bump for #12015

2017-11-08

Validator rollup (#11990) Behavior changes - Strip duplicate attributes by case-insensitive name. - Keyframes validation URL - allow "fr" attribute for radialGradient SVG tag - Constrain allowed data- attribute characters to only the ones actually used in practice - Whitelist additional attributes on amp-story-grid-layer direct children #11851 - Only support http and https URLs for the 'cite' attribute.

2017-10-11

Validator rollup (#11638) * update AMP Story rules * Allow viewport-fit meta viewport content property. * update style[amp-keyframes] rules * Update to CSS SYNTAX message. * Fix amp keyframes.

2017-09-25

Validator rollup (#11410) * Provide a more descriptive error message for our most common AMP error. * Revision bump, amp-list attributes * Revision bump, amp-sidebar * new validator rule where a tag can specify that it must be the last child * AMP Story Validator Rules * AMP Story Validator Rules * Revision bump for #11299 * AMP Story Validator Rules * Revision bump for #11333 * AMP Story Validator Rules * Move STAMP test files to amp-story extension. * AMP Story Validator Rules Fix

2017-09-05

Validator Rollup (#11177) * Revision bump, vector-effect attribute for SVGs * Suppress attribute errors for a tag if the tag's parent or ancestors are wrong. When the parent or ancestors are wrong, the attribute errors are usually just noise. * amp-auto-ads must have body as parent * Cleanup. Remove DEV/PROD_MODE. * Remove SYTLESHEET_TOO_LONG_OLD_VARIANT error code.

2017-08-24

Validator Rollup (#11092) * Revision bump, amp-position-observer * Revision bump, amp-audio/amp-video * Remove no longer used data-amp-report-test attribute handling. * Revision bump * new validator rules to disallow sibling tags * Revision bump for #10965 and #10976. * adding lite to new validator rules for disallowing siblings * Revision bump from minor clean-up.

2017-08-08

Validator Changes Roll Up (#10832) * Introduce DOCUMENT_TOO_COMPLEX error. * Revision bump (amp-video, crossorigin) * Implement new rule types for min children and allowed descendants. * Revision bump (amp-sidebar) * new validator rules to whitelist descendant tags * Fix minor build breakage in light validators. * Pick up changes from github.

2017-07-31

Update comment on dispatch key (#10727)

2017-07-12

Document semantics of html_format being empty (#9950) Based on the engine code at the following location: https://github.com/ampproject/amphtml/blob/master/validator/engine/validator.js#L3994 when the html_format list is empty, the current TagSpec is allowed to validate all AMP HTML formats.

2017-06-20

Give more nuance to the dispatch_key field. (#10039)

2017-06-06

Implement requires_extension. (#9742)

2017-05-12

Validator Rollup (#9323) * Remove ValidationError::detail, it hasn't been used for a long while * Allow style attributes in SVG tags.

2017-03-30

Validatorrollup (#8513) * Intern TagSpec::mandatory_alternatives. * Avoid instantiating regexes for AttrSpec unless they're actually run. * Even more laziness for ParsedAttrSpec (ParsedValueProperties and triggers). * In light mode, return earlier if the combined blacklist matches. * Insert some comments around the disallowed_domains parameters in the validator rules. * Allow any whitespace in script tags. Previously we only allowed '\n'. * Revision bump * Remove unnecessary spec_name and other validator clean up * Cache the regex objects, precompute the combinedBlacklistedCdataRegex, some simplications. * Revision bump * Improve error for non-whitespace text inside tags and assign it to the DISALLOWED_HTML category. * Rearrange how/when line/col information is stored in matchers by introducing a DOCUMNENT_START constant. * Revision bump. * Revision bump. * Remove i-amp-access-id from amp-access & amp-access-laterpay. * Revision bump to match #8457 and #8353

2017-03-20

Validatorrollup (#8266) * Use Object.create(null) to initialize sets/maps; see https://jsperf.com/object-set-contains/ * Allows animation-timing-function in keyframes. * Revision bump * Improve error message for `style` attributes and font tags. * Intern the AttrSpec::mandatory_oneof values.

2017-03-14

Validatorrollup (#8140) * Fix typo: dumpSaxAsJson should correspond to provide. * Revision bump * Revision bump * Update spec urls to more canonical location. * Add a test case for `<amp-ad>` * Emit one error per attribute, rather than stop at the first error found for any attribute in an HTML tag. * Allow `<iframe>` tag within `<noscript>` section, suggesting `<amp-iframe>` in other contexts. * Revision bump for `<amp-facebook-comments>`. * Error categorization had a conditional branch which no longer could be reached, due to changes to the way we generated errors. This CL removes that extra code. * Revision bump * Revision bump * Blacklist meta name=(amp-.*|amp4ads-.*) and whitelist specific instances. * Make extensions a first-class validator concept with a new ExtensionSpec. * Fix validator-amp-mustache output file.

2017-02-16

Validator rollup (#7590) * `<meta http-equiv=>` tags must have `<head>` as ancestor. * Small javascript performance optimizations. * Remove the unused errors_seen flag. * Use requires/satisfies mechanism instead of also_requires_tag. * Refactoring: Make getAttrsFor simpler and less forgiving (spec now req. $GLOBAL_ATTRS / $AMP_LAYOUT_ATTRS) * Bugfix: Use hasOwnProperty to check whether the key is in the map. * No need to copy over TagSpec.requires. * Share empty arrays for the specification objects where possible. * Allow form elements outside of form tags. * Update amp-access-laterpay. * Add string intern table and use it for simple attrs. The ids for interned strings are negative integers, allowing us to effectively mix them in with ids for complex messages (AttrSpec in this case). * Validate that amp-install-serviceworker[data-iframe-src] is an https URL (if present). * Restrict AMP4ADS extensions. * Allow empty `src` attribute for `amp-pixel`. * Restrict AMP4ADS extensions (part two). * Rely on the global class attr (w/ blacklist) instead of a locally defined one. * html_format unnecessary for both AMP and AMP4ADS extensions. * Elminate SimpleParsedAttrSpec class and use attr ids directly for simple attrs. * Add additional SVG 2.0 elements. * Add SVG filters to AMP Validator rules. * revision bump for amp-call-tracking * Use indexOf instead of startsWith for old Node.js version compat. * Allow empty `config` attribute for `amp-analytics`. * Refactoring: Move the parseAttrsFor method into the constructor of ParsedTagSpec. * Remove `autoplay` attribute from `<amp-anim>` tag in validator. This attribute does nothing, and is not mentioned in the spec. * Change amp-audio[autoplay] from an enum to a boolean attribute. The spec indicates that it's an enum, but the code just passes this through to the audio tag it creates, which treats this as true/false * In generated JS, use ids to identify attr lists (instead of attr lists names). * Remove the tagSpecId field from the TagSpec class. * Replace requires and satisfied fields with interned strings. * Update amp-bind validation rules From PR 7127

2017-01-13

Validator rollup (#7023) * Disallow id="AMP" for all elements. * More disallowed id and name attribute values. * Remove old code for generating manufactured body tag warnings. * Refactoring: Remove template_spec_url field from ParsedTagSpec; access validator rules via Context instance instead. * Make the unused extension warning more descriptive. * Revision bump for input change. * `<amp-analytics>` is required by `<amp-access>`. Fix this warning message. * Remove unused field.

2017-01-05

Validator Rollup (#6898) Validator Rollup

2016-11-21

Validator Rollup (#6284) * revision bump due to amp-hulu extension * Support both v0.js and amp4ads-v0.js if the html_format is AMP4ADS * Test in javascript that validator rules should make sense. * Implement new validator logic that disallows the `<base href>` tag from appearing after any URL on the page. * Test ValidationError in javascript. * Allow this usage of startsWith to pass travis.

2016-11-14

Validator Updates (#6177) * Require <meta name=apple-itunes-app> to have HEAD as parent. * github commit msg missing or malformed * Stricter empty host validation. * Make amp-sticky-ad .js tag unique and allow version 1.0. * Rename CssLengthAndUnit to CssLength and add numeric value. * Add warning variant for duplicate unique tag error. * fix min_validator_version * revision bump due to autoplay for amp-youtube * Update spec_urls to point to ampproject.org instead of github. * Update urls.html feature test.

2016-10-13

Validator Changes Rollup (#5596) * Remove repeated `layout` attribute in `<amp-social-share>` example. * Allow custom validation attributes in forms. * Validate that submit-success/submit-error have templates. * Extract mapped attribute values in reverse order. * Allow AttrTriggerSpec to trigger when if_value_regex is not set. * Validator rules for `<amp-app-banner>` * Comment cleanup. * Handle non-quoted attribute values containing quotation characters. * Allow links to have target=_top. * Allow input and label without a form ancestor. * Add a value_casei option to AttrSpec

2016-09-14

Validator Updates (#5002) * Rev. bump due to pull; small fix to amp-audio test. * a4a -> amp4ads * Finish up the a4a -> ads4amp rename. * Add AMP4ADS support to validator.js. * Fix build.py (amp4ads-parse-css.js missing in file lists). * Bump rev. due to Github pull.