Proto commits in bisq-network/bisq

These commits are when the Protocol Buffers files have changed: (only the last 100 relevant commits are shown)

2024-12-20

api: Remove getoffers' --all option

The documentation is generated from this commit.

2024-09-22

Add new payment method "Faster Payments System (SBP)" for Russian Ruble This is the standard P2P payment method in Russia to perform funds transfers and payments between Russian bank accounts in Russian Rubles. There is no chargeback risk. Recipient bank account is located using telephone number and bank name, and sender receives recipients first name, middle name, and initial of last name to confirm the phone number entered is correct before sending. Adding this new payment method has been discussed at length on the GitHub 'growth' channel at: https://github.com/bisq-network/growth/issues/288

2024-06-12

Add uid to Filter Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add addedBtcNodes and addedSeedNodes fields to Filter. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2024-06-08

Add uid to Filter Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2024-06-07

Add addedBtcNodes and addedSeedNodes fields to Filter. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2024-02-26

Add API for payment started with XMR auto conf params.

2024-02-25

Merge pull request #7023 from jmacxx/fix_issue_7022 GetTrades should not filter open failed trades

2024-02-14

GetTrades should not filter open failed trades. API add has_failed and error_message properties to TradeInfo. Code review fixes from @dutu.

2024-02-09

Expose isDaoStateReadyAndInSync status to API clients.

2023-10-09

Add sellerConfirmedPaymentReceiptDate to Trade Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add delayedPayoutPaymentAccounts to Filter Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2023-10-08

Add sellerConfirmedPaymentReceiptDate to Trade Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add delayedPayoutPaymentAccounts to Filter Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2023-09-11

Merge pull request #6851 from jmacxx/add_mercadopago_payment_method Add MercadoPago payment method.

2023-09-05

Add MercadoPago payment method.

2023-09-04

Improve flow in create/take offer process. When creating or taking an offer the user gets the choice to fund the trade from an external wallet for potentially better privacy (avoid coin merge if inputs from ext. wallet are kept separated). From feedback it seems that most users are not using that option and then they need to do that extra click on the "Fund from internal Bisq wallet" button. We offer a way to avoid that extra step if the user chooses to use the internal wallet. We show at the first time a popup with background info why funding from an external wallet could improve privacy and if the user prefers to not use that to give them an option to skip that step in future. In the settings we could add a toggle to re-enable it again. The review screen can be skipped if user chooses this feature, leading to data entry > confirm rather than data entry > fund > review > confirm.

2023-07-01

Add reset buttons for BM accounting

2023-06-08

API: gettransactions method

2023-04-15

Merge pull request #6646 from helixx87/api-get-all Support "all" attribute in getoffers API method

2023-04-11

Support "all" attribute in getoffers API method

2023-04-10

Add processBurningManAccountingData field to preferences Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2023-03-12

Support UI improvements (per bisq project 67).

2022-12-19

Add INVALID_SNAPSHOT_HEIGHT to AvailabilityResult. Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error. Show description in error popup instead of enum name. Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2022-12-18

Add INVALID_SNAPSHOT_HEIGHT to AvailabilityResult. Use AvailabilityResult.INVALID_SNAPSHOT_HEIGHT instead of AckMessage with error. Show description in error popup instead of enum name. Return PRICE_CHECK_FAILED instead of UNKNOWN_FAILURE at error at price check also for non api users. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2022-12-14

Merge pull request #6423 from HenrikJannsen/add-burningman-accounting Add burningman accounting

2022-12-11

Rename *ValueItem to *ValueReportingItem Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add messages and domain data for accounting domain Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add verifyDelayedPayoutTxReceivers method in RefundManager. Add burningManSelectionHeight and tradeTxFee in Dispute. Call validateDonationAddressMatchesAnyPastParamValues and validateDonationAddress only if legacy BM was used. Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

Add burningManSelectionHeight fields to OfferAvailabilityRequest, InputsForDepositTxRequest and ProcessModel. Use BurningManService.getBtcFeeReceiverAddress at createFeeTx tasks. Verify takers burningManSelectionHeight if BurningManService.isActivated at MakerProcessesInputsForDepositTxRequest and OpenOfferManager. Stores burningManSelectionHeight in ProcessModel. Add BurningManService fields to OfferAvailabilityModel, PlaceOfferModel, OpenOfferManager and Provider Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2022-12-09

Use LongValueItem instead of IntegerValueItem Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2022-12-07

Add value objects and protobuf definitions Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>

2022-11-29

Increase trading limits as an opt-in setting (GH proposal 398) More restrictive limits will still apply based on payment method. It is intended to avoid that a new users who do not fully understand the process of a Bisq trade to cause an arbitration case with high amounts and therefore higher risks and costs for the DAO.

2022-11-22

Include option for non-URI addresses in QR codes

2022-09-20

Add wasTruncated flag Indicates if data response contained all data or was truncated

2022-09-11

Improve takeoffer param api ref comments

2022-08-06

Add amount field to TakeOfferRequest proto msg

2022-06-29

Update .proto rpc get/take offer method comments Explain that the API's getoffer(s) and takeoffer methods only work as expected when the user's node has payment account/methods matching the available offers' own payment methods. - getoffers returns only the offers with payment methods matching those set up on the user's node - getoffer will only return the offer if the user's node has a payment method matching the payment method associated with the requested offer - takeoffer will fail if the user's node does not have a matching payment method

2022-06-23

Fix snake_case field name Be consistent, and x-language.

2022-06-20

Merge pull request #6236 from jmacxx/xmr_subaddresses Feat: XMR subaddresses per account

2022-06-17

Add API method 'getavgbsqprice' Returns volume weighted average BSQ price in BTC and USD over N days. The need for this arose while creating a Java BSQ Swap bot example (PR pending). API bots can use this to determine whether or not to take swap offers based on their price distance above or below the 30 (or 90) day trade price average.

2022-06-16

Add API API method 'getnetwork' Returns name of the BTC network API daemon is connected to. I am working on some Java bot examples in another repo, and want to stop worrying about accidentally simulating trade payments on mainnet, despite all the warnings I add in comments. The 'getnetwork' method allows bots to know what network the API daemon is connected to, and gives API bot devs and users a way to avoid one potential source of costly mistakes. API CLI manpage and apitest case are included in this commit.

2022-06-14

Feat: XMR subaddresses per account incremente subaddress index at the start of the trade Add subaccounts Rename XmrAccountHelper to XmrAccountDelegate Add map as final non null value Persist subaccounts in User Add display of used subaddresses and tradeId in account summary. Main address and account index are the unique key for sub accounts. Use the initial subaddress chosen by the user. chimp1984 code review patch. News badge/info for Account, disable old ones. Show XMR subaddress popup info at Account (news badge), not startup.

2022-04-07

Adapt navigational structure and offerbook handling to buy and sell different assets Still missing correct create and take offer handling

2022-03-12

Send pretty payment details to api clients Non-CLI clients need a better way of accessing payment details than a contract json string. - Add grpc.proto PaymentAccountPayloadInfo field: payment_details. - Adjust proto wrapper PaymentAccountPayloadInfo to new field. - Add test asserts to verify payment details are sent to client. - Fix a test name: testKeepFunds -> testCloseTrade. Based on branch `master` @ Sat 12 Mar 2022 01:42 PM -03 , commit c6293b52730e59c675953fc8cff9238d0efd7edc

2022-02-27

Change grpc.proto TradeInfo field names - is_fiat_sent -> is_payment_started_message_sent Payment can be in altcoin. - is_fiat_received -> is_payment_received_message_sent Payment can be in altcoin. - is_withdrawn -> is_completed Trade can be closed with funds kept in Bisq wallet.

Change grpc.proto field names to snake_case Java client code can still use the camelCase field naming convention, and other language bindings will not be forced to do the same. Snake_case field names are also recommended in the Protocol Buffers Sytle Guide: https://developers.google.com/protocol-buffers/docs/style

2022-02-26

Remove GetTradeStatistics service from grpc.proto This protobuf definition and service stub has been in place since the start of work on the API, but was never fully implmented, nor intended to be included in the API beta & v1 releases. Its presence added a useless section to the gRPC API Reference doc. https://ghubstan.github.io/slate Based on branch `7-more-grpcproto-comments`, PR https://github.com/bisq-network/bisq/pull/6068.

2022-02-25

Fix file/merge conflict

Merge branch 'master' into 7-more-grpcproto-comments

2022-02-21

Be consistent in use of apostrophe

Fix comment error

Fix errors in comments

Finish 1st full pass of documenting grpc.proto for API reference site

2022-02-20

New comments through "message TxInfo { ... }"

Disambiguate grpc.proto offer pct literal field names Rename double marketPriceMargin -> marketPriceMarginPct. Rename double buyerSecurityDeposit -> buyerSecurityDepositPct.

2022-02-19

Change TradeInfo .proto's price & volume fields to string

2022-02-18

Change OfferInfo proto's volume fields' type to string

Change existing `uint64 triggerPrice` field type in grpc.proto to `string triggerPrice`.

2022-02-17

Fix typo in comment

Change OfferInfo proto's 'price' field type to string Much less ambiguous field value at cost of breaking backward compat in API.

Fix comment about changing "all" number fields to string We will consider each problematic number field one at a time. Note: changing field types in following commits will break the API's backward compatibility, but devs agree it's OK since it is still in beta.

Prepare API Offers .proto defs for significant changes This commit adds comments to grpc.proto to be pulled into a new API reference doc. Some of the comments highlight issues to be resolved in following PRs. The main focus is on documenting gRPC Offers service definitions in grpc.proto: - Comment each field in the Offers service's messages. - Add TODO comments about fixing field defs with usability & consistency problems. Other API reference doc related changes to grpc.proto: - Comment each gRPC service's rpc method definitions, however briefly. - Improve some existing rpc method comments.

2022-02-13

Remove "has no parameters" comments from grpc.proto

2022-02-12

Begin commenting grpc.proto for bisq-grpc-api-doc Banner comments were replace by simple service description comments. Rpc methods were commented, some field level comments were moved to to bisq-grpc-api-doc comment conventions.

Add license comment

Remove banner style comments from pb.proto The bisq-grpc-api-doc generator needs comments spefic to protobuf message definitions, not groups of message defs. This kind of information can be included in the message specific comments. Also changed some existing comments, and added others to suggest a commenting style for .proto message and field defs.

2022-02-01

Merge pull request #5976 from ghubstan/1-gettrades Add API 'gettrades' method

2022-01-31

Clear account payload info & chats from closed trades & disputes.

2022-01-23

Add payout fields to trade proto msgs, show optional trade/tx fees in swaps

2022-01-20

Remove duplicated buyer/seller proto fields (already exist no OfferInfo)

2022-01-18

Try to display accurate status of closed trades, or "Pending" if still open

2022-01-16

Add GetTrades proto message, + needed TradeInfo fields

2022-01-12

Merge pull request #5953 from jmacxx/logs_upload Feature enabling log file upload to mediators

2022-01-07

Add API methods 'failtrade', 'unfailtrade' Prerequisite for next PR: Add API method 'gettrades' The `gettrades` method will show 'open', 'closed', and 'failed' trades. Users already needed to be able to fail and unfail trades for the same reasons they do in the UI. API test cases will need to be able to fail and unfail trades to check correct behavior of 'gettrades' method. Based on branch `rename-keepfunds2closetrade`.

2022-01-06

Feature enabling log file upload to mediators

2022-01-05

Rename API method keepfunds -> closetrade Trade proceeds and deposits have already been transfered to Bisq wallets before the `keepfunds` command is (was) executed; `keepfunds` merely moves open trades to closed trades lists and persistence files. Renaming `keepfunds` as `closetrade` makes its purpose clear to API users. The commit modifies only method names and comments in api server+cli classes, apitest cases, and api trade simulation scripts. Based on `master`

2021-12-27

Merge branch 'master' into 7-deprecate-api-getmyoffer

Deprecate API 'getmyoffer' The method 'getoffer' should support looking up a user's open-offers, and other users' available offers. - Adjust api-beta-test-guide.md to use only 'getoffer'. - Adjust trade simulation scripts to use only 'getoffer'. - Adjust api testcases to use 'getoffer' in place of 'getmyoffer'. - Mark appropriate methods and protobuf msgs as deprecated.

2021-12-14

Merge pull request #5876 from ghubstan/5-api-bsqswap-simulation-n-docs-update API BSQ swap simulation script and doc updates #5

2021-12-07

Add separate ProofOfWork.solution proto field for Equihash Avoid repurposing the 'ProofOfWork.payload' field for Equihash puzzle solutions, as that may be of later use in interactive PoW schemes such as P2P network DoS protection (where the challenge may be a random nonce instead of derived from the offer ID). Instead, make the payload the UTF-8 bytes of the offer ID, just as with Hashcash. Also, make the puzzle seed the SHA-256 hash of the payload concatenated with the challenge, instead of just the 256-bit challenge on its own, so that the PoW is tied to a particular payload and cannot be reused for other payloads in the case of future randomly chosen challenges.

Code cleanup: proto fields, duplicated expr & null char separator 1. Reorder the PoW fields in the 'Filter' proto by field index, instead of contextually. 2. Deduplicate expression for 'pow' & replace if-block with boolean op to simplify 'FilterManager::isProofOfWorkValid'. 3. Avoid slightly confusing use of null char as a separator to prevent hashing collisions in 'EquihashProofOfWorkService::getChallenge'. Use comma separator and escape the 'itemId' & 'ownerId' arguments instead. (based on PR #5858 review comments)

Store difficulty as floating point in Filter & PoW Change the type of the 'difficulty' field in the Filter & ProofOfWork proto objects from int32/bytes to double and make it use a linear scale, in place of the original logarithmic scale which counts the (effective) number of required zeros. This allows fine-grained difficulty control for Equihash, though for Hashcash it simply rounds up to the nearest power of 2 internally. NOTE: This is a breaking change to PoW & filter serialisation (unlike the earlier PR commits), as the proto field version nums aren't updated.

Add PoW version(-list) fields to ProofOfWork & Filter Add a numeric version field to the 'ProofOfWork' protobuf object, along with a list of allowed version numbers, 'enabled_pow_versions', to the filter. The versions are taken to be in order of preference from most to least preferred when creating a PoW, with an empty list signifying use of the default algorithm only (that is, version 0: Hashcash). An explicit list is used instead of an upper & lower version bound, in case a new PoW algorithm (or changed algorithm params) turns out to provide worse resistance than an earlier version. (The fields are unused for now, to be enabled in a later commit.)

Add separate ProofOfWork.solution proto field for Equihash Avoid repurposing the 'ProofOfWork.payload' field for Equihash puzzle solutions, as that may be of later use in interactive PoW schemes such as P2P network DoS protection (where the challenge may be a random nonce instead of derived from the offer ID). Instead, make the payload the UTF-8 bytes of the offer ID, just as with Hashcash. Also, make the puzzle seed the SHA-256 hash of the payload concatenated with the challenge, instead of just the 256-bit challenge on its own, so that the PoW is tied to a particular payload and cannot be reused for other payloads in the case of future randomly chosen challenges.

2021-12-06

Code cleanup: proto fields, duplicated expr & null char separator 1. Reorder the PoW fields in the 'Filter' proto by field index, instead of contextually. 2. Deduplicate expression for 'pow' & replace if-block with boolean op to simplify 'FilterManager::isProofOfWorkValid'. 3. Avoid slightly confusing use of null char as a separator to prevent hashing collisions in 'EquihashProofOfWorkService::getChallenge'. Use comma separator and escape the 'itemId' & 'ownerId' arguments instead. (based on PR #5858 review comments)

2021-11-27

Make rpc GetOfferCategory service work for my+avail offers There are some use cases where the CLI needs to know what kind of offer is being acted on before the request is made, For example: There are differences between a BsqSwap 'takeoffer'request, and a v1 'takeoffer' request. A BsqSwap offer cannot be edited by an 'editoffer' request, and an attempt should be blocked by the CLI. - Append isMyOffer GetOfferCategoryRequest rpc msg def. - Adjust daemon.grpc services for new boolean GetOfferCategoryRequest param. - Adjust core.api for new boolean GetOfferCategoryRequest param. - Add validation check in core.api EditOfferValidator to block attempt to edit a BsqSwap offer. - Refactor CoreOffersService get*offer(id) methods to optionally throw excpetions.

2021-11-26

Store difficulty as floating point in Filter & PoW Change the type of the 'difficulty' field in the Filter & ProofOfWork proto objects from int32/bytes to double and make it use a linear scale, in place of the original logarithmic scale which counts the (effective) number of required zeros. This allows fine-grained difficulty control for Equihash, though for Hashcash it simply rounds up to the nearest power of 2 internally. NOTE: This is a breaking change to PoW & filter serialisation (unlike the earlier PR commits), as the proto field version nums aren't updated.

2021-11-25

Remove API createoffer's paymentAcctId request param (BSQ swap)

2021-11-24

Remove Get/Take BSQSwap Offer/Trade rpc service defs The old GetTrade and TakeOffer rpc service defs will be used for getting BSQ swap trades, and taking BSQ swap offers.

Add PoW version(-list) fields to ProofOfWork & Filter Add a numeric version field to the 'ProofOfWork' protobuf object, along with a list of allowed version numbers, 'enabled_pow_versions', to the filter. The versions are taken to be in order of preference from most to least preferred when creating a PoW, with an empty list signifying use of the default algorithm only (that is, version 0: Hashcash). An explicit list is used instead of an upper & lower version bound, in case a new PoW algorithm (or changed algorithm params) turns out to provide worse resistance than an earlier version. (The fields are unused for now, to be enabled in a later commit.)

2021-11-23

Merge branch 'master' into 1-basic-api-bsqswap-support

2021-11-18

Merge pull request #5834 from jmacxx/dispute_ui_add_penalty Add penalty calculation to dispute agent UI

Add penalty calc to dispute UI

2021-11-14

Adjust API 'gettrade' for Bsq swaps - Made several adjustments to CLI's 'gettrade' output related code so it can show single trade details for either Bisq v1 trades, or BSQ swap trades. - Did minor refactoring of API's core to retrieve # tx confirmations for an addresses and transactions. - Show # of tx confirmations in bsq swap trade detail.

Add fee fields to filter

2021-11-12

Merge branch 'master' into 1-basic-api-bsqswap-support

Normalize API gRPC bsq-swap related protos & wrappers This commit refactors the first cut of the BsqSwapTradeInfo and TradeInfo gRPC proto defs and wrappers. The change avoids duplication of fields between BsqSwapTradeInfo and TradeInfo, and adds a bsqSwapTradeInfo field to the old TradeInfo proto & wrapper. The immediate goal is moving towards getting the API's 'gettrade' method to work for both Bisq v1 trades and BSQ swap trades: the TradeInfo proto sent to the CLI should represent either a Bisq v1 trade or a BSQ swap trade. A mid-term term goal is to also make a new 'gettrades' method return a List<TradeInfo> to the CLI, where items in the List<TradeInfo> can be either v1 trades or bsq-swap trades.

Add payment methods ACH Transfer and Domestic Wire Transfer

2021-11-11

Adjust bsq-swap-offer related gRPC services & msgs - Adjust GetBsqSwapOffer(s) rpc services to remove currency param. - Adjust OfferInfo and remove BsqSwapOfferInfo. - Add GetOfferCategory service so CLI can determine what kind of takeoffer service is to be used. - Add comment about adding sub-message BsqSwapTradeInfo field to TradeInfo.