Proto commits in google/crosvm

These 52 commits are when the Protocol Buffers files have changed:

2025-03-20

infra: Add recipe for upreving baguette image The recipe will use the uprev-image-version.sh script to update concierge's baguette_version.h. BUG=b:404330289 TEST=python3 recipes.py test run TEST=python3 recipes.py run uprev_baguette_image push=true Change-Id: Ia9439ea52e158cb6bcc22875c24e611943aa4d5f Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/6369869 Reviewed-by: Zihan Chen <zihanchen@google.com> Commit-Queue: Dennis Kempin <denniskempin@google.com>

The documentation is generated from this commit.

2025-01-16

infra: Add recipe for building baguette image This CL added a recipe and a builder to periodically generate images for baguette and upload them into GCP bucket. TEST=Can generate images w/ crrev/c/6176894 BUG=b:345312465 Change-Id: I97efb0bb6950d5bf8699e3799b77ffb24f49910f Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/6173018 Auto-Submit: Zihan Chen <zihanchen@google.com> Commit-Queue: Zihan Chen <zihanchen@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com>

2024-07-11

infra: Add generic presubmit recipe This works basically like the health_check recipe and lists all checks within a group to run one by one. In contrast to the health_check recipe, this one allows that group name to be configured so we can add separate builders for different groups of checks. BUG=b:349907813 TEST=recipes.py test run Change-Id: I4444e943c38bcda38fc7c8b6f06151a1401a6d16 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5689950 Commit-Queue: Dennis Kempin <denniskempin@google.com> Reviewed-by: Zihan Chen <zihanchen@google.com>

2024-04-09

metrics: Remove downstream metrics dependencies Add a metrics_event package instead of relying on metric events provided out of a vendor/ crate. The new API defines the same events as the existing vendor API, except it removes any dependencies on downstream details. To allow downstream projects to define their own events, the new API adds a vendor metrics_event package to support downstream-only event types. BUG=b:332466813 TEST=./tools/dev_container ./tools/presubmit all Change-Id: I766ad6ca2a0a437bb487e27fb84a4984f66c9770 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5400361 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Noah Gold <nkgold@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com> Commit-Queue: David Stevens <stevensd@chromium.org>

2024-03-08

metrics: move noop metrics under generic downstreams will override metrics_product crate BUG=b:286107739 TEST=none Change-Id: I90e05289d509c3f3ff85cc3441c89aad3507f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5356287 Commit-Queue: Vikram Auradkar <auradkar@google.com> Reviewed-by: Noah Gold <nkgold@google.com>

2023-08-01

Reland "Reland "balloon: rename WSS to WS"" This reverts commit 2aea504a65dd37dba0e8060b1c38bdf08d0ee680. Reason for revert: missed run-time flag migration, fixed this time around and tested more thoroughly BUG=b/288432539 TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events TEST=patch in to chromeos; emerge-volteer crosvm && emerge-volteer vm_host_tools TEST=cros deploy && restart vm_concierge on DUT TEST=cros deploy && vmc start borealis && (borealis) DISPLAY=:0 steam Original change's description: > Revert "Reland "balloon: rename WSS to WS"" > > This reverts commit cf1c3cd755474e61a36bf394193ce084d0df0bdd. > > Reason for revert: The command line change will break existing > usage of the CLI flag > > Original change's description: > > Reland "balloon: rename WSS to WS" > > > > This reverts commit 94dc10b57cfb142e7996d17a66e2e29a824f0d9d. > > > > Reason for revert: relanding changes with fully implemented types > > > > BUG=b/288432539 > > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > > TEST=patch in to chromeos; emerge-volteer crosvm && emerge-volteer vm_host_tools > > > > Original change's description: > > > Revert "balloon: rename WSS to WS" > > > > > > This reverts commit 1eb1106537ed005aac1fea9c57b5e2893058c005. > > > > > > Reason for revert: headers generated by cbindgen do not compile as expected downstream > > > > > > Original change's description: > > > > balloon: rename WSS to WS > > > > > > > > as the working set feature approaches acceptance at the spec-level, we > > > > are keeping up with nomenclature changes. > > > > > > > > BUG=b/288432539 > > > > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > > > > > > > > Change-Id: I323a2c5402cb8008f8c912b0849e8e3501f9e1f3 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4702340 > > > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > > > > > BUG=b/288432539 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > > > > Change-Id: I46459b4afd428c67436a754b3e62a104a680c68f > > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722468 > > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > > > BUG=b/288432539 > > > > Change-Id: Ifb78acf2914b96306a2d1104e21eff6e67ed45df > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722288 > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > BUG=b/288432539 > > Change-Id: I3bcb26699fd1d15eab594143490f863941d3eceb > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4730438 > Commit-Queue: Dennis Kempin <denniskempin@google.com> > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> BUG=b/288432539 Change-Id: I657f648aec0fc4f4551cf3c109c5ecedcdddbcb2 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4733877 Reviewed-by: Dennis Kempin <denniskempin@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: maciek swiech <drmasquatch@google.com>

2023-07-28

Revert "Reland "balloon: rename WSS to WS"" This reverts commit cf1c3cd755474e61a36bf394193ce084d0df0bdd. Reason for revert: The command line change will break existing usage of the CLI flag Original change's description: > Reland "balloon: rename WSS to WS" > > This reverts commit 94dc10b57cfb142e7996d17a66e2e29a824f0d9d. > > Reason for revert: relanding changes with fully implemented types > > BUG=b/288432539 > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > TEST=patch in to chromeos; emerge-volteer crosvm && emerge-volteer vm_host_tools > > Original change's description: > > Revert "balloon: rename WSS to WS" > > > > This reverts commit 1eb1106537ed005aac1fea9c57b5e2893058c005. > > > > Reason for revert: headers generated by cbindgen do not compile as expected downstream > > > > Original change's description: > > > balloon: rename WSS to WS > > > > > > as the working set feature approaches acceptance at the spec-level, we > > > are keeping up with nomenclature changes. > > > > > > BUG=b/288432539 > > > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > > > > > > Change-Id: I323a2c5402cb8008f8c912b0849e8e3501f9e1f3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4702340 > > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > > > BUG=b/288432539 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > > > Change-Id: I46459b4afd428c67436a754b3e62a104a680c68f > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722468 > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > BUG=b/288432539 > > Change-Id: Ifb78acf2914b96306a2d1104e21eff6e67ed45df > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722288 > Commit-Queue: maciek swiech <drmasquatch@google.com> > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> BUG=b/288432539 Change-Id: I3bcb26699fd1d15eab594143490f863941d3eceb Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4730438 Commit-Queue: Dennis Kempin <denniskempin@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2023-07-26

Reland "balloon: rename WSS to WS" This reverts commit 94dc10b57cfb142e7996d17a66e2e29a824f0d9d. Reason for revert: relanding changes with fully implemented types BUG=b/288432539 TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events TEST=patch in to chromeos; emerge-volteer crosvm && emerge-volteer vm_host_tools Original change's description: > Revert "balloon: rename WSS to WS" > > This reverts commit 1eb1106537ed005aac1fea9c57b5e2893058c005. > > Reason for revert: headers generated by cbindgen do not compile as expected downstream > > Original change's description: > > balloon: rename WSS to WS > > > > as the working set feature approaches acceptance at the spec-level, we > > are keeping up with nomenclature changes. > > > > BUG=b/288432539 > > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > > > > Change-Id: I323a2c5402cb8008f8c912b0849e8e3501f9e1f3 > > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4702340 > > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > > Commit-Queue: maciek swiech <drmasquatch@google.com> > > BUG=b/288432539 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > > Change-Id: I46459b4afd428c67436a754b3e62a104a680c68f > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722468 > Commit-Queue: maciek swiech <drmasquatch@google.com> > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> BUG=b/288432539 Change-Id: Ifb78acf2914b96306a2d1104e21eff6e67ed45df Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722288 Commit-Queue: maciek swiech <drmasquatch@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

Revert "balloon: rename WSS to WS" This reverts commit 1eb1106537ed005aac1fea9c57b5e2893058c005. Reason for revert: headers generated by cbindgen do not compile as expected downstream Original change's description: > balloon: rename WSS to WS > > as the working set feature approaches acceptance at the spec-level, we > are keeping up with nomenclature changes. > > BUG=b/288432539 > TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events > > Change-Id: I323a2c5402cb8008f8c912b0849e8e3501f9e1f3 > Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4702340 > Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> > Commit-Queue: maciek swiech <drmasquatch@google.com> BUG=b/288432539 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I46459b4afd428c67436a754b3e62a104a680c68f Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4722468 Commit-Queue: maciek swiech <drmasquatch@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2023-07-25

balloon: rename WSS to WS as the working set feature approaches acceptance at the spec-level, we are keeping up with nomenclature changes. BUG=b/288432539 TEST=cargo build, cargo build --no-default-features, cargo build --features registered_events Change-Id: I323a2c5402cb8008f8c912b0849e8e3501f9e1f3 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4702340 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: maciek swiech <drmasquatch@google.com>

2023-05-22

balloon: use protos for registered events since the RegisteredEvent model is effectively an external API, switch to using protobuf as a more formal/stable means of communicating messages. also introduces exporting the registered_events.proto file as part of crosvm_control build, alongside the currently existing header file. this patch also introduces feature-gating for registered_events and protos so as not to bring in too many third party dependencies for a base build. BUG=b/278117550 TEST=run bzImage locally TEST=sidecar program available at https://x20.corp.google.com/users/dr/drmasquatch/socket-pinger-proto Change-Id: I5d91d87f7807effc125352caf5c75eee2593f70d Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4521604 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: maciek swiech <drmasquatch@google.com>

2023-04-19

infra/recipes: clean up leftover crosvm_direct support Deprecate the crosvm_direct field in build_linux.proto and remove the code that used it in build_linux.py. BUG=b:276993009 Change-Id: I1c48064391f3201ad6e27bf9dbfe33e705477672 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4437033 Commit-Queue: Dennis Kempin <denniskempin@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com> Auto-Submit: Daniel Verkamp <dverkamp@chromium.org>

2023-02-22

metrics: Add missing process types Downstream we've added the SPU + Broker process types, this should be reflected here to avoid numbers going out of sync. Also adds sound type. BUG=b:269313507 TEST=presubmit Change-Id: I5e3e269c9aca7bc9504e3e822302bcccf3bf377f Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4246713 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>

2023-02-09

infra: Switch to new test runner Updates the infra recipes to use the new test runner. Instead of directly specifying options like `repeat`, we can use nextest profiles for configuration. The profile defaults to presubmit until builder configs are updated. See attached bug for full rollout plan BUG=b:261600801 TEST=led launched for all platforms: x86_64: https://ci.chromium.org/swarming/task/604be1c3f5d44c10 aarch64: https://ci.chromium.org/swarming/task/604bf12212afe210 armhf: https://ci.chromium.org/swarming/task/604bf14a11dd7910 mingw64: https://ci.chromium.org/swarming/task/604bf23cee0c0510 Change-Id: Ibaad9f61d2266586a91491d5d2c6da24ecc44e88 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4234898 Reviewed-by: Zihan Chen <zihanchen@google.com> Commit-Queue: Dennis Kempin <denniskempin@google.com>

2022-11-04

infra/recipes: remove original crOS builder New containerized builder is ready, and the old builder has been red for a long time. BUG=b:240692674 Change-Id: I1b4066c6f12bbfa9f3756ad50c0ceb8a133564c7 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/4004354 Commit-Queue: Dennis Kempin <denniskempin@google.com> Auto-Submit: Zihan Chen <zihanchen@google.com> Reviewed-by: Dennis Kempin <denniskempin@google.com>

2022-10-21

Create the empty gh-pages branch The gh-pages branch should be used for the redirection from https://google.github.io/crosvm/ to http://crosvm.dev. Change-Id: I98decbff18d9208f9b1536932f99d1dd58c7d403

This commit does not contain any .proto files.

2022-09-20

power_monitor: Enable feature in all-linux To enable this feature, we copy the required proto file from ChromeOS. Not a great solution, but better than leaving the code uncompiled in upstream. We could consider downloading the file from gitilies with a fixed sha that is manually upreved. But unfortunately downloading things in build.rs is not trivial without adding a ton of dependencies for the reqwest crate. BUG=b:244619797 TEST=presubmit Change-Id: I401917134471909be80a281454bc64dd27799afe Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3907373 Auto-Submit: Dennis Kempin <denniskempin@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Dennis Kempin <denniskempin@google.com>

2022-09-13

Update all copyright headers to match new style This search/replace updates all copyright notices to drop the "All rights reserved", Use "ChromiumOS" instead of "Chromium OS" and drops the trailing dots. This fulfills the request from legal and unifies our notices. ./tools/health-check has been updated to only accept this style. BUG=b:246579983 TEST=./tools/health-check Change-Id: I87a80701dc651f1baf4820e5cc42469d7c5f5bf7 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3894243 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Dennis Kempin <denniskempin@google.com>

2022-08-18

health-check: Add check for newline at ends of files Fixes a couple of files that were missing them. BUG=b:242605601 TEST=./tools/health-check --fix Change-Id: I620d6a939cb824e014002152584aacfc5dfdf7e8 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3835648 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: Dennis Kempin <denniskempin@google.com> Commit-Queue: Dennis Kempin <denniskempin@google.com>

2022-08-09

infra: Integrate coverage upload into build_linux This allows us to upload coverage from all post-submit builders. codecov.io will merge all uploaded reports so we can see a combined view of code coverage across architectures. BUG=b:239255082 TEST=./infra/recipes.py test run Change-Id: I7705ab646bc86a159a2650cfd35be38e6fedfcca Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3817977 Commit-Queue: Dennis Kempin <denniskempin@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: Dennis Kempin <denniskempin@google.com>

2022-07-21

crosvm: Fix drift BUG=b:213146388 TEST=presubmit Change-Id: I59e6b7ad7aff8d4659c62e310a7955146a10d743 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/3777405 Tested-by: Vikram Auradkar <auradkar@google.com> Reviewed-by: Noah Gold <nkgold@google.com> Auto-Submit: Vikram Auradkar <auradkar@google.com> Commit-Queue: Vikram Auradkar <auradkar@google.com>

2022-07-08

test runner: Allow retries of flaky tests The test runner can now repeat tests in two ways: - Via --repeat to run tests multiple times and fail if any one of them fails. Which will help us find flakes in post-submit. - Via --retry, which will retry a test if it has failed. Which makes pre-submit tests more resilient to flakes. Both can be configured by builder configs to adjust as needed. Also slighly changes the repeat behavior to repeat tests in batches, so we do not run the same test multiple times simultaneously, which can cause some of them to fail. It's also easier to read the results. BUG=b:238232551 TEST=added a random flake into some tests and used --repeat and --retry Change-Id: I78e0ff0751da40a99a56080d9baf207307c9e93a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3751835 Tested-by: Dennis Kempin <denniskempin@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2022-07-07

infra: Repeat tests in post-submit This will help us find flaky test. Runtime increase is not that significant (~10min). BUG=b:238232551 TEST=Builder config needs to be tested in luci Change-Id: Ie75cc9620177115623500fe2206f33464f4c8580 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3751831 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>

Add crosvm_linux_x86_64_direct builder Similar to the one we added to kokoro, run tests with --crosvm-direct. BUG=b:238234098 TEST=recipe tests included Change-Id: I2b03ca02fbfb577fd5cebf346eec468ebd625626 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3749937 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Dennis Kempin <denniskempin@google.com>

2022-05-26

infra: Add ChromeOS post-submit builder This re-creates the Kokoro equivalent crosvm/ci/build-chromeos.sh. It is a very inefficent builder that does a fresh checkout of chromeos for every build. We may want to consider using some of the chromiumos recipes for caching the repo or sdk between builds. BUG=b:233230344 TEST=./recipes.py test run ./recipes.py run build_chromeos Change-Id: I5d545bae4817cae5b79c5d65901081d9b1391466 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3664842 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>

2022-05-25

Revert "Revert "metrics: Add metrics crate."" This reverts commit 55a5c8d8f9969be5510115b3876b2f0fefdbcb06. In order to accommodate the removal of the UnixSeqPacket+CloseNotifier change, I updated the controller.rs to reference platform-specific internal implementations. On Windows, CloseNotifier is used to detect closed Tubes. On Linux, we rely on PollContext returning because the socket fd is hung up. Some minor adjustmets to the code were made just to allow as litte duplication as possible. In the end, very little logic has changed from the original CL, it's just moved around. TL;DR: This fixes the downstream regression by removing its dependency on the breaking changes to base. BUG=b:232316549 FIXED=b:232316549 TEST=Crosvm tests Change-Id: I946d5096f7a312538c3c694950697fab1be7f0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3661257 Commit-Queue: Michael Hoyle <mikehoyle@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>

2022-05-24

infra: Initial setup of linux pre/post-submit builders The builders use the existing dev_container to run tests for the 3 currently supported architectures on linux: x86_64, aarch64 and armhf. A new recipe 'build_linux' has been added runs the dev_container to build and execute tests. To share code with other upcoming recipes, some of the recipe code has been extracted into a shared crosvm module. Basic tests for the recipes have been added. BUG=b:233230344 TEST=./recipes.py test run ./recipes.py run build_linux Change-Id: I17ecb25c0a0eabdce56537831454ac22d4dc7021 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3654196 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2022-05-12

Revert "metrics: Add metrics crate." This reverts commit 4c2017c7578dc892b9c019d5d53150cd07cdc386. Reason for revert: dependency crrev.com/c/3622798 caused regression Original change's description: > metrics: Add metrics crate. > > This crate is effectively a collection of stubs in this repo, > but will allow a downstream repo to implement those stubs. > > BUG=b:213152497 > FIXED=b:213152497 > TEST=build + kokoro > > Change-Id: I3c544644ec3d7917f9ebb2e8621042c35b556db8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3622799 > Reviewed-by: Noah Gold <nkgold@google.com> > Commit-Queue: Michael Hoyle <mikehoyle@google.com> > Tested-by: kokoro <noreply+kokoro@google.com> BUG=b:213152497,b:232316549 TEST=CtsAccessibilityServiceTestCases Change-Id: Idd636d7d34e68977fffc1f6c0a89924eb7be5d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3641218 Auto-Submit: Shao-Chuan Lee <shaochuan@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Michael Hoyle <mikehoyle@google.com> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2022-05-10

metrics: Add metrics crate. This crate is effectively a collection of stubs in this repo, but will allow a downstream repo to implement those stubs. BUG=b:213152497 FIXED=b:213152497 TEST=build + kokoro Change-Id: I3c544644ec3d7917f9ebb2e8621042c35b556db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3622799 Reviewed-by: Noah Gold <nkgold@google.com> Commit-Queue: Michael Hoyle <mikehoyle@google.com> Tested-by: kokoro <noreply+kokoro@google.com>

2020-03-05

crosvm: add handling for hyperv exits When features for Hyper-V are enabled there's a another type of exit that can be triggered. This change attempts to add support for those types of exits. BUG=b:150151095 TEST=ran build_test Change-Id: I3131a2c8d9c610576ac177dbfe82f78e8d5dbfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2073254 Reviewed-by: Matt Delco <delco@chromium.org> Tested-by: Matt Delco <delco@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Commit-Queue: Matt Delco <delco@chromium.org> Auto-Submit: Matt Delco <delco@chromium.org>

2020-02-20

crosvm: add ability to enable caps on vcpu This change primarily adds functionality to allow kvm features to be enabled on a vcpu (most of the current infra only supporst the ioctl for the vm fd). BUG=b:144746965 TEST=ran 'build_test' and verified that the added tests passed. Change-Id: I30c00b6f462377c21d477602ceba5853df953b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2055883 Tested-by: Matt Delco <delco@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Matt Delco <delco@chromium.org>

crosvm: support kvm's hyper-v cpuid ioctl Kvm can emulate the hyper-v paravirt interface. Newer versions of kvm can advertise the features they support via an ioctl() that reports the cpuid leafs for this interface. This change adds some support for the ioctl() and plumbs it through the plugin interface so that plugins can determine the level of support available in kvm. BUG=b:144746965 TEST=Ran build_test on kernel that supports the ioctl. Added temporary code to print the cpuid leafs and verified that the output is as expected. Instrumented failure as expected from older kernels and verified that results still passed. Change-Id: I6cd7dade1793e4edb52b331d5b960685541f7ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/2037919 Tested-by: Matt Delco <delco@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Matt Delco <delco@chromium.org>

2019-11-06

crosvm: add plugin API for async writes A plugin might care to be immediately notified when a write is made to a port, but it doesn't care to have the VM stopped while the plugin calls back to resume the VM. Unfortunately this means that multiple messages can be queued up in the pipe and read() together by the plugin API. Protobuf's parsing function doesn't report how many bytes it read, so I've resorted to having crosvm prefix every message with a length and then have the plugin lib parse this number. Impact on performance has not been measured. BUG=b:143294496 TEST=Local build and run of build_test. Verified that new unit test was executed, exercised the case where multiple msgs are received together, and completed successfully. Change-Id: If6ef463e7b4d2e688e649f832a764fa644bf2d36 Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1896376 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Stephen Barber <smbarber@chromium.org>

2019-10-31

crosvm: pre-cache answers to plugin get calls This change tries to improve the performance of a plugin-based VM by adding a hint API that allows crosvm to proactively push cpu state to the plugin when certain ports for hypercalls are accessed by the VM. BUG=None TEST=build and run. See performance increase significantly. Change-Id: I71af24ebc034095ffea42eedb9ffda0afc719cd6 Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1873005 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Zach Reizner <zachr@chromium.org>

2019-10-23

crosvm: defer IPC on set calls If a plugin makes a set call on vcpu registers then we can improve performance by deferring the IPC and instead conbining the request with the next resume call. BUG=None TEST=build and run. Change-Id: I4eb54a3f6eb30c98971aa2f099e3ea5899767eed Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1825262 Reviewed-by: Zach Reizner <zachr@chromium.org>

crosvm: delete resume response from protobuf The resume response was deleted in a earlier change. This change removes the message type from the proto file and adjusts crosvm so it can still build after this removal. BUG=None TEST=build and run. Change-Id: I27d36a51b1e7eb59258d23da38199b86d7cb3659 Signed-off-by: Matt Delco <delco@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1825260 Reviewed-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>

2019-10-03

Support composite disks. This adds a new disk file type next to raw files and qcow images that represent an indirection to further raw disk files. The disk file itself is a proto file with references to file paths for other disks to open and their virtual offsets and lengths. The intention is to make it easy to assemble a single virtual hard disk out of several distinct partition files. In the particular case of Cuttlefish running Android in a VM, this is relevant as the Android build system distributes partitions as separate raw files. While the simple solution is to pass each partition as a separate raw disk, some functionality (like the bootloader) assumes there is a partition table with multiple distinct partitions on a single disk. Implementing composite disk support in the VMM bridges this gap through supporting the general-purpose case of a disk built out of multiple component files. If desired, this can be extended to support qcow files to support unusual configurations like a mixed qcow/raw disk. Enabled with the "composite-disk" feature. Bug: b/133432409 Change-Id: I2b0c47d92fab13b5dc0ca5a960c7cfd2b7145b87 Signed-off-by: Cody Schuffelen <schuffelen@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/1667767 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Daniel Verkamp <dverkamp@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com>

2019-04-24

crosvm: use pipe instead of socket for vcpu communication Pipes have better performance than sockets, so switch the vcpu communication over to pipes. The vm communication channels will continue to use sockets since that communication isn't performance critical (and those messages sometimes exchange file descriptors, and that functionality requires sockets). TEST=local compile and confirmed that my diagnostic plugin is still happy. The time it takes to run my benchmark plugin has decreased by 20%. This combined with my prior commit results in a net wall-clock time reduction of 32%. BUG=None Change-Id: I44c198d62a3bbe3b539ff6ac79707d02488876e3 Signed-off-by: Matt Delco <delco@google.com> Reviewed-on: https://chromium-review.googlesource.com/1572873 Commit-Ready: Matt Delco <delco@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Zach Reizner <zachr@chromium.org>

2019-04-12

protos: Merge plugin_proto crate under protos::plugin This de-duplicates the two separate build.rs files dealing with proto compilation. The trunks interface.proto will be exposed under protos::trunks and the plugin proto will be exposed under protos::plugin. BUG=none TEST=cargo check TEST=cargo check --features tpm TEST=cargo check --features plugin TEST=cargo check --features tpm,plugin TEST=FEATURES=test emerge-nami crosvm TEST=FEATURES=test USE=crosvm-tpm emerge-nami crosvm TEST=FEATURES=test USE=crosvm-plugin emerge-nami crosvm TEST=FEATURES=test USE='crosvm-tpm crosvm-plugin' emerge-nami crosvm TEST=local kokoro CQ-DEPEND=CL:1553971 Change-Id: I203b654a38e9d671a508156ae06dfb6f70047c4f Reviewed-on: https://chromium-review.googlesource.com/1556417 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: David Tolnay <dtolnay@chromium.org> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>

2019-01-23

plugin: allow retrieving and setting VM clock Add crossvm plugin API to allow reading and setting guest clock. BUG=b:122878975 TEST=cargo test -p kvm; cargo test --features=plugin Change-Id: I3fd656c06b0e7e43ac88a337ac5d0caec8c59dba Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1419373 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-07-31

plugin: allow retrieving list of supported MSRs Add crossvm plugin API to allow fetching list of supported MSRs. BUG=b:111083877 TEST=cargo test -p kvm; cargo test --features=plugin Change-Id: I178c7bc33d606bef10422faac6bb9afb3fe0a014 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1152229 Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-07-12

plugin: allow retrieving and setting VCPU events Add crosvm plugin API to allow fetching and setting VCPU events. BUG=b:110056268 TEST=cargo test --features plugin -p kvm Change-Id: Id66230f180f4bdb95bd1850ed050e439083701cc Reviewed-on: https://chromium-review.googlesource.com/1128045 Commit-Ready: Slava Malyugin <slavamn@chromium.org> Tested-by: Slava Malyugin <slavamn@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-05-19

plugin: allow retrieving and setting XCR VCPU states Add crossvm plugin API to allow fetching and setting XCRs for VCPU. BUG=b:79692549 TEST=cargo test -p kvm Change-Id: I2a988279c08051a8d8865efc1e60f9692fa26272 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1062646 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-03-30

plugin: allow retrieving and setting VM and VCPU states This change allows plugin to retrieve and set various VM and VCPU states: interrupt controller, PIT, LAPIC and MP state. BUG=b:76083711 TEST=cargo test -p kvm Change-Id: Ie32a67b0cd4a1f0a19ccd826a6e1c9dc25670f95 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/986511 Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-03-08

plugin: add crosvm_net_get_config BUG=none TEST=sudo cargo test --features plugin Change-Id: Ib38fad250295d73529dff0451345b4274a261073 Reviewed-on: https://chromium-review.googlesource.com/911943 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-03-01

allow plugin to query KVM for supported/emulated CPUIDs This plumbs calls to KVM_GET_SUPPORTED_CPUID and KVM_GET_EMULATED_CPUID to be available to plugins. TEST=cargo test --features plugin; cargo test -p kvm BUG=chromium:800626 Change-Id: I98879599b5f970c6c2720772658689a505d8abe1 Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/938674 Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-02-13

allow plugin to query for KVM extensions The guest may need to check for KVM extensions before blindly using them. TEST=cargo test --features plugin; cargo test -p kvm; ./build_test BUG=chromium:800626 Change-Id: If87b928753cd71adeabac4fc7732c3fce7265834 Reviewed-on: https://chromium-review.googlesource.com/906008 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>

add plugin support for configuring CPUID The guest expects to be able to read the CPUID, so the plugin process needs to specify what the CPUID for each VCPU will have. TEST=cargo test --features plugin; ./build_test BUG=chromium:800626 Change-Id: I9258540ab2501126c3d8cadbd09b7fc01d19f7a9 Reviewed-on: https://chromium-review.googlesource.com/906006 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>

allow non-dirty log memory regions from the plugin process Dirty logging is not necessary for every memory region, so the plugin process should be able to specific exactly which regions it would like dirty logging enabled for. TEST=cargo test --features plugin BUG=chromium:800626 Change-Id: I28b8285357e7de1c8c3a1392bdfdb4853ec5a654 Reviewed-on: https://chromium-review.googlesource.com/900294 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org>

add plugin support for model specific registers The MSRs are useful for booting a full operating system that requires them. TEST=cargo test --features plugin; cargo test -p kvm; ./build_test BUG=chromium:800626 Change-Id: I817fbf3e6868c85b373808bd48e568b5b2b458eb Reviewed-on: https://chromium-review.googlesource.com/897412 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>

add support for accessing debug registers in the plugin process The debug registers are useful to access for the plugin process in some cases. TEST=cargo test --features plugin; cargo test -p kvm; ./build_test BUG=chromium:800626 Change-Id: I8f3f6c31c6989061a43cef948cf5b4e64bd52d30 Reviewed-on: https://chromium-review.googlesource.com/896945 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>

2018-01-31

add plugin_proto crate This module defines the protocol shared between the crosvm plugin process and main crosvm process. TEST=cargo build --features plugin BUG=chromium:800626 CQ-DEPEND=CL:892048 Change-Id: I5dfbe845644b7489f1918cecfcc07f28a223aa42 Reviewed-on: https://chromium-review.googlesource.com/869355 Commit-Ready: Zach Reizner <zachr@chromium.org> Tested-by: Zach Reizner <zachr@chromium.org> Reviewed-by: Zach Reizner <zachr@chromium.org>