Proto commits in mozilla/application-services

These 52 commits are when the Protocol Buffers files have changed:

2022-01-20

Places uniffication (#4770) * initial conversion of errors for places uniffication * Converted history metadata functions for places uniffication * Converted kotlin history metadata functions * Converted iOS history metadata functions * [Places uniffication] Fix places error issues (#4687) * remove uniffi-specific wrapper and updated error test * Uniffi VisitObservation and apply_observation (#4689) * uniffied VisitObservation, HistoryVisitInfo and methods using those structs * Uniffi top frecent site info (#4711) * Uniffi top frecent site info * Uniffis FrecencyThresholdOption * Uniffi Places Sync (#4714) * uniffi places sync and sync15 functions * Uniffi Search result and match url (#4720) * Uniffi query autocomplete * uniffi places_accept_result * uniffi places_match_url * cargo fmt * cargo clippy * remove accept_result from ffi crate * Adds comment on the uniffi bug with varaint shadowing type * Uniffi Places Interrupt methods (#4726) * uniffi places interrupt functions * Consolidate types (#4736) * Updates the visit observation to use URL * Uses VisitTransition for HistoryVisitInfo * updates uniffi to 0.16 * Uniffied bookmarks * switch to use uint in the apis for adding bookmarks (#4747) * Remove the manual places FFI entirely. * folders and separators now have non-nullable parents * Always insert via Insertable items, and clarify separation between node types. * Add json_tree module with all json-based types and implementation. * Fix swift warnings re non-null parentGuid * bookmarks: Remove public_node and introduce a fetch module * Update swift code to make breaking changes fixes cleaner (#4766) * rebased and added changelog entry Co-authored-by: lougeniac64 <lougeniaC64@users.noreply.github.com> Co-authored-by: Tarik Eshaq <teshaq@mozilla.com> Co-authored-by: Mark Hammond <mhammond@skippinet.com.au>

The documentation is generated from this commit.

2021-12-23

Add support for PATCH in viaduct (#4751)

2021-11-17

UniFFI SyncManager - Replaced hand-written FFI code with UniFFI code - Updated error handling to just use thiserror. There's no need for error-support anymore. - Added an enum for the SyncParams.engine. This seems cleaner than having None mean sync all engines. - Replaced `SyncResult.results` with `SyncResult.successful` and `SyncSyncResult.failures`. Before this was handled in the Kotlin wrapaper code. - Made the megazord depend on tabs directly. Before it pulled in tabs because of a transitive dependency from sync_manager_ffi.

2021-09-13

Uniffi push component (#4431) * Adds Push UDL * [push] Rust code compiles with scaffolding * [push] removes FFI crate * [push] removes protocol buffers * [push] cleans up android api after uniffication * Removes push from protobuf_files.toml * Adds changelog

2021-09-10

Closes #4433: Allow observing previewImageUrl for visits (#4448) * Closes #4433: Allow observing previewImageUrl for visits We already have this field in moz_places; this PR adds just enough piping to allow observing preview image urls and reading them back via VisitInfo and HistoryMetadata APIs.

2021-08-03

Replace places history_metadata's protobuf implementations with uniffi. (#4183) This is intended to be a small but significant step on the road to uniffi-ing places. It takes all the hard stuff from Ryan's #3900, but limits the scope to just the new-ish history_metadata module. Co-authored-by: Ryan Kelly <ryan@rfk.id.au> Co-authored-by: Sammy Khamis <skhamis@mozilla.com>

2021-07-13

Uniffi-ing the Tabs component (#4192) * uniffi-ed the tabs component Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>

2021-06-09

Uniffi-ing the Logins component (#4068) * converting logins to using uniffi * nits and review changes * update changelog to put breaking changes on top

2021-06-01

Observation API for History Metadata Storage Switch from a crud-like API to an observation-like API for history metadata, similar to what we have in places. TitleObservation present in iOS bindings is temporary, necessary because Firefox iOS doesn't currently use places history which provides an API for noting page titles.

2021-05-06

Introduce History Metadata storage & API for Android (#4048)

2021-03-29

Allow the sync manager to accept local encryption keys to pass to engines (#3995)

2021-03-09

Restructure, UniFFI, and document the fxa-client crate. (#3876) This is a substantial refactor of the fxa-client crate, intended to bring it up to speed with our latest best-practices around developing cross-platform Rust components, in order to ease ongoing maintenance. THe core change here is that I've deleted the hand-written Kotlin and Swift bindings, replacing them with autogenerated bindings thanks to UniFFI. There is still a little bit of hand-written Kotlin, since we have a layer that automatically manages persistence via a callback. There is still a nontrivial amount of hand-written Swift, since we have a higher-level state machine built atop the lower-level fxa-client functionality (such state-machine also exists for Kotlin, but lives in the android-components repo). If UniFFI works out then we should look into moving more of that logic into shared Rust code over time. To support the introduction of UniFFI, I have restructured to Rust crate so that its public interface deliberately parallels the interface offered to Kotlin and Swift, and have moved the implementation details into a submodule named `internal`. It's my opinionated belief that structuring the crate this way will help us focus on producing a nice consumer API, which is not always the same thing as producing a nice Rust crate. On top of that, I've also revamped the documentation in the crate, leaning in to the use of `cargo doc` as the source of truth for both developer- and consumer-facing documentation. Let's consider that an experiment and see how we like it in practice. Unfortunately, this is a big PR, but I don't think I could have made it too much smaller. Hopefully it will be easier to review than its size suggests since it's mostly additions and deletions rather than complex changes.

2020-07-09

Adds optional metrics params

2020-07-08

Adds using protobufs to pass arguments

2020-05-29

Add an API to get the top frecent sites

2020-05-07

Remove cookies support from Viaduct

2020-04-08

optimize_for LITE_RUNTIME

Use swift_prefix for Swift

Replace msg_types package names

2020-03-11

Only deserialize the `active` field in oauth/introspect response

2020-03-06

Rename push SubscriptionChange MsgTypes For issue #2049.

Update verify_connection to return updated subscriptions Closes #2049 Co-authored-by: Edouard Oger <eoger@fastmail.com>

2020-02-26

De-jsonificate logins crate

2020-02-12

Add deviceId to AccountEvent.deviceDisconnected

2020-02-10

Handle all possible FxA push payloads

2020-01-22

Expose SearchResult as Protobuf through FFI

2019-12-09

Merge pull request #2165 from lyuyuan/issue-1019; r=rfk Faster visit paging with bound and offset

2019-12-04

Add FirefoxAccount.checkAuthorizationStatus() Co-authored-by: Edouard Oger <eoger@fastmail.com>

2019-12-03

Faster visit paging with bound and offset

2019-11-15

feat: return endpoint and appServerKey in dispatch_info_for_chid() (#2080) * feat: return endpoint and appServerKey in dispatch_info_for_chid() * move mostly unused appServerKey from PushConfig to an optional string in `subscribe()` (easier for customer to use) * removed unused `regenerate_endpoints()` function. * add hack to drop "empty" application keys Closes #2047

2019-11-12

Remote Tabs FFI

2019-09-17

Expand the list of client types.

Implement a clients engine in the sync manager. The clients engine handles commands for sync engines, like wiping local data and resetting Sync metadata. These are sent in a client record's `commands` list, and acked by removing the command from the list. Our implementation is based on Desktop's, but works a little differently: * Instead of holding commands in memory, ours pulls outgoing commands directly from logins and Places. This follows the approach of bookmark restore on Desktop, which writes a flag into Places to send a `wipeEngine` command on the next sync. * Our engine relies on the embedding app to supply it with info about the current client. Thanks to these two changes, our engine doesn't need to store any state itself. This means it can be used as a short-lived object that's dropped after it syncs, like our other syncable stores, and not a long-lived singleton as on Desktop.

2019-09-16

Initial implementation of the Kotlin Sync Manager API

2019-09-11

Exclude hidden URLs from syncing and views. Hidden URLs are useful for storing redirect chains, and may be useful for manual searching or awesomebar matches. However, the history record format doesn't currently include the referrer or hidden state, so we exclude them entirely to match Desktop, and to avoid cluttering other devices with redirect sources. We also filter them out in visit queries, so that Fenix doesn't have to make changes for mozilla-mobile/fenix#3526. In a future release, we can either return them and have Fenix filter them out in some views, or add a flag to include or exclude them. See #1492.

2019-08-14

Use protobufs instead of JSON in push component

2019-08-08

Add VR and TV device types

2019-06-06

Simplify viaduct error reporting, and add logging for error cases

2019-05-31

Use JSON, not protobufs for pings. This commit reverts the protobuf schema, in favor of passing the serialized ping directly. On iOS, we can pass this ping directly through to the existing ping sender. On Android, we'll need to unpack the ping into a Kotlin structure, and pass that to Fenix via Android Components. Fenix can then assemble a Glean ping from the Kotlin `SyncTelemetryPing`.

Add a protobuf representation for telemetry pings.

2019-04-22

Send Tab implementation

2019-03-23

Handle illegal header values, use `bytes` for transfer over the FFI to avoid encoding issues and copies

2019-03-21

Rename support_fetch to viaduct

Add protobufs to support_fetch

Write the rust side of an FFI for support_fetch

2019-03-19

Bookmark APIs for iOS and Kotlin and implement them using the FFI (#743) * Define conversions to/from protobuf types * Define bookmark message types * Add method of getting 'shallow' tree info * Properly provide parent/position for items * Add the rust side of the Bookmarks FFI * Kotlin bookmarks FFI * Copy xcode project over from logins to start places ios ffi * places ios: C bindings for places * protobuf setup for places ios (and docs) * Fix some things that were annoying me about BookmarkRootGuid, and move it to it's own file * Add a bookmarks FFI function to return all bookmarks with the requested URL * Clean up leftover logins stuff in places ios * Implement swift bookmarks API * Fix bad comment and missing null check in kotlin bookmarks * Try and add places to the iOS megazord (hit issue with msg_types name collision) * Rename msg_types to be unique, finish integration with iOS megazord * Finish documenting how to pass protobuf data back and forth for swift * Comment tweak and change canEdit -> isRoot * Small tweaks to the swift API (some renaming, change class => struct, etc) * Don't require type in update (since it can't be changed), and handle errors better * Undo struct -> class change since it subtly broke things * Respond to feedback from justin * Allow requesting a only the first level of folder children * connUseAfterApiClosed -> connUseAfterAPIClosed * WIP iOS tests * Make iOS tests build * Improve path handling for iOS * Fix megazord test setup and document the weird testing steps that were needed * Fix failing iOS tests * Move protobuf-returning functions into their own file * Add searchBookmarks function * Use a sealed class and data classes in the kotlin API * Require that callers of getBookmarksTree pass in the root and whether or not to fetch recursively, rather than using the most expensive possible default * rename deleteBookmark => deleteBookmarkNode * Use InterruptScope in the reader bookmark methods * Fix rebase issue * Allow interrupt() on iOS * Use changes from #788 to make places xcode project build much faster * Change `extern` to `public`, use fewer protobuf types in the rust because they make testing it painful * More tests of new rust code * Expose relevant errors over the FFI, and document them (also, fix the kotlin doc formatting) * fix 'its' being wrong basically everywhere * Fix many doc typos * Use FfiStr in bookmarks * Fix doc nit * Make missing titles come through as '' for better API consistency * Tests for the rest of the new rust functions * Clarify doc nit * Changelog entry for bookmark ffi * Expose runMaintenance to Swift * Handle NoItem => NoSuchGuid * Rename places::storage::bookmarks::public to places::storage::bookmarks::public_node * Lina's review feedback

2019-03-14

Move everything under org.mozilla.appservices

2019-02-25

Return AccessTokenInfo using protobufs

Move package to mozilla.appservices.fxaclient

2019-02-15

Pre: rename ffi_types to msg_types

Finish up using protobufs in places, and document everything

2019-02-13

Use protobuf for fxa_profile return value