These commits are when the Protocol Buffers files have changed: (only the last 100 relevant commits are shown)
| Commit: | 80c7d6d | |
|---|---|---|
| Author: | Brandon Hopkins | |
| Committer: | GitHub | |
[misc] Call the NetBird client "client" instead of "agent" (#8678)
| Commit: | 40a0543 | |
|---|---|---|
| Author: | jnfrati | |
| Committer: | jnfrati | |
Merge branch 'jnfrati/agent-network-info' into jnfrati/agent-network-usage Brings in the NO_USER removal. The conflicting *.pb.go files were regenerated from the merged protos with the repo's generate.sh, protoc version headers kept.
| Commit: | e61ced0 | |
|---|---|---|
| Author: | jnfrati | |
[management,client] Remove the NO_USER Agent Network info state No released management server has GetAgentNetworkInfo, and since d082bd4a8 management answers a setup-key peer from its peer groups with OK, so nothing sends NO_USER. A released server without the RPC answers Unimplemented, which the daemon already reports as MANAGEMENT_UNSUPPORTED. Keeping the value only carried dead branches in every client. The value is removed from both enums and the rest renumbered contiguously without reserving 2: OK=1, NOT_ENABLED=2, USER_BLOCKED=3, and in the daemon proto MANAGEMENT_UNSUPPORTED=4. Only pre-release builds of this branch ever spoke the old numbers. The daemon relay mapping and its test case go with it. Generated code regenerated with the repo's generate.sh and pinned plugins, with the protoc version headers kept as they were.
| Commit: | 24a145c | |
|---|---|---|
| Author: | jnfrati | |
[management,client] Describe which caps AgentNetworkProvider.limits lists The comment said limits lists every cap that binds the caller on the provider. providerAllowance lists the caps of every account rule that binds the caller plus only the policy the selector would book the next request against, not every applicable policy's caps. The comment now says that. Comments only: generated code regenerated with the repo's generate.sh and pinned plugins, with the protoc version headers kept as they were.
| Commit: | 584a5d8 | |
|---|---|---|
| Author: | jnfrati | |
Merge remote-tracking branch 'origin/jnfrati/agent-network-info' into jnfrati/agent-network-usage
| Commit: | 9e13e5d | |
|---|---|---|
| Author: | jnfrati | |
[management,client] Correct Agent Network info proto comments Since d082bd4a8 management answers a setup-key peer from its peer groups with OK, so the NO_USER comment describing it as the state such a peer gets was wrong. The value stays in both enums so clients still decode it from older management servers; the comment now says that. The endpoint comment named the labeled "<label>.<cluster>" shape only, but a dedicated proxy serves the account at its own hostname. It now describes the URL as https plus the account's gateway hostname and notes it is set only with OK, which is when the server fills it. Comments only: generated code regenerated with the repo's generate.sh and pinned plugins, with the protoc version headers kept as they were.
| Commit: | a224b06 | |
|---|---|---|
| Author: | Mikita Pakatovich | |
| Committer: | Mikita Pakatovich | |
[client] Show the aligned heartbeat in status and export it on mobile Status and the bundle carry the per-stream heartbeat state. Android and iOS expose the sleep and wake calls of the watcher.
| Commit: | a0186d2 | |
|---|---|---|
| Author: | Mikita Pakatovich | |
| Committer: | Mikita Pakatovich | |
[management,signal] Add the aligned heartbeat proto fields Peer capability, Sync request and peer config, the Sync heartbeat, and the Signal server heartbeat and phase request messages. Fields are only added, so old peers keep working as stock.
| Commit: | 8b0a6da | |
|---|---|---|
| Author: | jnfrati | |
Merge remote-tracking branch 'origin/jnfrati/agent-network-setup-gui' into jnfrati/an-setup-gui # Conflicts: # client/proto/daemon.pb.go # shared/management/proto/management.pb.go
| Commit: | 283a708 | |
|---|---|---|
| Author: | jnfrati | |
Merge remote-tracking branch 'origin/jnfrati/agent-network-usage' into jnfrati/agent-network-usage # Conflicts: # client/proto/daemon.pb.go # shared/management/proto/management.pb.go
| Commit: | e937b95 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-setup-harnesses' into jnfrati/agent-network-setup-gui Only generated code conflicted (shared/management/proto/management.pb.go ); regenerated with the repo's generate.sh, gofmt'd, protoc header kept as on main.
| Commit: | 66fb48b | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-info' into jnfrati/agent-network-usage Only generated code conflicted (shared/management/proto/management.pb.go ); regenerated with the repo's generate.sh, gofmt'd, protoc header kept as on main.
| Commit: | 7152e72 | |
|---|---|---|
| Author: | jnfrati | |
Merge origin/main into jnfrati/agent-network-info Picks up cb5b630b5 (#8382). Only shared/management/proto/management.pb.go conflicted; the .proto merged cleanly (main added PeerCompact.login_expired = 15, unrelated to GetAgentNetworkInfo, whose numbers are unchanged). Regenerated with the repo's generate.sh, gofmt'd, protoc header kept as on main.
| Commit: | cb5b630 | |
|---|---|---|
| Author: | Pascal Fischer | |
| Committer: | GitHub | |
[management] security hardening for network map (#8382) * security hardening for network map * exclude expired peers * Cover login-expired pruning in tests, equivalence and goldens, and split SSH/expiry helpers * Drop emptied network-resource route firewall rules in nmapequiv legacy prune * Apply blocked AuthorizedUser check to envelope SSH flag and recompute legacy empty flags after prune * include login_expired flag
| Commit: | 0bc1ac7 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-setup-harnesses' into jnfrati/agent-network-setup-gui Brings in origin/main through info -> setup -> harnesses. - client/ui/i18n/locales/en/common.json: both sides appended keys at the end of the file (ours: agentNetwork.* usage and harness strings, main: profile.ownedByAnother.*, error.* daemon refusals). Kept both sets. - client/proto/daemon.pb.go, shared/management/proto/management.pb.go: regenerated with the repo's generate.sh; the .proto files merged cleanly and GetAgentNetworkInfo numbers are unchanged. - management/internals/modules/agentnetwork/allowance.go: adapted to main's new checkAccountBudget/scoreCandidates signatures (#8460), the same change made on agent-network-usage, so this commit builds on its own and the usage merge that follows applies cleanly.
| Commit: | f087d26 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-info' into jnfrati/agent-network-usage Brings in origin/main through agent-network-info. - client/ui/i18n/locales/en/common.json: both sides appended keys at the end of the file (ours: agentNetwork.*, main: profile.ownedByAnother.*, error.privilege_required/session_held/not_profile_owner/profile_unowned). Kept both sets. - client/proto/daemon.pb.go, shared/management/proto/management.pb.go: regenerated with the repo's generate.sh; the .proto files merged cleanly. GetAgentNetworkInfo numbers unchanged (state 1, endpoint 2, providers 3, limits 9, resets_at 10). - management/internals/modules/agentnetwork/allowance.go: main (#8460) changed checkAccountBudget to return *PolicySelectionResult (nil = no deny) and scoreCandidates to return (scored, lastDenied). Adapted the two allowance call sites; they only read the deny flag and the scored list, so behavior is unchanged.
| Commit: | f3181ee | |
|---|---|---|
| Author: | jnfrati | |
Merge origin/main into jnfrati/agent-network-info Only generated code conflicted: client/proto/daemon.pb.go and shared/management/proto/management.pb.go. The .proto sources merged cleanly with no number clash (main added ClaimProfile, Profile.owners = 4 and PeerSystemMeta.sysHardwareUUID = 21; GetAgentNetworkInfo numbering is unchanged). Both files, and daemon_grpc.pb.go, were regenerated with the repo's generate.sh (pinned protoc-gen-go/-grpc/-gateway), gofmt'd, and the protoc version header kept as on main to avoid churn.
| Commit: | 922af7f | |
|---|---|---|
| Author: | Mikita Pakatovich | |
| Committer: | Mikita Pakatovich | |
[client] Show the aligned heartbeat in status and export it on mobile Status and the bundle carry the per-stream heartbeat state. Android and iOS expose the sleep and wake calls of the watcher.
| Commit: | bcd4681 | |
|---|---|---|
| Author: | Mikita Pakatovich | |
| Committer: | Mikita Pakatovich | |
[management,signal] Add the aligned heartbeat proto fields Peer capability, Sync request and peer config, the Sync heartbeat, and the Signal server heartbeat and phase request messages. Fields are only added, so old peers keep working as stock.
| Commit: | 48c7c29 | |
|---|---|---|
| Author: | Viktor Liu | |
Send source prefixes and suppress the inverse masquerade for site to site peer ACLs
| Commit: | 04abcdb | |
|---|---|---|
| Author: | jnfrati | |
[management,client] Stop sending the source and scope of Agent Networks limits Nothing reads them once the desktop tooltip is gone, so the peer no longer learns policy, rule and group names it has no use for, and management skips the group lookup. A limit is now its unit, cap, usage and reset time. The CLI table loses its LIMIT and APPLIES TO columns.
| Commit: | 5fbc257 | |
|---|---|---|
| Author: | pascal | |
Merge remote-tracking branch 'origin/main' into fix/network-map-hardening # Conflicts: # management/internals/network_map_db/pgsql/peer.go # management/internals/network_map_db/shared_types.go # management/internals/network_map_db/sqlite/peer.go # management/server/user.go # shared/management/proto/management.pb.go
| Commit: | 7ef0fef | |
|---|---|---|
| Author: | riccardom | |
Merge branch 'main' into feat-post_quantum_ml_kem
| Commit: | 2ffe39b | |
|---|---|---|
| Author: | riccardom | |
Merge origin/main into peer_auth_signal_relay Resolve the relay store against closing the replaced peer outside the lock, the peer query against the hardware UUID column, regenerate management.pb.go, and move the peer auth tests to the renamed combined config helper.
| Commit: | 4689238 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-setup-harnesses' into jnfrati/an-setup-gui
| Commit: | 88c84d2 | |
|---|---|---|
| Author: | jnfrati | |
[client,management] Renumber the Agent Networks usage fields contiguously Dropping the provider's and the limit's unshipped fields left number 9 unused on AgentNetworkProvider and 10 and 11 unused on AgentNetworkLimit. The RPC is unreleased, so nothing speaks the old numbering and the gaps would only be noise in a new message. AgentNetworkProvider.limits moves from 10 to 9, following on from the fields the info branch defines (1..6) and unlimited and exhausted (7, 8). AgentNetworkLimit.resets_at moves from 12 to 10, so that message runs 1..10. Order is unchanged, no numbers are reserved, and daemon.proto is renumbered in step with management.proto. Regenerated with the versions already in the headers: protoc v6.33.1 and protoc-gen-go v1.36.6 for daemon, protoc v7.34.1 and protoc-gen-go v1.26.0 for management.
| Commit: | f696992 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-info' into jnfrati/agent-network-usage
| Commit: | f9894fd | |
|---|---|---|
| Author: | jnfrati | |
[client,management] Renumber GetAgentNetworkInfoResponse fields contiguously Dropping user_email, login_expired and computed_at left numbers 2, 4 and 5 unused on GetAgentNetworkInfoResponse, in both management.proto and daemon.proto. Nothing on this RPC has been merged or released, so no client or server exists that speaks the old numbering, and there is no reason to ship a brand new message with holes in it. endpoint moves from 3 to 2 and providers from 6 to 3, so the fields run 1..3 in their existing order and the next free number is 4. The old numbers are not reserved: they were never on the wire. The daemon message mirrors the management one and is renumbered the same way. Regenerated with the versions already in the headers: protoc v6.33.1 and protoc-gen-go v1.36.6 for daemon, protoc v7.34.1 and protoc-gen-go v1.26.0 for management.
| Commit: | e30e2ef | |
|---|---|---|
| Author: | pascal | |
Merge remote-tracking branch 'origin/main' into fix/proxy-status-report
| Commit: | 8ffee26 | |
|---|---|---|
| Author: | jnfrati | |
[client,management] Trim the usage fields of GetAgentNetworkInfo and read the email from the profile GetAgentNetworkInfo should carry only what the client cannot get elsewhere, so three more fields go: providers[].exhausted_reason and limits[].window_start / window_seconds. No renderer used them; resets_at stays and is all the countdown needs. The deny reason was never logged on the management side, so the allowance no longer computes it either. Field numbers of the remaining fields are unchanged. The consumers of the fields removed on the info branch move to what the client already has: The CLI and the GUI take the email from the active profile's state file, which the SSO login writes. It can be empty, e.g. after a login under sudo or on a profile that never used SSO. The CLI header then reads "Agent Networks usage" without "for <email>". `netbird agent-network usage --json` keeps the user_email key, now fed from the profile and placed first. An empty email is omitted, as protojson already does for every unset field. Reset countdowns use the local clock instead of computed_at. The login-expired warning is gone from the CLI and the GUI. It could never show: an expired peer does not reach this RPC through the daemon.
| Commit: | c1038d9 | |
|---|---|---|
| Author: | jnfrati | |
Merge branch 'jnfrati/agent-network-info' into jnfrati/agent-network-usage Brings in the removal of user_email, login_expired and computed_at from GetAgentNetworkInfo. The generated proto files conflicted and were regenerated from the merged .proto files with the base protoc versions. The consumers on this branch that still read the removed fields are fixed in the next commit.
| Commit: | 1259094 | |
|---|---|---|
| Author: | jnfrati | |
| Committer: | jnfrati | |
[client,management] Drop user_email, login_expired and computed_at from GetAgentNetworkInfo GetAgentNetworkInfo should carry only what the client cannot get elsewhere. The three fields fail that test: user_email duplicates the email the client already stores in the active profile state after an SSO login. login_expired can never be observed as true through the daemon. When a peer's login expires, management closes its stream, the client moves to NeedsLogin and the daemon relay answers FailedPrecondition before the RPC is sent. computed_at was only the server clock at answer time. Consumers use the local clock instead. The field numbers of the remaining fields are unchanged, since test builds with the current numbers are deployed. Generated code was rebuilt with protoc 33.1 for daemon.proto and 34.1 for management.proto, the versions the base files carry.
| Commit: | e1c375f | |
|---|---|---|
| Author: | Dmitri Dolguikh | |
Merge remote-tracking branch 'origin/main' into dmitri-disabled-proxy Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>
| Commit: | 09b304e | |
|---|---|---|
| Author: | Dmitri Dolguikh | |
| Committer: | Dmitri Dolguikh | |
handle removal/disabling of proxy mappings Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>
| Commit: | 16de8a2 | |
|---|---|---|
| Author: | jnfrati | |
[proxy] Render the unknown-host page for concealed private 404s A refused private service answered 404 in plain text while an unknown host gets the HTML error page, so the body told the two apart. The private 404 now renders the same page. The has_private_access comment also states that Agent Network gateways answer 401 whatever the field says.
| Commit: | 103fea5 | |
|---|---|---|
| Author: | jnfrati | |
[proxy,management] Return 404, 403 or 401 for refused private service requests Every refusal of a private service was a 403, which confirms the service exists to callers that cannot reach it and gives Agent Networks users no hint that a policy is missing. The proxy now answers 404 to callers outside the account's overlay and to peers with no private access, 403 to peers that can reach another private service, 401 to peers outside the Agent Networks policies, and 503 when management cannot be asked. Management reports whether a refused peer reaches another private service in a new has_private_access field. Which requests are allowed does not change.
| Commit: | 5edc265 | |
|---|---|---|
| Author: | Riccardo Manfrin | |
| Committer: | GitHub | |
[client, management] Report the device hardware UUID in the peer system meta (#8541) * [client] Report the hardware UUID in the peer system meta Many machines ship an empty or placeholder serial, so the serial alone cannot match a peer to its Fleet host; the SMBIOS UUID is the identifier osquery reports as system_info.uuid. * [management] Store the peer hardware UUID in the peer system meta The Fleet integration needs it to match peers whose serial is missing or a placeholder. * [client] Read the Windows product name and hardware UUID in one WMI query The two values come from the same Win32_ComputerSystemProduct row, so a second query only added startup latency. * [client] Test the macOS IOPlatformUUID parsing Covers malformed and look-alike ioreg lines, which the UUID cleaning tests did not reach.
| Commit: | 93896ae | |
|---|---|---|
| Author: | Viktor Liu | |
Merge branch 'main' into reverse-proxy-crowdsec-appsec # Conflicts: # infrastructure_files/getting-started.sh # management/server/store/sql_store.go # proxy/cmd/proxy/cmd/root.go # proxy/internal/auth/middleware.go # proxy/internal/auth/oidc.go # proxy/lifecycle.go # proxy/server.go # shared/management/proto/proxy_service.pb.go
| Commit: | 32e48ff | |
|---|---|---|
| Author: | Viktor Liu | |
Merge branch 'main' into embedded-vnc
| Commit: | e527f22 | |
|---|---|---|
| Author: | Viktor Liu | |
Merge branch 'main' into notification-localization # Conflicts: # client/proto/daemon.pb.go
| Commit: | 2d3c816 | |
|---|---|---|
| Author: | Theodor Midtlien | |
| Committer: | GitHub | |
[client] Add profile ownership and IPC authz (#7407) Adds an authorization layer on daemon IPC and profile ownership, both based on kernel provided identification of system users. Adds NB_DISABLE_PROFILE_OWNERSHIP and NB_DISABLE_DEFAULT_PROFILE_CLAIM to configure behavior. Breaking: Deprecates TCP support for daemon IPC. Performing up or claiming the default profile on headless machines requires sudo/administrator privileges (or same privs as the daemon process on rootless setup) once on migration and new installs. * Add an optional --allow-group flag restricting the daemon sockets (#7478) * [client] Profile ownership migration (#7508) * [client] Profile ownership console user tofu (#7529) * [Client] Surface readable Authz errors and add profile claim command (#7540) * [client] Surface error messages for IPC authz in UI (#7553) * [client] Improve error surfacing for restricted daemon sockets (#7704) --------- Co-authored-by: Viktor Liu <17948409+lixmal@users.noreply.github.com>
| Commit: | dbdf228 | |
|---|---|---|
| Author: | jnfrati | |
[management,client] Report the caller's Agent Networks allowance per provider A user cannot see how much of their Agent Networks allowance is left until the proxy starts denying requests. GetAgentNetworkInfo now carries, per provider, every cap that binds the calling peer: policy caps and account budget rules, each as its own limit (tokens and USD are never folded together), with the consumption in the current epoch-aligned window and when it resets, plus unlimited and exhausted flags. The answer must match enforcement, so it is computed from the peer's own groups and its owner as principal, the same inputs ValidateTunnelPeer hands the proxy, and it runs the selector's own steps: the applicable policies, the account ceiling, candidate scoring, and one batched consumption read. evalTokenCap and evalBudgetCap now sit on tokenCapUsages and budgetCapUsages, so the usage rows and the deny decision come from one primitive instead of two copies. The model gate is skipped: there is no request model here, and its empty-model rule would mark every allowlisted provider exhausted. Behind a catch-all policy only account rules bind, because the uncapped policy wins selection and books nothing against policy windows; that is what unlimited means. A parity test drives shared fixtures through both paths after each spend and asserts exhausted == !Allow. Proto changes add fields 7-10 to AgentNetworkProvider and a new AgentNetworkLimit message in management.proto and the daemon mirror, regenerated with the versions in each file's header (protoc 34.1 and 33.1).
| Commit: | 0f307ac | |
|---|---|---|
| Author: | jnfrati | |
[client] Relay GetAgentNetworkInfo through the daemon The CLI and the desktop UI talk to the daemon, not to management, so the new management RPC needs a daemon counterpart before either can show Agent Networks availability, the endpoint, or the providers. The daemon handler follows ExposeService: FailedPrecondition while the client is not running, then a call through a small engine accessor over the existing management client. A management that answers Unimplemented predates the RPC, so the daemon reports MANAGEMENT_UNSUPPORTED as a state rather than an error and the UI can render it like the others. The handler takes no caller input and returns only what management already scopes to this peer. The daemon messages mirror the management ones instead of importing management.proto, matching how daemon.proto keeps its own types.
| Commit: | d44e3e8 | |
|---|---|---|
| Author: | jnfrati | |
[management] Add GetAgentNetworkInfo peer RPC Clients need to tell a user what Agent Networks gives them on this machine: whether it is available, the endpoint, and which providers and models they may use. The REST agent-config answer is computed from the user's auto-groups, but the proxy authorizes tunnel requests by the calling peer's groups, so the two can disagree. The new peer-authenticated RPC computes the answer from the peer's own groups and its owning user, reusing agentConfigForGroups so it cannot drift from the REST logic. States: NO_USER for setup-key peers, NOT_ENABLED without an Agent Network, USER_BLOCKED when the owner is blocked or pending approval (mirroring the proxy owner gate). An expired login still gets its data with login_expired set so the client can prompt for netbird up. An owner resolved in another account is refused rather than answered. The handler follows the expose RPCs: decrypt with the peer key, resolve the peer from the key (unknown key is PermissionDenied), and answer Unimplemented while no service is wired, which clients read as an older management. The misleading agent-config comment that claimed user and peer groups match is corrected; the REST behaviour is unchanged.
| Commit: | 98dbdea | |
|---|---|---|
| Author: | pascal | |
Write proxy status reports only when they change
| Commit: | 9ec583f | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[client] Report the hardware UUID in the peer system meta Many machines ship an empty or placeholder serial, so the serial alone cannot match a peer to its Fleet host; the SMBIOS UUID is the identifier osquery reports as system_info.uuid.
| Commit: | 21e400d | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Add the peer auth key and auth token fields Carries the peer signing key to Management and the single opaque token for Signal and Relay back, additive so older peers, Management, Relay and Signal ignore them.
| Commit: | ebe7437 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
| Committer: | Theodor S. Midtlien | |
Resolve and send principal to daemon for a profile claim
| Commit: | 9bdc268 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Add the peer auth key and auth token fields Carries the peer signing key to Management and the single opaque token for Signal and Relay back, additive so older peers, Management, Relay and Signal ignore them.
| Commit: | f6ad2e0 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Re-align the proof clock on every Sync The monotonic clock does not count a suspend, so after a resume the proof clock lags until the next login. Every Sync now carries Management time and re-aligns it.
| Commit: | d6bb9c9 | |
|---|---|---|
| Author: | pascal | |
include login_expired flag
| Commit: | 9bd8054 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Re-align the proof clock on every Sync The monotonic clock does not count a suspend, so after a resume the proof clock lags until the next login. Every Sync now carries Management time and re-aligns it.
| Commit: | edd5108 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Sign Signal and Relay proofs on Management time A peer whose clock is off by more than the verifier skew would be refused by Signal and Relay; Management's time at login gives every peer the same reference. Elapsed time since is measured on the monotonic clock, so a later step of the local clock does not move it.
| Commit: | d18436f | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Add the peer auth key and auth token fields Carries the peer signing key to Management and the single opaque token for Signal and Relay back, additive so older peers, Management, Relay and Signal ignore them.
| Commit: | 4102b0b | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Re-align the proof clock on every Sync The monotonic clock does not count a suspend, so after a resume the proof clock lags until the next login. Every Sync now carries Management time and re-aligns it.
| Commit: | da925b9 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Sign Signal and Relay proofs on Management time A peer whose clock is off by more than the verifier skew would be refused by Signal and Relay; Management's time at login gives every peer the same reference. Elapsed time since is measured on the monotonic clock, so a later step of the local clock does not move it.
| Commit: | 256d9c3 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Add the peer auth key and auth token fields Carries the peer signing key to Management and the single opaque token for Signal and Relay back, additive so older peers, Management, Relay and Signal ignore them.
| Commit: | 4a6ed02 | |
|---|---|---|
| Author: | pascal | |
report unavailable peers through nmap
| Commit: | c027d88 | |
|---|---|---|
| Author: | Viktor Liu | |
Merge remote-tracking branch 'origin/main' into HEAD # Conflicts: # shared/management/proto/proxy_service.pb.go
| Commit: | 0a17d1a | |
|---|---|---|
| Author: | Viktor Liu | |
Merge remote-tracking branch 'origin/main' into embedded-vnc # Conflicts: # client/cmd/up.go # client/internal/engine.go # client/internal/profilemanager/config.go # client/proto/daemon.pb.go # client/server/mdm.go # client/server/server.go # client/status/status.go # client/ui/main.go # client/ui/services/windowmanager.go # management/internals/shared/grpc/conversion.go # management/server/store/sql_store.go # management/server/store/sql_store_test.go # shared/management/networkmap/envelope.go # shared/management/proto/management.pb.go
| Commit: | 6cba403 | |
|---|---|---|
| Author: | riccardom | |
Merge remote-tracking branch 'origin/main' into feat-post_quantum_ml_kem # Conflicts: # client/internal/peer/status.go # client/status/status.go
| Commit: | 62fbca1 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
Merge branch 'main' into profile-ownership
| Commit: | 34ed17f | |
|---|---|---|
| Author: | pascal | |
show ssh accessible peers
| Commit: | 1161616 | |
|---|---|---|
| Author: | Maycon Santos | |
| Committer: | GitHub | |
[proxy] Enforce per-target HTTP access actions (#8115) Apply target access before service authentication: inherit, bypass, or block. Keep route selection and auth decisions on the same snapshot; reject stale or unavailable required middleware. Validation: full auth/proxy race tests and scoped lint passed. Runtime regression tests remain with this layer.
| Commit: | 2448eb0 | |
|---|---|---|
| Author: | riccardom | |
Merge remote-tracking branch 'origin/main' into fix_debug_upload_url_from_mgmt # Conflicts: # shared/management/proto/management.pb.go
| Commit: | 53a1455 | |
|---|---|---|
| Author: | Pascal Fischer | |
| Committer: | GitHub | |
[client, management] implement certificate posture check (#7535) Co-authored-by: mlsmaycon <mlsmaycon@gmail.com>
| Commit: | 296bdc2 | |
|---|---|---|
| Author: | riccardom | |
Merge remote-tracking branch 'origin/main' into fix_debug_upload_url_from_mgmt # Conflicts: # client/proto/daemon.pb.go # management/internals/controllers/network_map/controller/controller.go # management/internals/controllers/network_map/nmaptest/runner.go # management/internals/shared/grpc/server.go # management/server/account.go # shared/management/proto/management.pb.go # upload-server/server/server.go
| Commit: | cac6cba | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Carry the debug upload destination on PeerConfig A destination set from the dashboard never reached a connected peer. The peer fan-out that follows a settings change builds its sync with a nil server config, and toNetbirdConfig returns nil for that, so no NetbirdConfig went out at all and the peer kept whatever it had. The new URL only arrived when the peer reconnected, and until then its bundles kept going to NetBird's upload service — which is the disclosure this PR exists to close. PeerConfig is the message the fan-out already fills from the account settings, alongside the other knobs an operator flips at runtime: lazy connection, MTU, routing-peer DNS resolution, auto-update. The destination belongs with them. Sending a partial NetbirdConfig from the fan-out instead would be worse: clients treat a non-nil one as authoritative for relay and would drop their relay URLs. Start now reads the destination off the PeerConfig it was given in the previous commit, for the same reason it used to read it off NetbirdConfig: without it, a bundle collected between login and the first sync sees no destination, and the first seconds after a start are exactly when someone collects a bundle about a start that went wrong. DebugConfig is removed rather than deprecated. It was added earlier in this branch and has never been in a release, so no deployed client reads it.
| Commit: | 3af4939 | |
|---|---|---|
| Author: | Viktor Liu | |
| Committer: | Viktor Liu | |
Merge main into poc/certificate-posture
| Commit: | 515a01d | |
|---|---|---|
| Author: | Zoltan Papp | |
| Committer: | GitHub | |
[client] Force interactive login when extending the auth session (#7216) * [client] Force interactive login when extending the auth session A session extend must be answered from the account the peer is registered under. With a silent PKCE flow (DisablePromptLogin or max_age=0) the IdP answers from whatever session it already holds, which need not be the peer's account when several are signed in; the token then fails the user match in ExtendAuthSession with no way to pick another account. Mark the PKCE flow request as a session extend so the management server can force prompt=login for it, overriding the configured silent flow. * [client] Reduce cognitive complexity of Server.Login Login sat at cognitive complexity 27, over the 25 the linter allows. Extract the interactive SSO branch into startSSOLogin, and split the nested in-flight-flow reuse check out of it into reuseOAuthFlow, which flattens the original if/else into early returns: it returns the cached auth info when the previous flow targets the same client and still has more than 90s left, otherwise cancels the stale wait and returns nil so the caller requests a fresh flow. The helpers take the contextState through a small statusSetter interface, since internal.contextState is unexported and re-deriving it with CtxGetState inside the helper would resolve against callerCtx rather than rootCtx. No behavior change: same ordering of state transitions, same mutex scope around the oauthAuthFlow write, same error paths. Login is now at 21. * [client] Respect DisablePromptLogin when extending the auth session Forcing prompt=login on a session extend overrode DisablePromptLogin, which is set for IdPs that break on it: Authentik triggers a double authentication and social logins fail outright. Overriding it there trades a recoverable extend for a login that cannot complete at all. Keep the LoginFlag override, which only replaces max_age=0 or none with prompt=login so the IdP honours login_hint, and leave DisablePromptLogin as configured. Those deployments keep the silent flow, and with several accounts signed in an extend answered from the wrong one still fails the user match. * [client] Guard the shared OAuth flow state with the server mutex reuseOAuthFlow read flow, expiresAt, waitCancel and info without holding s.mutex, while startSSOLogin and WaitSSOLogin write them under it. Reading the fields one at a time could also answer with auth info from a flow that was already replaced, or cancel a wait that no longer belongs to the flow just judged stale. Take one snapshot under the lock and decide from it. WaitSSOLogin read oauthAuthFlow.flow twice outside the lock; both now use a value snapshotted in the critical section that already installs actCancel. Its stale waitCancel was read and called in a separate section from the one installing the new one, so two racing calls could read the same predecessor and leave one wait uncancelled. Swap the two in a single critical section. Both cancels run after unlocking: the displaced wait takes s.mutex as it unwinds. * [client] Verify the SSO login came back for the hinted account login_hint is a suggestion the IdP may ignore: with a silent flow configured (DisablePromptLogin or max_age=0) and a live IdP session for another account, the login completes with that account's token. On a registered peer the management server rejects it as a user mismatch, but on a fresh profile the peer silently registers under the wrong account and the profile is then bound to it — every later login follows the stored hint straight back. After the token exchange, compare the ID token's email against the hint the flow was sent with. On a mismatch, do not log in to management with the token; run one more round asking the IdP to re-decide the account (prompt=login, via ForceAccountPrompt — DisablePromptLogin still wins there). If the prompted round also comes back different, proceed with a warning: the address may legitimately have changed, and refusing forever would lock the user out of the profile while the management server still rejects a token that does not own the peer. A token or profile with no email to compare is not judged. The retry differs per platform because of who opens the browser: - CLI (netbird login foreground) and Android run the whole flow in one process, so the mismatch retries automatically: the browser reopens with the account prompt within the same login attempt. - On desktop the login is split between the daemon and the GUI: Login hands the authorize URL to the GUI, WaitSSOLogin blocks for the token, and only the GUI can open a browser. A new URL cannot be handed out from inside WaitSSOLogin (its response has no field for one, kept that way to avoid a proto change), so the daemon arms forceAccountPrompt, fails the round with "connect again to choose the account", and builds the next Login's flow with the prompt — the user's next connect is the retry. The flag and the flow annotations live in daemon memory only; SwitchProfile drops them so the previous profile's hint cannot judge the next profile's token. The device code flow has no prompt parameter (RFC 8628), so a prompted round there runs as-is and a repeated mismatch is let through with the warning rather than looping. * [client] Address review comments on PKCE session extend flow Fail the PKCE authorization flow test on request error instead of continuing into a nil dereference, and make the godoc comments on the touched exported symbols identifier-leading full sentences. * [client] Match accounts only on the email claim of the ID token The name-claim fallback in the ID token parsing is kept for the login hint and display, but account matching now only considers a value that came from the email claim, so a token without one no longer produces a false account mismatch. * [client] Drop the pending session extend on a profile switch The profile-switch cleanup dropped the pending login flow and the account-prompt flag, but left extendAuthSessionFlow untouched. Its device code was issued by the previous profile's IdP client, so a WaitExtendAuthSession still parked on the browser leg would submit the resulting token against the new profile's engine. * [client] Judge the SSO account against the flow that produced the token WaitSSOLogin snapshotted the flow on entry but re-read the info, hint and accountPrompted from the live s.oauthAuthFlow afterwards, in separate critical sections. WaitToken blocks for the whole browser leg, so a concurrent Login or RequestJWTAuth could replace the flow meanwhile and the mismatch check would compare this wait's token against another flow's account: either arming the prompt spuriously or letting a wrong-account token through against an unrelated profile's hint. Take all of it in the entry snapshot. * [client] Keep the forced account prompt from being lost to flow reuse startSSOLogin consumed forceAccountPrompt and applied the prompt to the freshly built flow, but reuseOAuthFlow could then answer from a cached flow for the same client — one built without prompt=login, e.g. by RequestJWTAuth. The user got the same silent authorization URL that produced the mismatch, with the flag already spent, so no later round asked either. Rule reuse out when the prompt is forced, while still cancelling the predecessor's wait. RequestJWTAuth also wrote the flow fields one by one, leaving the previous login's hint and accountPrompted behind for WaitSSOLogin to judge a later token against. Both sites now replace the whole record. * [client] Consume the forced account prompt after the retry forceAccountPrompt was never cleared, so a flow that outlived the retry it was armed for kept sending prompt=login on every later authorization request and re-authenticated the user each time. RequestAuthInfo now takes the flag as it builds the request. * [client] Cancel the caller context in the SSO login tests WaitSSOLogin parks a goroutine on the caller's context for the whole browser leg. The tests passed context.Background(), which never cancels, so each left one goroutine behind for the lifetime of the test binary. * [client] Cancel the wait displaced by an OAuth flow replacement Replacing the shared record with a whole struct value dropped the previous flow's waitCancel, so an SSO browser wait still parked on it lost its cancel: nothing could preempt it, and it could go on to run attemptLogin or mutate the record behind the new flow. Both replacement sites now take the displaced cancel over in the same critical section, via a shared replaceOAuthFlow, and invoke it after the unlock. * [client] Guard OAuth flow mutations by the flow that owns the wait * [client] Arm the account prompt only from the wait that owns the flow * [client] Adopt the three-value parseEmailFromIDToken in the device flow The main merge brought in the device flow's email extraction from #7193, which still used the two-value signature this branch replaced when account matching was narrowed to the email claim. Git merged the files without a textual conflict, so the branch stopped compiling. Take the fromEmailClaim result and fill EmailClaim from it, the same way the PKCE path does, so device-flow clients get the same account matching. * [client] Populate the pending extend flow in the test server helper SwitchProfile cancels and clears the pending session extend flow unconditionally, the same way it clears the SSH JWT cache. New always populates the field, but the hand-assembled test server did not, so TestSwitchProfile_ClearsJWTCache panicked on a nil PendingFlow.
| Commit: | fb7ac2c | |
|---|---|---|
| Author: | Maycon Santos | |
| Committer: | GitHub | |
[proxy] Enforce per-target HTTP access actions
| Commit: | 1aadbf2 | |
|---|---|---|
| Author: | Maycon Santos | |
| Committer: | GitHub | |
[proxy] Enforce per-target HTTP access actions
| Commit: | be05d21 | |
|---|---|---|
| Author: | Maycon Santos | |
| Committer: | GitHub | |
Merge branch 'main' into feature/reverse-proxy-target-access-control
| Commit: | c8fe901 | |
|---|---|---|
| Author: | Zoltán Papp | |
Merge remote-tracking branch 'origin/main' into fix/pkce-flow-session-extend # Conflicts: # shared/management/proto/management.pb.go
| Commit: | 2623fee | |
|---|---|---|
| Author: | Pascal Fischer | |
| Committer: | GitHub | |
[management] remove ingress ports (#8062)
| Commit: | cef7f0e | |
|---|---|---|
| Author: | pascal | |
| Committer: | pascal | |
revert proto
| Commit: | f31fe82 | |
|---|---|---|
| Author: | pascal | |
remove port-forwarding
| Commit: | ea5cf82 | |
|---|---|---|
| Author: | Viktor Liu | |
| Committer: | Viktor Liu | |
Merge main into poc/certificate-posture
| Commit: | 2dd25ec | |
|---|---|---|
| Author: | Zoltán Papp | |
Merge branch 'main' into fix/pkce-flow-session-extend # Conflicts: # client/ios/NetBirdSDK/login.go # client/server/server.go # shared/management/proto/management.pb.go
| Commit: | 1bae44e | |
|---|---|---|
| Author: | riccardom | |
Merge branch 'main' into feat-post_quantum_ml_kem # Conflicts: # client/internal/peer/conn.go # client/internal/peer/handshaker.go
| Commit: | 863410a | |
|---|---|---|
| Author: | mlsmaycon | |
[management,proxy] Simplify target access rollout Use protobuf compatibility instead of capability negotiation, and recommend proxy upgrades before using target actions. Keep existing behavior on older proxies, initialize routes when adding the first HTTP target, and split access validation into focused helpers.
| Commit: | 7e941b9 | |
|---|---|---|
| Author: | mlsmaycon | |
[management,proxy] Add per-target HTTP access control Allow individual HTTP locations to inherit service authentication, bypass it, or block requests while retaining literal-prefix routing. Keep authentication and forwarding on the same target snapshot, preserve existing policies in legacy updates, and gate activation on proxy capability support. Add unit, race-safe concurrency, database, integration, and container end-to-end coverage alongside proxy documentation.
| Commit: | 30dd076 | |
|---|---|---|
| Author: | Bethuel Mmbaga | |
| Committer: | GitHub | |
[management,proxy] Use single-use codes for OIDC session handoff (#7635) * Generalize PKCE verifier store into SingleUseStore * Generalize PKCE verifier store into SingleUseStore * Extend single-use store to generate one-time retrieval codes * Hand off proxy OIDC session via one-time code instead of URL token * Use the single-use store in integration tests * Read active proxy versions by cluster * Detect proxy clusters that support session codes * Bind OIDC session handoff mode to signed state * Deprecate legacy OIDC session token handoff * Remove unrelated session code test stub * fix tests * fix merge * Fix session code compatibility detection * Isolate proxy session codes in shared cache * bump min session version
| Commit: | 619b687 | |
|---|---|---|
| Author: | bcmmbaga | |
Deprecate legacy OIDC session token handoff
| Commit: | 87103f9 | |
|---|---|---|
| Author: | Viktor Liu | |
Merge branch 'reverse-proxy-allow-match-or' into reverse-proxy-crowdsec-appsec # Conflicts: # proxy/internal/auth/middleware.go # proxy/internal/auth/middleware_test.go # proxy/internal/auth/tunnel_lookup_test.go # proxy/management_integration_test.go # proxy/server.go # shared/management/proto/proxy_service.pb.go
| Commit: | 6f4b2e0 | |
|---|---|---|
| Author: | Viktor Liu | |
Merge remote-tracking branch 'origin/main' into HEAD # Conflicts: # shared/management/proto/proxy_service.pb.go
| Commit: | 37eca69 | |
|---|---|---|
| Author: | bcmmbaga | |
Hand off proxy OIDC session via one-time code instead of URL token
| Commit: | 5d9e791 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
Fix comments
| Commit: | cec9ee6 | |
|---|---|---|
| Author: | Theodor Midtlien | |
| Committer: | GitHub | |
[Client] Surface readable Authz errors and add profile claim command (#7540) * [client] Surface error messages for IPC authz in UI (#7553)
| Commit: | 75bb512 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
| Committer: | Theodor S. Midtlien | |
(WIP) Add claim command and surface readable Authz Gate errors
| Commit: | 15003fc | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
| Committer: | Theodor S. Midtlien | |
Add owners to list profile ipc
| Commit: | 2ec78d2 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
(WIP) Add claim command and surface readable Authz Gate errors
| Commit: | 91f1a72 | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
Adds observability and fixes cross cases - strict-kem vs strict-rp said "Connected + Quantum resistance: true" but it is actually blocked - perm-kem vs perm-rp "Connected + Quantum resistance: true" but it's a classic WG link, without PQ safety
| Commit: | 6a42f7d | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
Communicate the port over the signal exchange
| Commit: | 6a644df | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
Protocol update
| Commit: | c71fd1d | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Default to NetBird's upload service when nothing is configured The previous commit made a peer with no destination — no MDM override, no URL named by the caller, nothing published by its management server — refuse to upload and keep the bundle local unless it was enrolled with NetBird's cloud. That closed the reported data-boundary concern, but it broke the default for everyone who uploads a bundle as part of their day: a self-hosted user opening a support ticket got a refusal where the command used to work. Product decision (NetBird's, not the reporter's): the knob to keep bundles inside your own infrastructure is what this branch provides, and it is enough. The default stays the service NetBird runs, self-hosted included. An admin who needs the bundles to stay in-house configures the destination; until then the everyday flow keeps working. So ResolveUploadURL drops the cloud check, the sentinel error and the managementURL argument, and never fails: MDM > explicitly named URL > published by management > NetBird's service Nothing observable changes for a deployment that configures nothing, which also removes two edge cases the fail-closed default had: a peer still enrolled on the legacy api.wiretrustee.com host would have been classified self-hosted and refused, and an upgrade would have silently stopped uploads for self-hosted deployments relying on them. The privilege gate is unaffected — a host other than the default one still requires a privileged caller, so pointing the CLI somewhere other than what management published needs root.
| Commit: | 9f6d17b | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Take the debug-bundle upload destination from management The debug-bundle paths that upload without a human picking a destination compiled the vendor endpoint in: the mobile clients and the desktop UI hold `https://upload.debug.netbird.io/upload-url` as a constant, the CLI defaults its flag to it, and the remote job falls back to it when nothing else is set. A self-hosted deployment therefore shipped peer logs, routes, DNS and firewall state to NetBird-run infrastructure without its operator ever configuring that, and had no way to point those paths anywhere else. #7147 and #7153 gave the remote job a per-job URL and an MDM override, but neither reaches the mobile, UI or CLI paths, and both fail open when unset. Publish the destination from the management server instead, on the channel that already carries stun/turn/signal/relay/flow/metrics: - `NetbirdConfig.debug.upload_url`, sourced from the new account setting `debug_bundle_upload_url` (REST + dashboard) and falling back to the new `DebugUpload.URL` in the management server config, which a self-hosted install can set once so a fresh account is not left on the vendor default. Both are validated as https-with-host where they are written; a change fans out to connected peers rather than waiting for the next login. - One resolver on the client, `debug.ResolveUploadURL`, used by every path: MDM override > explicitly named URL > destination published by management > the NetBird service, but only for a peer enrolled with NetBird's cloud. Anything else fails closed with ErrNoUploadDestination and the bundle stays local, which is the behaviour change: a self-hosted deployment that names no upload service no longer uploads at all. - The engine keeps the published value (`Engine.DebugUploadURL`) so the bundle paths, which run off the engine loop, do not have to read it back out of the opt-in sync-response store. - The daemon request grows `upload`, so "upload to wherever this deployment says" is expressible; an empty `uploadURL` no longer has to mean "no upload". The privilege gate is unchanged and still applies only to a URL the local caller named — a destination published by management is the operator naming their own service. - The desktop UI stops carrying a vendor URL of its own and sends the intent. Reported privately as GHSA-hf99-43rj-h577.
| Commit: | d25661a | |
|---|---|---|
| Author: | riccardom | |
| Committer: | riccardom | |
[management,client] Take the debug-bundle upload destination from management The debug-bundle paths that upload without a human picking a destination compiled the vendor endpoint in: the mobile clients and the desktop UI hold `https://upload.debug.netbird.io/upload-url` as a constant, the CLI defaults its flag to it, and the remote job falls back to it when nothing else is set. A self-hosted deployment therefore shipped peer logs, routes, DNS and firewall state to NetBird-run infrastructure without its operator ever configuring that, and had no way to point those paths anywhere else. #7147 and #7153 gave the remote job a per-job URL and an MDM override, but neither reaches the mobile, UI or CLI paths, and both fail open when unset. Publish the destination from the management server instead, on the channel that already carries stun/turn/signal/relay/flow/metrics: - `NetbirdConfig.debug.upload_url`, sourced from the new account setting `debug_bundle_upload_url` (REST + dashboard) and falling back to the new `DebugUpload.URL` in the management server config, which a self-hosted install can set once so a fresh account is not left on the vendor default. Both are validated as https-with-host where they are written; a change fans out to connected peers rather than waiting for the next login. - One resolver on the client, `debug.ResolveUploadURL`, used by every path: MDM override > explicitly named URL > destination published by management > the NetBird service, but only for a peer enrolled with NetBird's cloud. Anything else fails closed with ErrNoUploadDestination and the bundle stays local, which is the behaviour change: a self-hosted deployment that names no upload service no longer uploads at all. - The engine keeps the published value (`Engine.DebugUploadURL`) so the bundle paths, which run off the engine loop, do not have to read it back out of the opt-in sync-response store. - The daemon request grows `upload`, so "upload to wherever this deployment says" is expressible; an empty `uploadURL` no longer has to mean "no upload". The privilege gate is unchanged and still applies only to a URL the local caller named — a destination published by management is the operator naming their own service. - The desktop UI stops carrying a vendor URL of its own and sends the intent. Reported privately as GHSA-hf99-43rj-h577.
| Commit: | 04b8bd2 | |
|---|---|---|
| Author: | Theodor S. Midtlien | |
Merge branch 'main' into profile-ownership
| Commit: | f372ed0 | |
|---|---|---|
| Author: | Viktor Liu | |
| Committer: | Viktor Liu | |
Merge branch 'main' into embedded-vnc