These commits are when the Protocol Buffers files have changed: (only the last 100 relevant commits are shown)
| Commit: | 7c63f7b | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
profiles: Add better doc and samples for the period_type / period fields. (#791)
The documentation is generated from this commit.
| Commit: | d17c0b5 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: improve documentation on single value without timestamp (#811) Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
| Commit: | 7f6408c | |
|---|---|---|
| Author: | Ivo Anjo | |
| Committer: | GitHub | |
processcontext: add `ProcessContext` message from OTEP 4719 (#783) Co-authored-by: Florian Lehner <florianl@users.noreply.github.com> Co-authored-by: Robert Pająk <pellared@hotmail.com>
| Commit: | c54a8ea | |
|---|---|---|
| Author: | Christos Kalkanis | |
| Committer: | GitHub | |
Minor documentation updates to profiles.proto (#780)
| Commit: | 6a9a37f | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: improve Link message encoding documentation (#792)
| Commit: | f0b3759 | |
|---|---|---|
| Author: | Lion Wagner | |
| Committer: | GitHub | |
docs: Fix link to UCUM website (#758)
| Commit: | 3ca54b6 | |
|---|---|---|
| Author: | Felix Geisendörfer | |
| Committer: | GitHub | |
Declare profiling alpha (#775) Co-authored-by: Roger Coll <roger.coll@elastic.co>
| Commit: | 9774645 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
[common] rename _ref suffix to _strindex (#768) Rename the experimental profiling field suffix from _ref _to _strindex to align with the naming in the profiles proto. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
| Commit: | 2c8b633 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
[resource] introduce reference based attributes (#733) * [resource] introduce reference based attributes Reduce duplicate entries by using a reference based approach in combination with a lookup table. Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * add missing dict_attributes field name * Apply suggestion from @florianl * Apply suggestion from @florianl * use reference in AnyValue Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * fix import path Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * fixup: add new line Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * rename fields Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * restructure reference based approach Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * drop strindex in AnyValue Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * apply https://docs.google.com/document/d/1v-XlgxnyyIsT-azCsfHJdRzVx-Ei2bIKB4hrYZQ6rGE Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * drop reference in AnyValue.oneof approach Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * return to AnyRefValue approach Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * fix field number Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * revert to AnyValue approach Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * drop remaining comment Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * extend comment Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * add reference to KeyValue Signed-off-by: Florian Lehner <florian.lehner@elastic.co> --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
| Commit: | a5f0eac | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Clarify the profile and sample timestamps relationship. (#744)
| Commit: | be43d11 | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: clarify Sample message usage guidance docs. (#742) --------- Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
| Commit: | 60ed56c | |
|---|---|---|
| Author: | Robert Pająk | |
| Committer: | GitHub | |
logs: SEVERITY_NUMBER_UNSPECIFIED can be used as severity_number is optional (#736) * logs: SEVERITY_NUMBER_UNSPECIFIED can be used as severity_number is optional * add PR number * Fix typo in CHANGELOG.md --------- Co-authored-by: Josh Suereth <Joshua.Suereth@gmail.com>
| Commit: | e8f1361 | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: improve Sample message clarity and usage documentation. (#724) * profiles: improve Sample message clarity and usage documentation. * profiles: improve Sample message clarity and usage documentation. Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> * profiles: improve Sample message clarity and usage documentation. Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> * profiles: improve Sample message clarity and usage documentation. * profiles: improve Sample message clarity and usage documentation. --------- Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co> Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com> Co-authored-by: Josh Suereth <Joshua.Suereth@gmail.com>
| Commit: | b77e3d9 | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Clarify dictionary guidelines: duplicates and orphaned items (#732) Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
| Commit: | 024778c | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop profile.comment_strindices (#729) Follow up as https://github.com/open-telemetry/semantic-conventions/pull/2861 go merged. Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
| Commit: | da51680 | |
|---|---|---|
| Author: | Nayef Ghattas | |
| Committer: | GitHub | |
Fix schema_url comments to include scope field coverage (#727) The schema_url field applies to both the instrumentation scope and the telemetry data fields, not just the telemetry data. Updated comments in all four signal proto files (logs, trace, metrics, profiles) to accurately reflect this. Co-authored-by: Liudmila Molkova <neskazu@gmail.com>
| Commit: | 9815b34 | |
|---|---|---|
| Author: | Robert Pająk | |
| Committer: | GitHub | |
all: drop attribute values restrictions (#707) * all: drop attribute values restrictions * add changelog entry * revert wording * revert wording * Revise changelog with important attribute values note * more explicit changelog entry * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
| Commit: | 570bf8a | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
[profiles] Clarify the original payload field comments. (#722) * Clarify the original payload field comments.
| Commit: | 0d02f21 | |
|---|---|---|
| Author: | Josh Suereth | |
| Committer: | GitHub | |
Fixes #207 - Add Style guide for proto comments. (#717) * Fixes #207 - Add Style guide for proto comments. * Update comments to match style guide. * Fixes from review. * Update opentelemetry/proto/metrics/v1/metrics.proto Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> --------- Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 30fc161 | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Add a note about cardinality implications for attribute values. (#713)
| Commit: | 8e72d7a | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Document more explicitly the dictionary zero element requirement. (#711) Right now we have a comment to the dictionary proto and a comment to the string_table field. This requirement is important enough I think that it's worth documenting it more explicitly, especially the part that even if there are no references to the particular dictionary, the zero index element must still be present.
| Commit: | 99fc853 | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Rename line -> lines and sample -> samples since these are repeated fields (#712)
| Commit: | a59a58f | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Remove aggregation temporality enum and field. (#710)
| Commit: | 57a5849 | |
|---|---|---|
| Author: | Christos Kalkanis | |
| Committer: | GitHub | |
Profiles: simplify profile stack trace representation (ASCII fix, conflicts resolved) (#708) * Simplify profile stack trace representation - Introduce a first-class Stack message type and lookup table. - Replace location index range based stack trace encoding on Sample with a single stack_index reference. - Remove the location_indices lookup table. The primary motivation is laying the ground work for [timestamp based profiling][timestamp proposal] where the same stack trace needs to be referenced much more frequently compared to aggregation based on low cardinality attributes. Timestamp based profiling is also expected to be used with the the upcoming [Off-CPU profiling][off-cpu pr] feature in the eBPF profiler. Off-CPU stack traces have a different distribution compared to CPU samples. In particular stack traces are much more repetitive because they only occur at call sites such as syscalls. For the same reason it is also uncommon to see a stack trace are a root-prefix of a previously observed stack trace. We might need to revisit the previous [previous benchmarks][benchmarks] to confirm these claims. The secondary motivation is simplicitly. Arguably the proposed change here will make it easier to write exporters, processors as well as receivers. It seems like we had rough consensus around this change in previous SIG meetings, and it seems like a good incremental step to make progress on the timestamp proposal. [timestamp proposal]: https://github.com/open-telemetry/opentelemetry-proto/pull/594 [off-cpu pr]: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/196 [benchmarks]: https://docs.google.com/spreadsheets/d/1Q-6MlegV8xLYdz5WD5iPxQU2tsfodX1-CDV1WeGzyQ0/edit?gid=2069300294#gid=2069300294 Modified-by: Christos Kalkanis <christos.kalkanis@elastic.co> * Update ASCII diagram for new Stack message * Move leaf frame explanation to field inside Stack message * Update field number * Update ASCII diagram (Sample->Stack n-1 instead of 1-1) --------- Co-authored-by: Felix Geisendörfer <felix@felixge.de>
| Commit: | 53b4bbd | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: improve attribute encoding in ProfilesDictionary (#672) Subsequent to #659 (profiles: avoid 'optional' keyword usage) and in accordance with discussions in the profiling SIG, this PR updates the dictionary message docs to impose a more consistent handling of 'null pointer' semantics in the encoding pattern.
| Commit: | 3ec4649 | |
|---|---|---|
| Author: | Frederic Branczyk | |
| Committer: | GitHub | |
Move zero-element comment about dictionary tables (#698)
| Commit: | c0d08a6 | |
|---|---|---|
| Author: | Christos Kalkanis | |
| Committer: | GitHub | |
Unsigned Profile time_nanos and duration_nanos (#692) We are already using unsigned type for [Sample.timestamps_unix_nano](https://github.com/open-telemetry/opentelemetry-proto/blob/b14635e74b7909c9f55db39666c667d4ea3092b7/opentelemetry/proto/profiles/v1development/profiles.proto#L422-L424) but not for the time-related fields in [Profile](https://github.com/open-telemetry/opentelemetry-proto/blob/b14635e74b7909c9f55db39666c667d4ea3092b7/opentelemetry/proto/profiles/v1development/profiles.proto#L235-L237). Also see: - #691
| Commit: | 57a8038 | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: Clarify ProfilesDictionary table[0] element use docs. (#688) Makes clear that all dictionary table fields should encode a 'null' element at index 0, such that optional fields pointing into the tables can use 0 value to indicate null.
| Commit: | edccbde | |
|---|---|---|
| Author: | Robert Pająk | |
| Committer: | GitHub | |
all: add notes about the attribute values restrictions (#683)
| Commit: | a116342 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop Location.is_folded (#690) Similar to the boolean attributes `Mapping.has_*` (https://github.com/open-telemetry/opentelemetry-proto/pull/595 and https://github.com/open-telemetry/semantic-conventions/pull/2522) also drop `Location.is_folded`. The complementary PR for the OTel SemConv, that builds on top of https://github.com/open-telemetry/semantic-conventions/pull/2522 is https://github.com/florianl/semantic-conventions/pull/1 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 7e2e91a | |
|---|---|---|
| Author: | dd-ryanrosario | |
| Committer: | GitHub | |
updated ScopeProfiles to Profiles relationship to 1-n (#684) Updated the relationship between `ScopeProfiles` and `Profile` from 1-1 to 1-n in the relationships diagram. This is a documentation-only change that fixes the diagram to accurately reflect the actual data model. The protobuf message definition shows: ``` message ScopeProfiles { // The instrumentation scope information for the profiles in this message. // Semantically when InstrumentationScope isn't set, it is equivalent with // an empty instrumentation scope name (unknown). opentelemetry.proto.common.v1.InstrumentationScope scope = 1; // A list of Profiles that originate from an instrumentation scope. repeated Profile profiles = 2; ... } ``` The `repeated Profile profiles` field indicates a one-to-many relationship, where a single `ScopeProfiles` can contain multiple `Profile` instances. The inconsistency in the diagram seems to have originated [here](https://github.com/open-telemetry/opentelemetry-proto/commit/7312bdf63218acf27fe96430b7231de37fd091f2) when removing `ProfileContainer`.
| Commit: | b14635e | |
|---|---|---|
| Author: | Alexey Alexandrov | |
| Committer: | GitHub | |
Replace has_* fields with an enum. (#595) The has_* debug info fields were derived from the pprof format. We decided to move them to attributes, see https://github.com/open-telemetry/semantic-conventions/pull/2522.
| Commit: | 8048149 | |
|---|---|---|
| Author: | Felix Geisendörfer | |
| Committer: | GitHub | |
profiles: remove default_sample_type (#679) This resolves the ambiguity when a `ScopesProfiles` message contains more than one `profiles` entry matching the `default_sample_type`. Also add a comment to clarify which profile viewers should display by default. This was previously also ambiguous. This change creates a minor problem when it comes to ensuring that pprof profiles can round-trip through otel conversion as it may require the `ScopeProfiles.profiles` entries to be reordered in order to honor the `default_sample_type` of the original pprof message. Naively converting the resulting otel profile back to pprof would cause the order of `Profile.sample_types` to be changed. Merging this change indiciates consensus within the profiling group that this issue should be handled by adding a `pprof.profile_order` attribute (name TBD) to the `ScopeProfiles.attributes` during the initial pprof->otel conversion. This label will allow converting the resulting otel profile back to pprof without any information loss. See [gh-633][] for additional details. [gh-633]: https://github.com/open-telemetry/opentelemetry-proto/issues/633#issuecomment-3056622636 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | c306100 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: use single Profile.sample_type and clarify use of timestamps (#649) Implements https://github.com/open-telemetry/opentelemetry-proto/issues/633#issuecomment-2772648117.
| Commit: | 5b0dc10 | |
|---|---|---|
| Author: | Francesco Andreuzzi | |
| Committer: | GitHub | |
profiles: make profile_id optional (#665) Fixes #652 Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 29ad186 | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: avoid 'optional' keyword usage (#659) Prefer reference tables with an explicit null/unused entry at index=0, rather than 'optional' pointers into the tables. Following discussion in the profiling SIG, we note that other OpenTelemetry signal types don't use 'optional' protobuf fields and, whilst the Dictionary lookup tables pattern in the profile signal type require some form of 'null pointer' value for indicating unset indexes into the tables, the string_table convention inherited from pprof prefers table[0] = "" i.e. treats a 0 value pointer as null. In the interest of improving consistency with other signal types and within the profiling signal itself, we therefore make mapping and link tables/references follow the same convention of having an explicit 'not used' default value as the first element in the dictionary table. Note that I've chosen to not update the docs for the other dictionary tables to require the same use of the [0] slot, as at present no _index fields optionally reference into them, so I'm treating it as unnecessary at this time. However, it can be argued that greater clarity and consistency would be achieved by making the convention universal in anticipation before adoption becomes widespread and it gets harder to change.
| Commit: | b6ec07e | |
|---|---|---|
| Author: | Felix Geisendörfer | |
| Committer: | GitHub | |
profiles: drop gzip requirement (#661) There is no need for us to specifiy compression requirements on OpenTelemetry profiles. This should be defined by OTLP, see [spec]. For #629 [spec]: https://opentelemetry.io/docs/specs/otlp/#protocol-details Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | f7676e8 | |
|---|---|---|
| Author: | Damien Mathieu | |
| Committer: | GitHub | |
Move the profiles lookup tables into a new Dictionary message (#650)
| Commit: | f24da8d | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: Move lookup tables to ProfilesData (#644) Implements https://github.com/open-telemetry/opentelemetry-proto/issues/628#issuecomment-2772566325. Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com> Co-authored-by: Nayef Ghattas <11560964+Gandem@users.noreply.github.com>
| Commit: | 42319f8 | |
|---|---|---|
| Author: | Robert Pająk | |
| Committer: | GitHub | |
Stabilize event_name in LogRecord (#643)
| Commit: | a46b66e | |
|---|---|---|
| Author: | Tristan Sloughter | |
| Committer: | GitHub | |
remove comment on each profile service about keeping the RPC alive (#637) Tigran explained this comment was likely a hold over from the OpenCensus protobufs which did use streaming RPC's. Unary RPC's, which are used by the OpenTelemetry protocol, can not be kept alive making the comment out of place. Co-authored-by: Josh Suereth <Joshua.Suereth@gmail.com>
| Commit: | e4fd4f6 | |
|---|---|---|
| Author: | Josh Suereth | |
| Committer: | GitHub | |
Add EntityRef and use it in Resource. (#635) * Add EntityRef and use it in Resource. * Update opentelemetry/proto/resource/v1/resource.proto Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> * Update opentelemetry/proto/common/v1/common.proto Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> * Update opentelemetry/proto/common/v1/common.proto Co-authored-by: Nathan L Smith <nathan.smith@elastic.co> --------- Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
| Commit: | 9d7c091 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: clarify use of optional fields in message Line and message Function (#621)
| Commit: | 8601239 | |
|---|---|---|
| Author: | Patrice Chalin | |
| Committer: | GitHub | |
Update metrics.proto (#632)
| Commit: | 101755a | |
|---|---|---|
| Author: | Tigran Najaryan | |
| Committer: | GitHub | |
Clarify when bucket_counts array may be empty (#619) The current definition says: "The number of elements in bucket_counts array must be by one greater than the number of elements in explicit_bounds array." However, it also says "bucket_counts is an optional field", which means its length can be 0, which than in turn means the length of explicit_bounds must be -1, which is impossible. We clarify that it is a valid situation to have both bucket_counts and explicit_bounds arrays empty.
| Commit: | 298a60f | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: switch default sample type index from string_table to sample_type array (#620) Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 6a4f4e4 | |
|---|---|---|
| Author: | Patrice Chalin | |
| Committer: | GitHub | |
[editorial] Use canonical URL to OpenMetrics repo (#617)
| Commit: | 849dc40 | |
|---|---|---|
| Author: | Felix Geisendörfer | |
| Committer: | Felix Geisendörfer | |
Simplify profile stack trace representation - Introduce a first-class Stack message type and lookup table. - Replace location index range based stack trace encoding on Sample with a single stack_index reference. - Remove the location_indices lookup table. The primary motivation is laying the ground work for [timestamp based profiling][timestamp proposal] where the same stack trace needs to be referenced much more frequently compared to aggregation based on low cardinality attributes. Timestamp based profiling is also expected to be used with the the upcoming [Off-CPU profiling][off-cpu pr] feature in the eBPF profiler. Off-CPU stack traces have a different distribution compared to CPU samples. In particular stack traces are much more repetitive because they only occur at call sites such as syscalls. For the same reason it is also uncommon to see a stack trace are a root-prefix of a previously observed stack trace. We might need to revisit the previous [previous benchmarks][benchmarks] to confirm these claims. The secondary motivation is simplicitly. Arguably the proposed change here will make it easier to write exporters, processors as well as receivers. It seems like we had rough consensus around this change in previous SIG meetings, and it seems like a good incremental step to make progress on the timestamp proposal. [timestamp proposal]: https://github.com/open-telemetry/opentelemetry-proto/pull/594 [off-cpu pr]: https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/196 [benchmarks]: https://docs.google.com/spreadsheets/d/1Q-6MlegV8xLYdz5WD5iPxQU2tsfodX1-CDV1WeGzyQ0/edit?gid=2069300294#gid=2069300294
| Commit: | d4a4703 | |
|---|---|---|
| Author: | David Ashpole | |
| Committer: | GitHub | |
update links to openmetrics to reference the v1.0.0 release (#612)
| Commit: | ae87ce7 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profile: drop duplicate field in message Profile (#606) * profile: drop duplicate field in message Profile The message Profile contains two fields of type `opentelemetry.proto.common.v1.KeyValue`, `attribute_table` and `attributes`. Both fields are intended for the same use. Therefore drop the later one. * fixup: add attribute_indices to message Profile Signed-off-by: Florian Lehner <florian.lehner@elastic.co> * fixup: move comment Signed-off-by: Florian Lehner <florian.lehner@elastic.co> --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
| Commit: | fcebfd2 | |
|---|---|---|
| Author: | Liudmila Molkova | |
| Committer: | GitHub | |
Add `event_name` to logs proto (#600) * Add event_name to log proto
| Commit: | 653d802 | |
|---|---|---|
| Author: | jack-berg | |
| Committer: | GitHub | |
Add note about schema url and schema version (#605)
| Commit: | 9098604 | |
|---|---|---|
| Author: | Damien Mathieu | |
| Committer: | GitHub | |
Remove unused label from profiles (#602)
| Commit: | 793e43e | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
Renovations to experimental profiling schema. (#596) - remove Profile keep_frames and drop_frames due to unclear semantics and use cases - make Sample.link_index and Location.mapping_index optional, consistent with documented intention - remove deprecated fields Sample.location_index, Mapping.id, Location.id, Function.id - renumber fields for improved redability
| Commit: | d77c317 | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
Improve lookup table pattern use in profiles. (#592) Based on implementation experience with the draft version of the profiles spec, the use of lookup tables for storing values is space efficient but not particularly user friendly. This change makes improvements by changing field names to clarify their role in the pattern and changing their data types to better accommodate their use in languages limited to 32 bit array indexing e.g. Java.
| Commit: | 7312bdf | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
Fold the content of pprofextended.proto into profiles.proto, removing ProfileContainer. (#590) This change removes the now unnecessary split of the profiling format between two files, combining them into one as with other protocols. In the process, the likewise unnecessary ProfileContainer message type is removed and its fields merged into Profile, saving one level of indirection. Note this as discussed on slack otel-profiles, this is effectively a minimal subset of the now defunct #587, remaining parts of which will be resubmitted in subsequent PRs. This PR effectively blocks any concurrent changes to pprofextended.proto e.g. #588 as git won't track such changes across the file 'merge'.
| Commit: | a76fe9d | |
|---|---|---|
| Author: | Alan West | |
| Committer: | GitHub | |
Clarify aggregation temporality for Summary metric type (#591)
| Commit: | a8f08fc | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: Make mapping in Profile optional (#556) As commented in [0] and discussed in the OTel Profiling SIG meeting, there are situations where a main binary for a Profile can not be identified. For these cases mark the field optional. FYI: @brancz @petethepig @open-telemetry/profiling-maintainers [0]: https://github.com/open-telemetry/opentelemetry-proto/pull/534#discussion_r1561141336
| Commit: | d785e67 | |
|---|---|---|
| Author: | Damien Mathieu | |
| Committer: | GitHub | |
Rename profiles v1experimental to v1development (#585) As discussed in https://github.com/open-telemetry/opentelemetry-proto/pull/582#discussion_r1751850589, this renames the `v1experimental` version for profiles to `v1development`. I've also taken this opportunity to update the versioning and stability link.
| Commit: | 4f69356 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop BuildIdKind (#584) Drop `BuildIdKind` in favor of its semantic convention as defined in https://github.com/open-telemetry/semantic-conventions/pull/1329. Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 9408ae8 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop Sample.label (#583) Drop `Sample.label` in favor of `Sample.attributes`. While `label` and `attributes` fulfill the same purpose, it is not defined which one choose for which information. Therefore, drop `label` in favor of `attributes`. FYI: @open-telemetry/profiling-maintainers spec:profiles Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 8265a53 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop Location.type_index (#578) With https://github.com/open-telemetry/semantic-conventions/pull/1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged. Therefore, `Location.type_index` is no longer needed. FYI: @open-telemetry/profiling-maintainers Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 833a4eb | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: drop Sample.stacktrace_id_index (#575) The value for Sample.stacktrace_id_index is hardly defined except for its length. It is also not defined how this value should be generated, interpreted and could be used. Some kind of stacktrace_id can be most efficient in stateful protocols, where transmitting duplicate information should be avoided. As the OTel Profiling protocol is a stateless protocol, this element can be droped.
| Commit: | 14afbd4 | |
|---|---|---|
| Author: | Florian Lehner | |
| Committer: | GitHub | |
profiles: align type of index into string table (#557) With `Mapping.filename`, `Function.name`, `Label.key` and others the type of the index into the string table is always of type `int64`. For consistency align the type of `Location.type_index`, which is also an index into the string table, to `int64`. Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | ff457ce | |
|---|---|---|
| Author: | Krisztian Fekete | |
| Committer: | GitHub | |
Add resource attributes and scope to metrics proto diagram (#519) Fixes https://github.com/open-telemetry/opentelemetry-proto/issues/518.
| Commit: | bd7cf55 | |
|---|---|---|
| Author: | Long Yang | |
| Committer: | GitHub | |
Fix typo; According to the definition of message Sample, the relation between Sample and Link should be n-1 (#564)
| Commit: | a05597b | |
|---|---|---|
| Author: | Jonathan Halliday | |
| Committer: | GitHub | |
profiles: add missing java_package option to pprofextended. (#558) Gah, we put java_package on one file but not the other. Oops. Apparently the opentelementry-proto-java artifact can't be consumed by opentelemetry-java without this.
| Commit: | 4b60b81 | |
|---|---|---|
| Author: | Dmitry Filimonov | |
| Committer: | GitHub | |
Add new profile signal (#534) This is a follow up to [OTEP 239: Introduces Profiling Data Model v2](https://github.com/open-telemetry/oteps/pull/239) The main motivation behind this PR is that this will allow us to start experimenting with the profiles proto in opentelemetry-collector. I marked the profiles part as `Experimental` to indicate that this is not a final version of the data model. I copied the proto from the OTEP, and moved `pprofextended.proto` from `profiles/v1/alternatives/pprofextended.proto` to just `profiles/v1/pprofextended.proto`. I did this because I figured we no longer have alternative representations and this will reduce confusion for people outside of Profiling SIG. The rest of the proto stayed the same. I tested this file with a collector fork and I it compiles properly.
| Commit: | c451441 | |
|---|---|---|
| Author: | David Ashpole | |
| Committer: | GitHub | |
Add metric.metadata for supporting additional metadata on metrics (#514) * add metric.attributes for supporting additional metadata on metrics
| Commit: | 0a743e7 | |
|---|---|---|
| Author: | jack-berg | |
| Committer: | GitHub | |
Clarify formulas for reading span flags (#528) * Add bitshift to comment for reading span flags * Change >> to != 0
| Commit: | fd386f1 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Merge parent and link is remote enums into one
| Commit: | 0941511 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
| Commit: | 964a94c | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
| Commit: | 473303b | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Use enum for ParentSpanIsRemote
| Commit: | a2a8f8b | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Adjust enum name
| Commit: | 0126795 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Add constants and enum for interpreting bits 8 and 9 of a Link's flags
| Commit: | bd30ca3 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Remove misleading documentation
| Commit: | e75abec | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Update names
| Commit: | 123368f | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Remove ParentSpanIsRemote attribute
| Commit: | de281de | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Change doc references to updated enum name
| Commit: | 35e442e | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Adjust flags documentation ordering
| Commit: | a3cd778 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | d0eb3f8 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
| Commit: | 4174021 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
| Commit: | 3299be0 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Update references to isremote masks
| Commit: | e7829c5 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
| Commit: | bd7b09e | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 3a03077 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
| Commit: | 28d81a4 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Adjust formatting of comments
| Commit: | 6b2be20 | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Johannes Tax <johannes@johannes.tax>
| Commit: | 6b5d30a | |
|---|---|---|
| Author: | Emily S | |
| Committer: | Tigran Najaryan | |
Update opentelemetry/proto/trace/v1/trace.proto Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
| Commit: | 3c37369 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Include enum for interpreting ParentIsRemote flag and update documentation
| Commit: | 7df29cd | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Split isremote into two masks
| Commit: | 1635398 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Remove enum, describe values in comment
| Commit: | ef0a3b1 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Add extra comment about unset value from older clients
| Commit: | acc967d | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Add parent_span_is_remote to Span message
| Commit: | 9076d8f | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Update inconsistency in docs formatting
| Commit: | 095d378 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
Add defintion of 2 bit parent is remote flag
| Commit: | 3d7b4a4 | |
|---|---|---|
| Author: | Emily Stolfo | |
| Committer: | Tigran Najaryan | |
One constant for link and parent is remote mask
| Commit: | f674adf | |
|---|---|---|
| Author: | Tigran Najaryan | |
| Committer: | GitHub | |
Remove irrelevant comments from metric name field (#512)