Proto commits in sonic-net/sonic-mgmt

These 12 commits are when the Protocol Buffers files have changed:

2025-02-25

Add a test for System.Time using gRPC python API (#17068) Description of PR Summary: Add a test for System.Time using gRPC python API Approach Add a test for System.Time, but instead of using our gnoi_client binary, use a generic python API. What is the motivation for this PR? Test interoperability between our golang GNOI server and any client, say using a generic python API. Also serves as a demonstration of how to write a gnoi client in python. How did you do it? git clone proto files in github.com/openconfig/gnoi fix imports in the relevant proto files. compile the proto file into python code using protoc fix import in the generated python code add the testcase How did you verify/test it? on KVM and physical switch:

The documentation is generated from this commit.

2023-10-10

[202205][dualtor-io] show mux port flaps (#9568) (#10266) What is the motivation for this PR? Cherry-pick PR #9568 into 202205 For dualtor-io tests, log the mux port flaps to better help debug. How did you do it? Add fixture check_simulator_flap_counter to show/check mux port flaps during test execution, and enable it for all dualtor-io testcases. How did you verify/test it? Run dualtor-io tests on both active-standby and active-active testbed. Any platform specific information? Supported testbed topology if it's a new test case? Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

2023-09-28

[dualtor-io] show mux port flaps (#9568) Approach What is the motivation for this PR? For dualtor-io tests, log the mux port flaps to better help debug. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? Add fixture check_simulator_flap_counter to show/check mux port flaps during test execution, and enable it for all dualtor-io testcases. How did you verify/test it? Run dualtor-io tests on both active-standby and active-active testbed. Any platform specific information? Supported testbed topology if it's a new test case?

2023-09-19

[dualtor-io] show mux port flaps (#9568) Approach What is the motivation for this PR? For dualtor-io tests, log the mux port flaps to better help debug. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? Add fixture check_simulator_flap_counter to show/check mux port flaps during test execution, and enable it for all dualtor-io testcases. How did you verify/test it? Run dualtor-io tests on both active-standby and active-active testbed. Any platform specific information? Supported testbed topology if it's a new test case?

2023-07-03

Add semicolons back to the proto files (#8761) Approach What is the motivation for this PR? Fix the gRPC proto files for nic simulator. How did you do it? Revert the change of the proto files made by PR#8017 How did you verify/test it? Use testbed-cli.sh to deploy the dualtor-aa topology, all steps passed. Any platform specific information? Supported testbed topology if it's a new test case?

2023-06-02

[dualtor][active-active] Add grpc server failure dualtor io testcases (#8475) Approach What is the motivation for this PR? As the subject, cherry-pick into 202205 branch Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? add mgmt rpc SetNicServerAdminState to nic_simulator add fixture stop_nic_grpc_server to simulator grpc server failure add two testcases: test_grpc_server_failure_config_standby_config_auto_upstream_active test_grpc_server_failure_config_standby_config_auto_downstream_standby How did you verify/test it? verified on dualtor-mixed testbed Any platform specific information?

2023-04-18

[pre-commit] Fix style issues in test scripts under `ansible/c*` to (#8017) What is the motivation for this PR? pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional. To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit. How did you do it? This change fixes the style issues of test scripts under ansible/c* to ansible/h*` folder

2023-04-12

[dualtor][active-active] Add grpc server failure dualtor io testcases (#7979) Approach What is the motivation for this PR? As the subject. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? add mgmt rpc SetNicServerAdminState to nic_simulator add fixture stop_nic_grpc_server to simulator grpc server failure add two testcases: test_grpc_server_failure_config_standby_config_auto_upstream_active test_grpc_server_failure_config_standby_config_auto_downstream_standby How did you verify/test it? verified on dualtor-mixed testbed

2023-01-18

[pre-commit] Fix style issues in test scripts under `tests/common/dualtor/nic_simulator` folder (#6913) * [pre-commit] Fix style issues in test scripts under `tests/common/dualtor/nic_simulator` folder What is the motivation for this PR? pre-commit is a static analysis tool introduced recently. This tool is not able to do diff-only check. It checks the whole files touched by PR. We can't blame PR author for legacy issues. That's why currently the pre-commit check is only optional. To ensure that we can make pre-commit a mandatory check for PRs submitted to this repository, we need to fix all the legacy issues complained by pre-commit. How did you do it? This change fixes the style issues of test scripts under `tests/common/dualtor/nic_simulator` folder How did you verify/test it? Any platform specific information? Supported testbed topology if it's a new test case?

2022-08-22

[dualtor][active-active] Enable `test_link_drop` (#6200) Approach What is the motivation for this PR? Enable test_link_drop on mux ports of cable type active-active How did you do it? 1. Add rpc call SetDrop for nic_simulator to drop flow, both upstream/downstream 2. Add fixture set_drop_active_active to call nic_simulator rpc call SetDrop to simulate link drop. 3. Enable two testcases: test_active_link_drop_upstream and test_active_link_drop_downstream_active How did you verify/test it?

2022-04-29

[nic_simulator] Correct proto service definitions (#5570) Approach What is the motivation for this PR? Correct protocol buffer service definitions. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? 1. modify nic_simulator_grpc_service.proto to have versions APIs. 2. modify nic_simulator.py accordingly to reflect protocol buffer changes. How did you verify/test it? Ensure nic_simulator_client.py could interacts with server.

2022-04-18

[dualtor] Add `nic_simulator` (#5413) ### Approach #### What is the motivation for this PR? Add `nic_simulator` to act as gRPC server to respond to requests from DUT operates in dualtor `active-active` mode. Signed-off-by: Longxiang Lyu <lolv@microsoft.com> #### How did you do it? Add script `nic_simulator.py` to start per-port gRPC server for a dualtor `active-active` setup testbed. It should run in the server NiCs namespace, and it basically does the following few things after it starts: 1. scans for all the ports in the namespace that follows the server NiC name pattern(`eth%d`) and finds its corresponding OVS bridge, the bridge will be verified to have the following topology: ``` +--------------+ PTF (host_if) --+ +----- upper_if | OVS bridge | netns (server_nic) --+ +----- lower_if +--------------+ ``` 2. starts to set up the flows for each OVS bridge collected in step1, the initial forwarding state is `(active, active)`. * the flows added: * `FLOW I`: for packets from `upper_if`, it will be duplicated to `host_if` and `server_nic`. * `FLOW II`: for packets from `lower_if`, it will be duplicated to `host_if` and `server_nic`. * `FLOW III`: for packets from `server_nic`, it will be duplicated to `upper_if` and `lower_if`. * `FLOW IV`: for packets from `host_if`, it will be directed to either `upper_if` or `lower_if`. 3. starts the gRPC services(one port, one server) to query/set the forwarding state of the bridge. * if upper ToR forwarding state is set to `standby`, `nic_simulator` will modify `FLOW IV` to let packets from `host_if` only be directed to lower ToR(`active`) **TODO** 1. Add RPC calls to cover testing scenarios like link drop and link down. 2. Add client authentication. 3. Implement `RPC` call `QueryOperationPortState` 4. add logging interceptors to the RPC calls. #### How did you verify/test it? 1. run the `nic_simulator.py` 2. run the `nic_simulator_client.py` to verify `nic_simulator` operations.